diff options
author | Benjamin Brahmer <info@b-brahmer.de> | 2022-08-06 14:07:36 +0200 |
---|---|---|
committer | Benjamin Brahmer <info@b-brahmer.de> | 2022-08-19 09:14:27 +0200 |
commit | c09cca75b50d94b2d0d14f43b1136527364573d0 (patch) | |
tree | 0a237e312da1fd4342ad8f2a10a2f5ed37c8e64b /lib/Db | |
parent | df04eb2723ea630c612d680d8e356e5d979f55e2 (diff) |
Fix deprecations
add phpstan deprecation rules
Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Diffstat (limited to 'lib/Db')
-rw-r--r-- | lib/Db/Item.php | 19 |
1 files changed, 11 insertions, 8 deletions
diff --git a/lib/Db/Item.php b/lib/Db/Item.php index 0ed9e9113..17bf4a048 100644 --- a/lib/Db/Item.php +++ b/lib/Db/Item.php @@ -170,10 +170,9 @@ class Item extends Entity implements IAPI, \JsonSerializable ? implode('', $this->getCategories()) : ''; + $stripedBody = ""; if (!is_null($this->getBody())) { $stripedBody = strip_tags($this->getBody()); - } else { - $stripedBody = ""; } $input_list = array($stripedBody, $this->getAuthor(), $this->getTitle(), $categoriesString); @@ -181,17 +180,14 @@ class Item extends Entity implements IAPI, \JsonSerializable $search_string = ""; foreach ($input_list as $value) { - if (is_null($value)) { - $search_string .= ""; - } else { + if (!is_null($value)) { $search_string .= html_entity_decode($value); } } $search_string .= $this->getUrl(); - $search_string .= 'UTF-8'; - $this->setSearchIndex(mb_strtolower($search_string)); + $this->setSearchIndex(mb_strtolower($search_string, 'UTF-8')); $this->setFingerprint($this->computeFingerprint()); $this->setContentHash($this->computeContentHash()); } @@ -358,6 +354,9 @@ class Item extends Entity implements IAPI, \JsonSerializable */ public function getCategories(): ?array { + if (is_null($this->getCategoriesJson())) { + return null; + } return json_decode($this->getCategoriesJson()); } @@ -606,6 +605,10 @@ class Item extends Entity implements IAPI, \JsonSerializable public function setUrl(string $url = null): self { + if (is_null($url)) { + return $this; + } + $url = trim($url); if ((strpos($url, 'http') === 0 || strpos($url, 'magnet') === 0) && $this->url !== $url @@ -613,7 +616,7 @@ class Item extends Entity implements IAPI, \JsonSerializable $this->url = $url; $this->markFieldUpdated('url'); } - + return $this; } |