split logic into business layers

5 files changed, 333 insertions, 19 deletions

diff --git a/js/tests/services/bl/feedblSpec.coffee b/js/tests/services/bl/feedblSpec.coffee
new file mode 100644
index 000000000..7cc2e9ab3
--- /dev/null
+++ b/js/tests/services/bl/feedblSpec.coffee
@@ -0,0 +1,109 @@
+###
+
+ownCloud - News
+
+@author Bernhard Posselt
+@copyright 2012 Bernhard Posselt nukeawhale@gmail.com
+
+This library is free software; you can redistribute it and/or
+modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
+License as published by the Free Software Foundation; either
+version 3 of the License, or any later version.
+
+This library is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU AFFERO GENERAL PUBLIC LICENSE for more details.
+
+You should have received a copy of the GNU Affero General Public
+License along with this library.  If not, see <http://www.gnu.org/licenses/>.
+
+###
+
+
+describe '_FeedBl', ->
+
+
+	beforeEach module 'News'
+
+	beforeEach inject (@_FeedBl, @FeedModel, @ItemModel, @_ItemBl) =>
+		@persistence =
+			getItems: ->
+
+		@itemBl = new _ItemBl(@ItemModel, @persistence)
+
+		@bl = new @_FeedBl(@FeedModel, @itemBl, @persistence)
+
+
+	it 'should return the number of unread feeds', =>
+		@FeedModel.add({id: 3, unreadCount:134, urlHash: 'a1'})
+		count = @bl.getUnreadCount(3)
+
+		expect(count).toBe(134)
+
+
+	it 'should return all feeds of a folder', =>
+		feed1 = {id: 3, unreadCount:134, urlHash: 'a1', folderId: 3}
+		feed2 = {id: 4, unreadCount:134, urlHash: 'a2', folderId: 2}
+		feed3 = {id: 5, unreadCount:134, urlHash: 'a3', folderId: 3}
+		@FeedModel.add(feed1)
+		@FeedModel.add(feed2)
+		@FeedModel.add(feed3)
+
+		feeds = @bl.getFeedsOfFolder(3)
+
+		expect(feeds).toContain(feed1)
+		expect(feeds).toContain(feed3)
+
+
+	it 'should get the correct unread count for folders', =>
+		@FeedModel.add({id: 3, unreadCount:134, folderId: 3, urlHash: 'a1'})
+		@FeedModel.add({id: 5, unreadCount:2, folderId: 2, urlHash: 'a2'})
+		@FeedModel.add({id: 1, unreadCount:12, folderId: 5, urlHash: 'a3'})
+		@FeedModel.add({id: 2, unreadCount:35, folderId: 3, urlHash: 'a4'})
+		count = @bl.getFolderUnreadCount(3)
+
+		expect(count).toBe(169)
+
+
+	it 'should delete feeds', =>
+		@FeedModel.removeById = jasmine.createSpy('remove')
+		@persistence.deleteFeed = jasmine.createSpy('deletequery')
+		@bl.delete(3)
+
+		expect(@FeedModel.removeById).toHaveBeenCalledWith(3)
+		expect(@persistence.deleteFeed).toHaveBeenCalledWith(3)
+
+
+
+	it 'should mark feed as read', =>
+		@persistence.setFeedRead = jasmine.createSpy('setFeedRead')
+		@FeedModel.add({id: 5, unreadCount:2, folderId: 2, urlHash: 'a1'})
+		@ItemModel.add({id: 6, feedId: 5, guidHash: 'a1'})
+		@ItemModel.add({id: 3, feedId: 5, guidHash: 'a2'})
+		@ItemModel.add({id: 2, feedId: 5, guidHash: 'a3'})
+		@bl.markFeedRead(5)
+
+		expect(@persistence.setFeedRead).toHaveBeenCalledWith(5, 6)
+		expect(@FeedModel.getById(5).unreadCount).toBe(0)
+
+
+	it 'should mark all as read', =>
+		@persistence.setFeedRead = jasmine.createSpy('setFeedRead')
+		@FeedModel.add({id: 3, unreadCount:134, folderId: 3, urlHash: 'a1'})
+		@FeedModel.add({id: 5, unreadCount:2, folderId: 2, urlHash: 'a2'})
+		@FeedModel.add({id: 1, unreadCount:12, folderId: 3, urlHash: 'a3'})
+
+		@bl.markAllRead()
+
+		expect(@FeedModel.getById(3).unreadCount).toBe(0)
+		expect(@FeedModel.getById(1).unreadCount).toBe(0)
+		expect(@FeedModel.getById(5).unreadCount).toBe(0)
+
+
+	it 'should get the correct unread count for subscribtions', =>
+		@FeedModel.add({id: 3, unreadCount:134, urlHash: 'a1'})
+		@FeedModel.add({id: 5, unreadCount:2, urlHash: 'a2'})
+		count = @bl.getUnreadCount()
+
+		expect(count).toBe(136)
\ No newline at end of file
diff --git a/js/tests/services/bl/folderblSpec.coffee b/js/tests/services/bl/folderblSpec.coffee
new file mode 100644
index 000000000..898aaecba
--- /dev/null
+++ b/js/tests/services/bl/folderblSpec.coffee
@@ -0,0 +1,82 @@
+###
+
+ownCloud - News
+
+@author Bernhard Posselt
+@copyright 2012 Bernhard Posselt nukeawhale@gmail.com
+
+This library is free software; you can redistribute it and/or
+modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
+License as published by the Free Software Foundation; either
+version 3 of the License, or any later version.
+
+This library is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU AFFERO GENERAL PUBLIC LICENSE for more details.
+
+You should have received a copy of the GNU Affero General Public
+License along with this library.  If not, see <http://www.gnu.org/licenses/>.
+
+###
+
+
+describe '_FolderBl', ->
+
+
+	beforeEach module 'News'
+
+	beforeEach inject (@_FolderBl, @FolderModel, @_FeedBl, @_ItemBl,
+					@FeedModel, @ItemModel) =>
+		@persistence =
+			getItems: ->
+		itemBl = new @_ItemBl(@ItemModel, @persistence)
+		feedBl = new @_FeedBl(FeedModel, itemBl, @persistence)
+		@bl = new @_FolderBl(@FolderModel, feedBl, @persistence)
+
+
+	it 'should delete folders', =>
+		@FolderModel.removeById = jasmine.createSpy('remove')
+		@persistence.deleteFolder = jasmine.createSpy('deletequery')
+		@bl.delete(3)
+
+		expect(@FolderModel.removeById).toHaveBeenCalledWith(3)
+		expect(@persistence.deleteFolder).toHaveBeenCalledWith(3)
+
+
+	it 'should return true when folder has feeds', =>
+		@FeedModel.add({id: 5, unreadCount:2, folderId: 2, urlHash: 'a1'})
+		expect(@bl.hasFeeds(3)).toBeFalsy()
+
+		@FeedModel.add({id: 2, unreadCount:35, folderId: 3, urlHash: 'a2'})
+		expect(@bl.hasFeeds(3)).toBeTruthy()
+
+
+	it 'should toggle folder', =>
+		@persistence.openFolder = jasmine.createSpy('open')
+		@persistence.collapseFolder = jasmine.createSpy('collapse')
+
+		@FolderModel.add({id: 3, open: false})
+		@bl.toggleFolder(4)
+		expect(@FolderModel.getById(3).open).toBeFalsy()
+
+		@bl.toggleFolder(3)
+		expect(@FolderModel.getById(3).open).toBeTruthy()
+		expect(@persistence.openFolder).toHaveBeenCalledWith(3)
+
+		@bl.toggleFolder(3)
+		expect(@FolderModel.getById(3).open).toBeFalsy()
+		expect(@persistence.collapseFolder).toHaveBeenCalledWith(3)
+
+
+	it 'should mark folder as read', =>
+		@persistence.setFeedRead = jasmine.createSpy('setFeedRead')
+		@FeedModel.add({id: 3, unreadCount:134, folderId: 3, urlHash: 'a1'})
+		@FeedModel.add({id: 5, unreadCount:2, folderId: 2, urlHash: 'a2'})
+		@FeedModel.add({id: 1, unreadCount:12, folderId: 3, urlHash: 'a3'})
+
+		@bl.markFolderRead(3)
+
+		expect(@FeedModel.getById(3).unreadCount).toBe(0)
+		expect(@FeedModel.getById(1).unreadCount).toBe(0)
+		expect(@FeedModel.getById(5).unreadCount).toBe(2)
\ No newline at end of file
diff --git a/js/tests/services/bl/itemblSpec.coffee b/js/tests/services/bl/itemblSpec.coffee
new file mode 100644
index 000000000..f46b178ac
--- /dev/null
+++ b/js/tests/services/bl/itemblSpec.coffee
@@ -0,0 +1,49 @@
+###
+
+ownCloud - News
+
+@author Bernhard Posselt
+@copyright 2012 Bernhard Posselt nukeawhale@gmail.com
+
+This library is free software; you can redistribute it and/or
+modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
+License as published by the Free Software Foundation; either
+version 3 of the License, or any later version.
+
+This library is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU AFFERO GENERAL PUBLIC LICENSE for more details.
+
+You should have received a copy of the GNU Affero General Public
+License along with this library.  If not, see <http://www.gnu.org/licenses/>.
+
+###
+
+
+describe '_ItemBl', ->
+
+
+	beforeEach module 'News'
+
+	beforeEach inject (@ItemModel, @_ItemBl, @StatusFlag) =>
+		@persistence =
+			getItems: ->
+
+		@bl = new _ItemBl(@ItemModel, @persistence)
+
+
+	it 'should mark all items read of a feed', =>
+		@persistence.setFeedRead = jasmine.createSpy('setFeedRead')
+		item1 = {id: 6, feedId: 5, guidHash: 'a1', status: @StatusFlag.UNREAD}
+		item2 = {id: 3, feedId: 5, guidHash: 'a2', status: @StatusFlag.UNREAD}
+		item3 = {id: 2, feedId: 5, guidHash: 'a3', status: @StatusFlag.UNREAD}
+		@ItemModel.add(item1)
+		@ItemModel.add(item2)
+		@ItemModel.add(item3)
+		@bl.markAllRead(5)
+
+		expect(@persistence.setFeedRead).toHaveBeenCalledWith(5, 6)
+		expect(item1.isRead()).toBe(true)
+		expect(item2.isRead()).toBe(true)
+		expect(item3.isRead()).toBe(true)
\ No newline at end of file
diff --git a/js/tests/services/models/itemmodelSpec.coffee b/js/tests/services/models/itemmodelSpec.coffee
index 364c07b80..a163632eb 100644
--- a/js/tests/services/models/itemmodelSpec.coffee
+++ b/js/tests/services/models/itemmodelSpec.coffee
@@ -26,6 +26,7 @@ describe '_ItemModel', ->
 	beforeEach module 'News'
 
 	beforeEach inject (@_ItemModel, @_Model) =>
+		@model = new @_ItemModel()
 
 
 	it 'should extend model', =>
@@ -33,39 +34,76 @@ describe '_ItemModel', ->
 
 
 	it 'should also update items with the same feed id and guidhash', =>
-		model = new @_ItemModel()
 		item1 = {id: 4, guidHash: 'abc', feedId: 3}
-		model.add(item1)
+		@model.add(item1)
 
-		expect(model.getById(4)).toBe(item1)
+		expect(@model.getById(4)).toBe(item1)
 
 		# normal id update
 		item2 = {id: 4, guidHash: 'abc', feedId: 4}
-		model.add(item2)
-		expect(model.size()).toBe(1)
+		@model.add(item2)
+		expect(@model.size()).toBe(1)
 
 		# new feeds should be added normally if different
 		item3 = {id: 5, guidHash: 'abc', feedId: 6}
-		model.add(item3)
-		expect(model.size()).toBe(2)
+		@model.add(item3)
+		expect(@model.size()).toBe(2)
 
 		# feed should be updated when guidhash and feedid the same
 		item4 = {id: 3, guidHash: 'abc', feedId: 6}
-		model.add(item4)
-		expect(model.getById(3).guidHash).toBe(item4.guidHash)
-		expect(model.getById(3).feedId).toBe(item4.feedId)
-		expect(model.getById(3).id).toBe(item4.id)
-		expect(model.getById(5)).toBe(undefined)
-		expect(model.size()).toBe(2)
+		@model.add(item4)
+		expect(@model.getById(3).guidHash).toBe(item4.guidHash)
+		expect(@model.getById(3).feedId).toBe(item4.feedId)
+		expect(@model.getById(3).id).toBe(item4.id)
+		expect(@model.getById(5)).toBe(undefined)
+		expect(@model.size()).toBe(2)
 
 
 	it 'should also remove the feed from the urlHash cache when its removed', =>
-		model = new @_ItemModel()
+		@model = new @_ItemModel()
 		item = {id: 4, guidHash: 'abc', feedId: 3}
-		model.add(item)
+		@model.add(item)
 
-		expect(model.getById(4)).toBe(item)
-		expect(model.getByGuidHashAndFeedId('abc', 3)).toBe(item)
+		expect(@model.getById(4)).toBe(item)
+		expect(@model.getByGuidHashAndFeedId('abc', 3)).toBe(item)
 
-		model.removeById(4)
-		expect(model.getByGuidHashAndFeedId('abc', 3)).toBe(undefined)
\ No newline at end of file
+		@model.removeById(4)
+		expect(@model.getByGuidHashAndFeedId('abc', 3)).toBe(undefined)
+
+
+	it 'should bind the correct isRead() method to the item', =>
+		item = {id: 3, guidHash: 'abc', feedId: 6, status: 16}
+
+		@model.add(item)
+		item.setRead()
+
+		expect(@model.getById(3).isRead()).toBe(true)
+
+
+	it 'should bind the correct set unread method to the item', =>
+		item = {id: 3, guidHash: 'abc', feedId: 6, status: 16}
+
+		@model.add(item)
+		item.setUnread()
+
+		expect(@model.getById(3).isRead()).toBe(false)
+
+
+	it 'should bind the correct set starred method to the item', =>
+		item = {id: 3, guidHash: 'abc', feedId: 6, status: 16}
+
+		@model.add(item)
+		item.setStarred()
+
+		expect(@model.getById(3).isStarred()).toBe(true)
+
+
+	it 'should bind the correct set unstarred method to the item', =>
+		item = {id: 3, guidHash: 'abc', feedId: 6, status: 16}
+
+		@model.add(item)
+		item.setUnstarred()
+
+		expect(@model.getById(3).isStarred()).toBe(false)
+
+	
\ No newline at end of file
diff --git a/js/tests/services/statusflagSpec.coffee b/js/tests/services/statusflagSpec.coffee
new file mode 100644
index 000000000..6b9ac19f2
--- /dev/null
+++ b/js/tests/services/statusflagSpec.coffee
@@ -0,0 +1,36 @@
+###
+
+ownCloud - News
+
+@author Bernhard Posselt
+@copyright 2012 Bernhard Posselt nukeawhale@gmail.com
+
+This library is free software; you can redistribute it and/or
+modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
+License as published by the Free Software Foundation; either
+version 3 of the License, or any later version.
+
+This library is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU AFFERO GENERAL PUBLIC LICENSE for more details.
+
+You should have received a copy of the GNU Affero General Public
+License along with this library.  If not, see <http://www.gnu.org/licenses/>.
+
+###
+
+
+describe 'StatusFlag', ->
+
+
+	beforeEach module 'News'
+
+	beforeEach inject (@StatusFlag) =>
+
+
+	it 'should have the correct status flags', =>
+		expect(@StatusFlag.UNREAD).toBe(0x02)
+		expect(@StatusFlag.STARRED).toBe(0x04)
+		expect(@StatusFlag.DELETED).toBe(0x08)
+		expect(@StatusFlag.UPDATED).toBe(0x16)
\ No newline at end of file