diff options
author | Bernhard Posselt <dev@bernhard-posselt.com> | 2014-05-12 22:45:24 +0200 |
---|---|---|
committer | Bernhard Posselt <dev@bernhard-posselt.com> | 2014-05-12 22:45:24 +0200 |
commit | 1fbe0ea4cf1abcd98bcaae5750e372c244e08aeb (patch) | |
tree | 95022bda57fe750c57b9aa79989692536f2f76d1 | |
parent | 04d7d834f3192ea5b652f59a01bc80ac1ae961f0 (diff) |
more style fixes
-rw-r--r-- | articleenhancer/xpatharticleenhancer.php | 1 | ||||
-rw-r--r-- | db/mapperfactory.php | 1 | ||||
-rw-r--r-- | tests/unit/businesslayer/BusinessLayerTest.php | 2 | ||||
-rw-r--r-- | tests/unit/businesslayer/ItemBusinessLayerTest.php | 3 | ||||
-rw-r--r-- | tests/unit/db/ItemMapperTest.php | 2 | ||||
-rw-r--r-- | tests/unit/db/postgres/ItemMapperTest.php | 2 | ||||
-rw-r--r-- | utility/controllertestutility.php | 2 |
7 files changed, 7 insertions, 6 deletions
diff --git a/articleenhancer/xpatharticleenhancer.php b/articleenhancer/xpatharticleenhancer.php index 466621466..b0614065f 100644 --- a/articleenhancer/xpatharticleenhancer.php +++ b/articleenhancer/xpatharticleenhancer.php @@ -25,6 +25,7 @@ class XPathArticleEnhancer implements ArticleEnhancer { private $fileFactory; private $maximumTimeout; private $config; + private $regexXPathPair; /** diff --git a/db/mapperfactory.php b/db/mapperfactory.php index ff14042d0..4597714d7 100644 --- a/db/mapperfactory.php +++ b/db/mapperfactory.php @@ -21,6 +21,7 @@ use \OCA\News\Core\Db; class MapperFactory { private $dbType; + private $db; public function __construct($dbType, Db $db) { $this->dbType = $dbType; diff --git a/tests/unit/businesslayer/BusinessLayerTest.php b/tests/unit/businesslayer/BusinessLayerTest.php index e55badcf2..e6695f47f 100644 --- a/tests/unit/businesslayer/BusinessLayerTest.php +++ b/tests/unit/businesslayer/BusinessLayerTest.php @@ -54,7 +54,7 @@ class BusinessLayerTest extends \PHPUnit_Framework_TestCase { ->with($this->equalTo($id), $this->equalTo($user)) ->will($this->returnValue($folder)); - $result = $this->newsBusinessLayer->delete($id, $user); + $this->newsBusinessLayer->delete($id, $user); } diff --git a/tests/unit/businesslayer/ItemBusinessLayerTest.php b/tests/unit/businesslayer/ItemBusinessLayerTest.php index 7ad3dc16e..96faee440 100644 --- a/tests/unit/businesslayer/ItemBusinessLayerTest.php +++ b/tests/unit/businesslayer/ItemBusinessLayerTest.php @@ -296,8 +296,7 @@ class ItemBusinessLayerTest extends \PHPUnit_Framework_TestCase { ->method('deleteReadOlderThanThreshold') ->with($this->equalTo($this->threshold)); - $result = $this->itemBusinessLayer->autoPurgeOld(); - + $this->itemBusinessLayer->autoPurgeOld(); } diff --git a/tests/unit/db/ItemMapperTest.php b/tests/unit/db/ItemMapperTest.php index 35b371526..bddf8cd28 100644 --- a/tests/unit/db/ItemMapperTest.php +++ b/tests/unit/db/ItemMapperTest.php @@ -359,7 +359,7 @@ class ItemMapperTest extends \OCA\News\Utility\MapperTestUtility { $this->setMapperResult($sql1, $params1, array($row)); $this->setMapperResult($sql2, $params2); - $result = $this->mapper->deleteReadOlderThanThreshold($threshold); + $this->mapper->deleteReadOlderThanThreshold($threshold); } diff --git a/tests/unit/db/postgres/ItemMapperTest.php b/tests/unit/db/postgres/ItemMapperTest.php index 796a59f5f..8677d8784 100644 --- a/tests/unit/db/postgres/ItemMapperTest.php +++ b/tests/unit/db/postgres/ItemMapperTest.php @@ -148,7 +148,7 @@ class ItemMapperTest extends \OCA\News\Utility\MapperTestUtility { $this->setMapperResult($sql1, $params1, array($row)); $this->setMapperResult($sql2, $params2); - $result = $this->mapper->deleteReadOlderThanThreshold($threshold); + $this->mapper->deleteReadOlderThanThreshold($threshold); } diff --git a/utility/controllertestutility.php b/utility/controllertestutility.php index a0b81a226..3898e09b1 100644 --- a/utility/controllertestutility.php +++ b/utility/controllertestutility.php @@ -58,7 +58,7 @@ abstract class ControllerTestUtility extends \PHPUnit_Framework_TestCase { * @param Response $response the response which we want to test for headers */ protected function assertHeaders(array $expected=array(), Response $response){ - $headers = $reponse->getHeaders(); + $headers = $response->getHeaders(); foreach($expected as $header){ $this->assertTrue(in_array($header, $headers)); } |