summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBernhard Posselt <dev@bernhard-posselt.com>2014-10-08 14:33:20 +0200
committerBernhard Posselt <dev@bernhard-posselt.com>2014-10-08 14:33:20 +0200
commitc20923f5ea9f500a41de2b3722f4b44fe3a45690 (patch)
treea3c9e62e1ce8130dfe190d2c35315eefc2671c61
parent1fccfbbf261a704cb1890e7f2afdb4e4ae29cadd (diff)
more cleanup
-rw-r--r--articleenhancer/xpatharticleenhancer.php3
-rw-r--r--tests/unit/articleenhancer/XPathArticleEnhancerTest.php5
-rw-r--r--tests/unit/utility/FaviconFetcherTest.php6
-rw-r--r--utility/faviconfetcher.php5
4 files changed, 6 insertions, 13 deletions
diff --git a/articleenhancer/xpatharticleenhancer.php b/articleenhancer/xpatharticleenhancer.php
index 8681051d2..ec3b61525 100644
--- a/articleenhancer/xpatharticleenhancer.php
+++ b/articleenhancer/xpatharticleenhancer.php
@@ -100,8 +100,7 @@ class XPathArticleEnhancer implements ArticleEnhancer {
private function getFile($url) {
return $this->fileFactory->getFile(
- $url, $this->maximumTimeout, 5, null, 'Mozilla/5.0 AppleWebKit',
- false, null, null, null
+ $url, $this->maximumTimeout, 5, null, 'Mozilla/5.0 AppleWebKit'
);
}
diff --git a/tests/unit/articleenhancer/XPathArticleEnhancerTest.php b/tests/unit/articleenhancer/XPathArticleEnhancerTest.php
index e7b3d19dd..8a99e9d5a 100644
--- a/tests/unit/articleenhancer/XPathArticleEnhancerTest.php
+++ b/tests/unit/articleenhancer/XPathArticleEnhancerTest.php
@@ -84,10 +84,7 @@ class XPathArticleEnhancerTest extends \PHPUnit_Framework_TestCase {
$this->equalTo($this->redirects),
$this->equalTo($this->headers),
$this->equalTo($this->userAgent),
- $this->equalTo(false),
- $this->equalTo(null),
- $this->equalTo(null),
- $this->equalTo(null))
+ $this->equalTo(false))
->will($this->returnValue($file));
$result = $this->testEnhancer->enhance($item);
diff --git a/tests/unit/utility/FaviconFetcherTest.php b/tests/unit/utility/FaviconFetcherTest.php
index a9c1416dc..3ed0d4dc8 100644
--- a/tests/unit/utility/FaviconFetcherTest.php
+++ b/tests/unit/utility/FaviconFetcherTest.php
@@ -89,11 +89,7 @@ class FaviconFetcherTest extends \PHPUnit_Framework_TestCase {
$this->equalTo(10),
$this->equalTo(5),
$this->equalTo(null),
- $this->equalTo(null),
- $this->equalTo(false),
- $this->equalTo(null),
- $this->equalTo(null),
- $this->equalTo(null))
+ $this->equalTo('Mozilla/5.0 AppleWebKit'))
->will($this->returnValue($pngMock));
$favicon = $this->fetcher->fetch($url);
diff --git a/utility/faviconfetcher.php b/utility/faviconfetcher.php
index 7ffdad9d7..cf7eed32e 100644
--- a/utility/faviconfetcher.php
+++ b/utility/faviconfetcher.php
@@ -100,8 +100,9 @@ class FaviconFetcher {
private function getFile($url) {
- return $this->apiFactory->getFile($url, 10, 5, null, null, false,
- null, null, null);
+ return $this->apiFactory->getFile(
+ $url, 10, 5, null, 'Mozilla/5.0 AppleWebKit'
+ );
}