diff options
| author | mormegil <mormegil@centrum.cz> | 2021-08-20 14:27:09 +0200 |
|---|---|---|
| committer | Sean Molenaar <SMillerDev@users.noreply.github.com> | 2021-08-23 17:44:41 +0200 |
| commit | 34c1f5c7a54342314d6e0426cb7b85153853bf6b (patch) | |
| tree | 389e18ca295b554d76cf2a5d78b7867ecfd9e9ec | |
| parent | 0432d30e7bfd676bae3479d152d2279b0290de39 (diff) | |
Fix favicon element making broken requests
The markup for favicon `<img>` element in feed item used `src` instead of
`ng-src`, causing browser to make broken requests for
`.../apps/news/%7B%7B%20::Content.getFeed(item.feedId).faviconLink%20%7D%7D`
Changing the attribute to `ng-src` fixed that.
Signed-off-by: mormegil <mormegil@centrum.cz>
| -rw-r--r-- | CHANGELOG.md | 1 | ||||
| -rw-r--r-- | templates/part.content.php | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 04d4708d8..162512170 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ The format is almost based on [Keep a Changelog](https://keepachangelog.com/en/1 ### Fixed - Set icon offset explicitly for navigation items +- Removed spurious requests for `.../apps/news/%7B%7B%20::Content.getFeed(item.feedId).faviconLink%20%7D%7D` (#1488) ## [15.x.x] ### Changed diff --git a/templates/part.content.php b/templates/part.content.php index 26329ad35..f0c80e27e 100644 --- a/templates/part.content.php +++ b/templates/part.content.php @@ -196,7 +196,7 @@ <span ng-if="!item.sharedBy" class="source"><?php p($l->t('from')) ?> <a ng-href="#/items/feeds/{{ ::item.feedId }}/"> {{ ::Content.getFeed(item.feedId).title }} - <img ng-if="Content.getFeed(item.feedId).faviconLink && !Content.isCompactView()" src="{{ ::Content.getFeed(item.feedId).faviconLink }}" alt="favicon"> + <img ng-if="Content.getFeed(item.feedId).faviconLink && !Content.isCompactView()" ng-src="{{ ::Content.getFeed(item.feedId).faviconLink }}" alt="favicon"> </a> </span> <span ng-if="item.sharedBy"> |