Add migration with foreign keys

Closes #829

Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>

33 files changed, 313 insertions, 357 deletions

diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml
index edab7e2fb..5843149e9 100644
--- a/.github/workflows/integration-tests.yml
+++ b/.github/workflows/integration-tests.yml
@@ -140,4 +140,4 @@ jobs:
         run: make integration-test
       - name: Feed tests
         working-directory: ../server/apps/news
-        run: make feed-test
\ No newline at end of file
+        run: make feed-test
diff --git a/AUTHORS.md b/AUTHORS.md
index 65abd3e7d..7cb56a2d8 100644
--- a/AUTHORS.md
+++ b/AUTHORS.md
@@ -5,8 +5,8 @@
 * [Robin Appelman](mailto:icewind@owncloud.com)
 * [Gregor Tätzner](mailto:gregor@freenet.de)
 * [Morris Jobke](mailto:hey@morrisjobke.de)
-* [Sean Molenaar](mailto:SMillerDev@users.noreply.github.com)
 * [Sean Molenaar](mailto:sean@seanmolenaar.eu)
+* [Sean Molenaar](mailto:SMillerDev@users.noreply.github.com)
 * [Jan-Christoph Borchardt](mailto:hey@jancborchardt.net)
 * [Daniel Schaal](mailto:daniel@schaal.email)
 * [Davide Saurino](mailto:davide.saurino@alcacoop.it)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0d0e607d3..75f2fdf9e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file.
 - Stop overloading DB ids
 - Unittest commands and utilities
 - Upload codecoverage to codecov.io
+- Use foreign keys in db
 
 ## 15.0.6
 
diff --git a/lib/Command/Config/FeedAdd.php b/lib/Command/Config/FeedAdd.php
index 3c4820437..86121ad06 100644
--- a/lib/Command/Config/FeedAdd.php
+++ b/lib/Command/Config/FeedAdd.php
@@ -2,6 +2,8 @@
 declare(strict_types=1);
 namespace OCA\News\Command\Config;
 
+use OCA\News\Service\Exceptions\ServiceConflictException;
+use OCA\News\Service\Exceptions\ServiceNotFoundException;
 use OCA\News\Service\FeedServiceV2;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
@@ -56,13 +58,31 @@ class FeedAdd extends Command
     {
         $user      = $input->getArgument('user-id');
         $url       = $input->getArgument('feed');
-        $folder    = (int) $input->getOption('folder') ?? 0;
+        $folder    = $input->getOption('folder');
         $title     = $input->getOption('title');
         $full_text = (bool) $input->getOption('full-text');
         $username  = $input->getOption('username');
         $password  = $input->getOption('password');
 
-        $feed = $this->feedService->create($user, $url, $folder, $full_text, $title, $username, $password);
+        if ($folder !== null) {
+            $folder = intval($folder);
+        }
+
+        try {
+            $feed = $this->feedService->create(
+                $user,
+                $url,
+                $folder,
+                $full_text,
+                $title,
+                $username,
+                $password
+            );
+        } catch (ServiceNotFoundException|ServiceConflictException $e) {
+            $output->write($e->getMessage());
+            return 1;
+        }
+
         $this->feedService->fetch($feed);
 
         $output->writeln(json_encode($feed->toAPI(), JSON_PRETTY_PRINT));
diff --git a/lib/Command/Config/FolderAdd.php b/lib/Command/Config/FolderAdd.php
index 257cf2dd6..03ad72535 100644
--- a/lib/Command/Config/FolderAdd.php
+++ b/lib/Command/Config/FolderAdd.php
@@ -47,9 +47,13 @@ class FolderAdd extends Command
      */
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $user = $input->getArgument('user-id');
-        $name = $input->getArgument('name');
-        $parent = (int) $input->getOption('parent') ?? 0;
+        $user   = $input->getArgument('user-id');
+        $name   = $input->getArgument('name');
+        $parent = $input->getOption('parent');
+
+        if ($parent !== null) {
+            $parent = intval($parent);
+        }
 
         $this->folderService->create($user, $name, $parent);
 
diff --git a/lib/Command/Config/FolderDelete.php b/lib/Command/Config/FolderDelete.php
index bf7608b02..397eda999 100644
--- a/lib/Command/Config/FolderDelete.php
+++ b/lib/Command/Config/FolderDelete.php
@@ -50,11 +50,11 @@ class FolderDelete extends Command
         $user = $input->getArgument('user-id');
         $id = $input->getArgument('folder-id');
 
-        if ($id === '0') {
+        if ($id === null) {
             throw new ServiceException('Can not remove root folder!');
         }
 
-        $this->folderService->delete($user, $id);
+        $this->folderService->delete($user, intval($id));
 
         return 0;
     }
diff --git a/lib/Controller/FeedApiController.php b/lib/Controller/FeedApiController.php
index cb3d5e645..2c96bbc6e 100644
--- a/lib/Controller/FeedApiController.php
+++ b/lib/Controller/FeedApiController.php
@@ -27,6 +27,7 @@ use \OCP\AppFramework\Http;
 use \OCA\News\Service\FeedService;
 use \OCA\News\Service\ItemService;
 use Psr\Log\LoggerInterface;
+use function GuzzleHttp\Psr7\uri_for;
 
 class FeedApiController extends ApiController
 {
@@ -99,13 +100,17 @@ class FeedApiController extends ApiController
      * @NoCSRFRequired
      * @CORS
      *
-     * @param string $url
-     * @param int    $folderId
+     * @param string   $url
+     * @param int|null $folderId
      *
      * @return array|mixed|JSONResponse
      */
-    public function create(string $url, int $folderId = 0)
+    public function create(string $url, ?int $folderId = null)
     {
+        if ($folderId === 0) {
+            $folderId = null;
+        }
+
         try {
             $this->feedService->purgeDeleted($this->getUserId(), false);
 
@@ -169,13 +174,17 @@ class FeedApiController extends ApiController
      * @NoCSRFRequired
      * @CORS
      *
-     * @param int $feedId
-     * @param int $folderId
+     * @param int      $feedId
+     * @param int|null $folderId
      *
      * @return array|JSONResponse
      */
-    public function move(int $feedId, int $folderId)
+    public function move(int $feedId, ?int $folderId)
     {
+        if ($folderId === 0) {
+            $folderId = null;
+        }
+
         try {
             $this->feedService->patch(
                 $feedId,
diff --git a/lib/Controller/FeedController.php b/lib/Controller/FeedController.php
index c09096bd9..78df7be0c 100644
--- a/lib/Controller/FeedController.php
+++ b/lib/Controller/FeedController.php
@@ -105,6 +105,9 @@ class FeedController extends Controller
         // check if feed or folder exists
         try {
             if ($feedType === FeedType::FOLDER) {
+                if ($feedId === 0) {
+                    $feedId = null;
+                }
                 $this->folderService->find($this->userId, $feedId);
             } elseif ($feedType === FeedType::FEED) {
                 $this->feedService->find($this->userId, $feedId);
@@ -131,20 +134,23 @@ class FeedController extends Controller
      * @NoAdminRequired
      *
      * @param string $url
-     * @param int    $parentFolderId
-     * @param string $title
-     * @param string $user
-     * @param string $password
+     * @param int|null    $parentFolderId
+     * @param string|null $title
+     * @param string|null $user
+     * @param string|null $password
      *
      * @return array|JSONResponse
      */
     public function create(
         string $url,
-        int $parentFolderId,
+        ?int $parentFolderId,
         ?string $title = null,
         ?string $user = null,
         ?string $password = null
     ) {
+        if ($parentFolderId === 0) {
+            $parentFolderId = null;
+        }
         try {
             // we need to purge deleted feeds if a feed is created to
             // prevent already exists exceptions
@@ -290,13 +296,13 @@ class FeedController extends Controller
     /**
      * @NoAdminRequired
      *
-     * @param int    $feedId
-     * @param bool   $pinned
-     * @param bool   $fullTextEnabled
-     * @param int    $updateMode
-     * @param int    $ordering
-     * @param int    $folderId
-     * @param string $title
+     * @param int         $feedId
+     * @param bool        $pinned
+     * @param bool        $fullTextEnabled
+     * @param int|null    $updateMode
+     * @param int|null    $ordering
+     * @param int|null    $folderId
+     * @param string|null $title
      *
      * @return array|JSONResponse
      */
@@ -315,7 +321,7 @@ class FeedController extends Controller
             'updateMode' => $updateMode,
             'ordering' => $ordering,
             'title' => $title,
-            'folderId' => $folderId
+            'folderId' => $folderId === 0 ? null : $folderId
         ];
 
         $diff = array_filter(
diff --git a/lib/Controller/FolderApiController.php b/lib/Controller/FolderApiController.php
index 1f79d7cf9..691c67139 100644
--- a/lib/Controller/FolderApiController.php
+++ b/lib/Controller/FolderApiController.php
@@ -90,12 +90,16 @@ class FolderApiController extends ApiController
      * @NoCSRFRequired
      * @CORS
      *
-     * @param int $folderId
+     * @param int|null $folderId
      *
      * @return array|JSONResponse
      */
-    public function delete(int $folderId)
+    public function delete(?int $folderId)
     {
+        if (empty($folderId)) {
+            return new JSONResponse([], Http::STATUS_BAD_REQUEST);
+        }
+
         try {
             $this->folderService->delete($folderId, $this->getUserId());
         } catch (ServiceNotFoundException $ex) {
@@ -111,13 +115,17 @@ class FolderApiController extends ApiController
      * @NoCSRFRequired
      * @CORS
      *
-     * @param int    $folderId
-     * @param string $name
+     * @param int|null $folderId
+     * @param string   $name
      *
      * @return array|JSONResponse
      */
-    public function update(int $folderId, string $name)
+    public function update(?int $folderId, string $name)
     {
+        if (empty($folderId)) {
+            return new JSONResponse([], Http::STATUS_BAD_REQUEST);
+        }
+
         try {
             $this->folderService->rename($folderId, $name, $this->getUserId());
         } catch (ServiceValidationException $ex) {
@@ -137,11 +145,14 @@ class FolderApiController extends ApiController
      * @NoCSRFRequired
      * @CORS
      *
-     * @param int $folderId
-     * @param int $newestItemId
+     * @param int|null $folderId
+     * @param int      $newestItemId
      */
-    public function read(int $folderId, int $newestItemId): void
+    public function read(?int $folderId, int $newestItemId): void
     {
+        if ($folderId === 0) {
+            $folderId = null;
+        }
         $this->itemService->readFolder($folderId, $newestItemId, $this->getUserId());
     }
 }
diff --git a/lib/Controller/FolderController.php b/lib/Controller/FolderController.php
index d19726963..09900f5b2 100644
--- a/lib/Controller/FolderController.php
+++ b/lib/Controller/FolderController.php
@@ -64,13 +64,15 @@ class FolderController extends Controller
     /**
      * @NoAdminRequired
      *
-     * @param int  $folderId
-     * @param bool $open
+     * @param int|null $folderId
+     * @param bool     $open
      *
      * @return array|JSONResponse
      */
-    public function open(int $folderId, bool $open)
+    public function open(?int $folderId, bool $open)
     {
+        $folderId = $folderId === 0 ? null : $folderId;
+
         try {
             $this->folderService->open($folderId, $open, $this->userId);
         } catch (ServiceException $ex) {
@@ -108,12 +110,15 @@ class FolderController extends Controller
     /**
      * @NoAdminRequired
      *
-     * @param int $folderId
+     * @param int|null $folderId
      *
      * @return array|JSONResponse
      */
-    public function delete(int $folderId)
+    public function delete(?int $folderId)
     {
+        if (empty($folderId)) {
+            return new JSONResponse([], Http::STATUS_BAD_REQUEST);
+        }
         try {
             $this->folderService->markDeleted($folderId, $this->userId);
         } catch (ServiceNotFoundException $ex) {
@@ -127,13 +132,16 @@ class FolderController extends Controller
     /**
      * @NoAdminRequired
      *
-     * @param string $folderName
-     * @param int    $folderId
+     * @param string   $folderName
+     * @param int|null $folderId
      *
      * @return array|JSONResponse
      */
-    public function rename(string $folderName, int $folderId)
+    public function rename(string $folderName, ?int $folderId)
     {
+        if (empty($folderId)) {
+            return new JSONResponse([], Http::STATUS_BAD_REQUEST);
+        }
         try {
             $folder = $this->folderService->rename(
                 $folderId,
@@ -154,12 +162,15 @@ class FolderController extends Controller
     /**
      * @NoAdminRequired
      *
-     * @param int $folderId
-     * @param int $highestItemId
+     * @param int|null $folderId
+     * @param int      $highestItemId
+     *
      * @return array
      */
-    public function read(int $folderId, int $highestItemId): array
+    public function read(?int $folderId, int $highestItemId): array
     {
+        $folderId = $folderId === 0 ? null : $folderId;
+
         $this->itemService->readFolder(
             $folderId,
             $highestItemId,
@@ -173,12 +184,14 @@ class FolderController extends Controller
     /**
      * @NoAdminRequired
      *
-     * @param int $folderId
+     * @param int|null $folderId
      *
      * @return array|JSONResponse
      */
-    public function restore(int $folderId)
+    public function restore(?int $folderId)
     {
+        $folderId = $folderId === 0 ? null : $folderId;
+
         try {
             $this->folderService->unmarkDeleted($folderId, $this->userId);
         } catch (ServiceNotFoundException $ex) {
diff --git a/lib/Controller/UserApiController.php b/lib/Controller/UserApiController.php
deleted file mode 100644
index b644ba1f0..000000000
--- a/lib/Controller/UserApiController.php
+++ /dev/null
@@ -1,74 +0,0 @@
-<?php
-/**
- * Nextcloud - News
- *
- * This file is licensed under the Affero General Public License version 3 or
- * later. See the COPYING file.
- *
- * @author    Alessandro Cosentino <cosenal@gmail.com>
- * @author    Bernhard Posselt <dev@bernhard-posselt.com>
- * @author    David Guillot <david@guillot.me>
- * @copyright 2012 Alessandro Cosentino
- * @copyright 2012-2014 Bernhard Posselt
- * @copyright 2018 David Guillot
- */
-
-namespace OCA\News\Controller;
-
-use \OCP\IRequest;
-use \OCP\IUserSession;
-use \OCP\IURLGenerator;
-use \OCP\Files\IRootFolder;
-use \OCP\AppFramework\Http;
-
-class UserApiController extends ApiController
-{
-
-    private $rootFolder;
-
-    public function __construct(
-        string $appName,
-        IRequest $request,
-        IUserSession $userSession,
-        IRootFolder $rootFolder
-    ) {
-        parent::__construct($appName, $request, $userSession);
-        $this->rootFolder = $rootFolder;
-    }
-
-    /**
-     * @NoAdminRequired
-     * @NoCSRFRequired
-     * @CORS
-     */
-    public function index(): array
-    {
-        $user = $this->getUser();
-
-        // find the avatar
-        $jpgAvatar = '/' . $user->getUID() . '/avatar.jpg';
-        $pngAvatar = '/' . $user->getUID() . '/avatar.png';
-        $avatar = null;
-
-        if ($this->rootFolder->nodeExists($jpgAvatar)) {
-            $file = $this->rootFolder->get($jpgAvatar);
-            $avatar = [
-                'data' => base64_encode($file->getContent()),
-                'mime' =>  'image/jpeg'
-            ];
-        } elseif ($this->rootFolder->nodeExists($pngAvatar)) {
-            $file = $this->rootFolder->get($pngAvatar);
-            $avatar = [
-                'data' => base64_encode($file->getContent()),
-                'mime' =>  'image/png'
-            ];
-        }
-
-        return [
-            'userId' => $user->getUID(),
-            'displayName' => $user->getDisplayName(),
-            'lastLoginTimestamp' => $user->getLastLogin(),
-            'avatar' => $avatar
-        ];
-    }
-}
diff --git a/lib/Db/Feed.php b/lib/Db/Feed.php
index 852de4c78..473912acc 100644
--- a/lib/Db/Feed.php
+++ b/lib/Db/Feed.php
@@ -37,7 +37,7 @@