Contact deletion fix and warning if fetchFull fails and/of contact gone

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

1 files changed, 7 insertions, 3 deletions

diff --git a/src/models/contact.js b/src/models/contact.js
index de1ba9a7..3836d91d 100644
--- a/src/models/contact.js
+++ b/src/models/contact.js
@@ -30,11 +30,15 @@ export default class Contact {
 	 *
 	 * @param {string} vcard the vcard data as string with proper new lines
 	 * @param {object} addressbook the addressbook which the contat belongs to
-	 * @param {string} [url] the url of the contact
-	 * @param {string} [etag] the current etag of the contact
+	 * @param {string} [url=''] the url of the contact
+	 * @param {string} [etag=''] the current etag of the contact
 	 * @memberof Contact
 	 */
-	constructor(vcard = '', addressbook, url = '', etag = '') {
+	constructor(vcard, addressbook, url = '', etag = '') {
+		if (typeof vcard !== 'string' || vcard.length === 0) {
+			throw new Error('Invalid vCard')
+		}
+
 		let jCal = ICAL.parse(vcard)
 		if (jCal[0] !== 'vcard') {
 			throw new Error('Only one contact is allowed in the vcard data')