From a1b6a7f5328974aaddd7f631135c58e1d620c820 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pawe=C5=82=20Krupa?= <pawel@krupa.net.pl>
Date: Sat, 29 Sep 2018 01:09:34 +0200
Subject: [cleanup crusade] Shellcheck (#4261)

* lint libreswan module

* disable linting obsolete shell modules

* shellcheck more shell modules

* fix review; lint helper scripts

* more shellcheck

* fix SC2235 in apache.chart.sh

* shellcheck last portion of charts.d scripts

* final shellcheck; make travis blocking

* fix cppcheck

* fix indents; fix expansion

* fix local var assignments
---
 .travis/containerized_build.sh | 2 +-
 .travis/create_artifacts.sh    | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

(limited to '.travis')

diff --git a/.travis/containerized_build.sh b/.travis/containerized_build.sh
index 8beb36d6c6..314a2ec392 100755
--- a/.travis/containerized_build.sh
+++ b/.travis/containerized_build.sh
@@ -2,6 +2,6 @@
 
 set -e
 
-docker build -t dev-image -f .travis/images/Dockerfile.$1 .
+docker build -t dev-image -f ".travis/images/Dockerfile.$1" .
 
 docker run -it -w /code dev-image ./netdata-installer.sh --dont-wait --dont-start-it --install /tmp
diff --git a/.travis/create_artifacts.sh b/.travis/create_artifacts.sh
index dacc67825d..1c1f909329 100755
--- a/.travis/create_artifacts.sh
+++ b/.travis/create_artifacts.sh
@@ -1,8 +1,9 @@
 #!/bin/bash
+# shellcheck disable=SC2230
 
 if [ ! -f .gitignore ]
 then
-  echo "Run as ./travis/$(basename $0) from top level directory of git repository"
+  echo "Run as ./travis/$(basename "$0") from top level directory of git repository"
   exit 1
 fi
 
@@ -19,6 +20,6 @@ fakeroot ./packaging/git-build
 python -c 'import os,sys,fcntl; flags = fcntl.fcntl(sys.stdout, fcntl.F_GETFL); fcntl.fcntl(sys.stdout, fcntl.F_SETFL, flags&~os.O_NONBLOCK);'
 # make self-extractor
 ./makeself/build-x86_64-static.sh
-for i in *.tar.gz; do sha512sum -b $i > $i.sha; done
-for i in *.gz.run; do sha512sum -b $i > $i.sha; done
+for i in *.tar.gz; do sha512sum -b "$i" > "$i.sha"; done
+for i in *.gz.run; do sha512sum -b "$i" > "$i.sha"; done
 ./.travis/deploy-if-have-key
-- 
cgit v1.2.3