Age | Commit message (Collapse) | Author |
|
* added WIP ssl certificate expiry time check plugin
* fixing bugs
* more bugfixes
* cleaned up
* fixed graphing
* More pretty readme
* cleaned up style
* change author
* simplify
* add days_until_expiration_warn and correctly calc seconds
* update config
* config update
* readme update
* return false from check if module failed to collect data
* set default update_every to 60
* add alarm
* add sslcheck to makefile
* fix indentation
* add crit to alarm
* update conf
* update readme
* add days_until_expiration_critical
* change default days_until_expiration_warning to 14
* minor
|
|
<!--
Describe the change in summary section, including rationale and degin decisions.
Include "Fixes #nnn" if you are fixing an existing issue.
In "Component Name" section write which component is changed in this PR. This
will help us review your PR quicker.
If you have more information you want to add, write them in "Additional
Information" section. This is usually used to help others understand your
motivation behind this change. A step-by-step reproduction of the problem is
helpful if there is no related issue.
-->
##### Summary
Fix postgres connection, port value was incorrect, it was taking host value instead of port.
##### Component Name
[collectors/python.d.plugin/postgres](https://github.com/netdata/netdata/tree/master/collectors/python.d.plugin/postgres)
##### Additional Information
|
|
* connect fix
* connect fix
* minor
* minor
|
|
|
|
|
|
<!--
Describe the change in summary section, including rationale and degin decisions.
Include "Fixes #nnn" if you are fixing an existing issue.
In "Component Name" section write which component is changed in this PR. This
will help us review your PR quicker.
If you have more information you want to add, write them in "Additional
Information" section. This is usually used to help others understand your
motivation behind this change. A step-by-step reproduction of the problem is
helpful if there is no related issue.
-->
##### Summary
Fixes: #5608
Add ssl connection support to MySQLService
> python-mysqlclient connection
```
:param dict ssl:
dictionary or mapping contains SSL connection parameters;
see the MySQL documentation for more details
(mysql_ssl_set()). If this is set, and the client does not
support SSL, NotSupportedError will be raised.
```
[SSL connection parameters:](https://dev.mysql.com/doc/refman/5.6/en/mysql-ssl-set.html)
- **key**: The path name of the client private key file.
- **cert**: The path name of the client public key certificate file.
- **ca**: The path name of the Certificate Authority (CA) certificate file. This option, if used, must specify the same certificate used by the server.
- **capath**: The path name of the directory that contains trusted SSL CA certificate files.
- **cipher**: The list of permitted ciphers for SSL encryption.
##### Component Name
[`collectors/python.d.plugin/python_modules/bases/FrameworkServices/MySQLService`](https://github.com/netdata/netdata/blob/master/collectors/python.d.plugin/python_modules/bases/FrameworkServices/MySQLService.py)
___
@woosley please test it
```yaml
tcp:
name : 'local'
user : 'user'
pass : 'pass'
host : 'localhost'
port : '3306'
ssl:
key: 'path/to/key'
cert: 'path/to/cet'
ca: 'path/to/ca'
```
|
|
|
|
Add link to the template `dashboard.html`.
Minor corrections.
Related to the recent comment in #2339
|
|
<!--
Describe the change in summary section, including rationale and degin decisions.
Include "Fixes #nnn" if you are fixing an existing issue.
In "Component Name" section write which component is changed in this PR. This
will help us review your PR quicker.
If you have more information you want to add, write them in "Additional
Information" section. This is usually used to help others understand your
motivation behind this change. A step-by-step reproduction of the problem is
helpful if there is no related issue.
-->
##### Summary
python loaders module cleanup
- move `load_module` to `python.d.plugin`
- use `load_config` in unbound module instead of YamlOrderedLoad class
- remove all classes from `loaders.py` - no longer used
##### Component Name
[`collectors/python.d.plugin/python_modules/bases/loaders`](https://github.com/netdata/netdata/blob/master/collectors/python.d.plugin/python_modules/bases/loaders.py)
##### Additional Information
|
|
|
|
<!--
Describe the change in summary section, including rationale and degin decisions.
Include "Fixes #nnn" if you are fixing an existing issue.
In "Component Name" section write which component is changed in this PR. This
will help us review your PR quicker.
If you have more information you want to add, write them in "Additional
Information" section. This is usually used to help others understand your
motivation behind this change. A step-by-step reproduction of the problem is
helpful if there is no related issue.
-->
##### Summary
Fix [UnicodeDecodeError](https://github.com/netdata/netdata/pull/5507#issuecomment-471344661)
##### Component Name
[`collectors/python.d.plugin/spigotmc`](https://github.com/netdata/netdata/tree/master/collectors/python.d.plugin/spigotmc)
##### Additional Information
|
|
* py2 compatibility fix: do not use re.A (re.ASCII)
* debug and minor changes
* more debug output and check fix
|
|
|
|
<!--
Describe the change in summary section, including rationale and degin decisions.
Include "Fixes #nnn" if you are fixing an existing issue.
In "Component Name" section write which component is changed in this PR. This
will help us review your PR quicker.
If you have more information you want to add, write them in "Additional
Information" section. This is usually used to help others understand your
motivation behind this change. A step-by-step reproduction of the problem is
helpful if there is no related issue.
-->
##### Summary
python SimpleService cleanup 1 - remove OldVersionCompatibility
##### Component Name
[`collectors/python.d.plugin/python_modules/bases/FrameworkServices/SimpleService`](collectors/python.d.plugin/python_modules/bases/FrameworkServices)
##### Additional Information
it is dead code, no longer supported
|
|
|
|
Fixes #5512
* Delay cgroup renaming
* Restrict renaming delay to problematic containers only
* Use pending_renames instead of needs_renaming
* Use an exit code instead of a parameter
|
|
|
|
|
|
|
|
|
|
* Pass additional details to be used in the authorization form.
* Fix incorrect marking of streaming master #5560
|
|
##### Summary
This PR adds (major) changes only to `python.d.plugin` file.
Fixes: #5525
`pyhton.d.plugin` imports a lot of additional packages during initial module initialization/job creating/checking and there is no way to unimport them, even if they arn't needed. It consumes relatively a lot of ram.
___
Memory utilization comparing before/after the PR (one job `example` module, py3.7.2):
> 21.1 => 8.8 MiB
![screenshot_20190305_111837](https://user-images.githubusercontent.com/22274335/53791147-c27a6e00-3f39-11e9-8eaf-8ac3809a3b6e.png)
##### Component Name
[`collectors/python.d.plugin`](https://github.com/netdata/netdata/blob/master/collectors/python.d.plugin/python.d.plugin.in)
##### Additional Information
This PR adds separate process for initial module checking.
Logic:
- main process spawns checker process
- checker process loads every module, loads module config, creates jobs and runs job.check() for every job, if check success it adds the job to the list.
- checker process returns list of modules and jobs.
- main process loads only active modules, etc.
|
|
|
|
|
|
|
|
This makes the parsing a bit more robust at the cost of some
performance.
Additionally, this relaxes the parsing logic surrounding the handling of
the user counts to just grab the first integer after the timestamp and
treat it as the count of users.
Fixes: #4131
|
|
|
|
Will allow for better UX and alternative authorization methods.
|
|
* Daemon minor cleanups:
1) pull in plugin directories logic, inside the pluginsd where it belongs and call a method from the daemon to do so,
2) Magic numbers are evil, give a meaningful definition for that plugin directories retrieval
* Rename netdata_configured_plugins_dir -> netdata_configured_primary_plugins_dir. We allow multiple plugin directories and this is actually the primary (or stock?) directory, just make it clear to avoid confusion
* In this new wrapper, just return whatever the string splitter would return
* Reduce the scope - consider moving this to somewhere else in a common place if needed by other modules later
|
|
|
|
* Add news for 1.12.1 and 1.12.2 to main readme
* Update README.md
Co-Authored-By: cakrit <43294513+cakrit@users.noreply.github.com>
|
|
|
|
* Support older prometheus metric unit naming and allow removal of units from metrics
* Update swagger
* Added bats tests, improved efficiency of checking units
|
|
* Correct go.d.plugin sha256sum check
* Put the dollar in the right place
|
|
|
|
* Remove check on whether a server delete request comes from the same server we are looking at
|
|
|
|
netdata instances (#5511)
* Do a GUID comparison between slave and receiver to avoid conflicts in processing when the GUID is mistakenly set same on both
We found this issue while creating a container, set it up with netdata and then clone it to get another one up and running with the same setup.
We need this check to prevent data conflicts as the GUID is considered to be unique across the universe.
TODO: I dont have enough visibility over the rates that this string comparison will be executed, we might need to reconsider another faster approach to compare the GUIDs
* Dont forget to cleanup resources properly upon early exit
* Remove mysterious string compare, fix indentation in other part of the code
|
|
|
|
|
|
|
|
[netdata patch release]
|
|
[netdata patch release]
|
|
[patch]
|
|
* Show streamed servers even for users that are not signed in! #5482
* Better placement of sign-in prompt #5482
|
|
<!--
Describe the change in summary section, including rationale and degin decisions.
Include "Fixes #nnn" if you are fixing an existing issue.
In "Component Name" section write which component is changed in this PR. This
will help us review your PR quicker.
If you have more information you want to add, write them in "Additional
Information" section. This is usually used to help others understand your
motivation behind this change. A step-by-step reproduction of the problem is
helpful if there is no related issue.
-->
##### Summary
Fixes: #1996
##### Component Name
python.d.plugin oracledb module
##### Additional Information
#### Used queries:
- [system metrics]:
```sql
SELECT
metric_name,
value
FROM
gv$sysmetric
ORDER BY
begin_time
```
<details><summary>collected metrics</summary>
<p>
| name|
|---|
| average_active_sessions |
| session_count |
| session_limit_percent |
| logons_per_sec |
| physical_reads_per_sec |
| physical_writes_per_sec |
| disk_sort_per_sec |
| long_table_scans_per_sec |
| database_wait_time_ratio |
| shared_pool_free_percent |
| memory_sorts_ratio |
| sql_service_response_time |
| user_rollbacks_per_sec |
| enqueue_timeouts_per_sec |
| buffer_cache_hit_ratio |
| cursor_cache_hit_ratio |
| library_cache_hit_ratio |
| row_cache_hit_ratio |
| global_cache_blocks_corrupted |
| global_cache_blocks_lost |
</p>
</details>
</br>
- [tablespace]
```sql
SELECT
m.tablespace_name,
m.used_space * t.block_size AS used_bytes,
m.tablespace_size * t.block_size AS max_bytes,
m.used_percent
FROM
dba_tablespace_usage_metrics m
JOIN dba_tablespaces t ON m.tablespace_name = t.tablespace_name
```
<details><summary>collected metrics</summary>
<p>
| name|
|---|
| tablespace_size |
| tablespace_used |
| tablespace_used_in_percent |
</p>
</details>
</br>
- [activities count]
```sql
SELECT
name,
value
FROM
v$sysstat
WHERE
name IN (
'parse count (total)',
'execute count',
'user commits',
'user rollbacks'
)
```
<details><summary>collected metrics</summary>
<p>
| name|
|---|
| activity_parse_count |
| activity_execute_count |
| activity_user_commits |
| activity_user_rollbacks |
</p>
</details>
</br>
- wait time
```sql
SELECT
n.wait_class,
round(m.time_waited / m.INTSIZE_CSEC, 3)
FROM
v$waitclassmetric m,
v$system_wait_class n
WHERE
m.wait_class_id = n.wait_class_id
AND n.wait_class != 'Idle'
```
|
|
|
|
|
|
|
|
|