diff options
| author | vkalintiris <vasilis@netdata.cloud> | 2022-11-22 04:52:15 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-22 04:52:15 +0200 |
| commit | 2d5f3acf71f0c759056a3269987fee484566bc4c (patch) | |
| tree | 5246e1080ea721ba84e5f749f8d8e98d978d81c8 /registry | |
| parent | 147552807bc19af949fe3cb315c4743dadfa7f0b (diff) | |
Do not force internal collectors to call rrdset_next. (#13926)
* Remove calls to rrdset_next().
* Rm checks plugin
* Update documentantion
* Call rrdset_next from within rrdset_done
This wraps up the removal of rrdset_next from internal collectors, which
removes a lot of unecessary code and the need for if/else clauses in
every place.
The pluginsd parser is the only component that calls rrdset_next*()
functions because it's not strictly speaking a collector but more of a
collector manager/proxy.
With the current changes it's possible to simplify the API we expose
from RRD significantly, but this will be follow-up work in the future.
* Remove stale reference to checks.plugin
* Fix RRD unit test
rrdset_next is not meant to be called from these tests.
* Fix db engine unit test.
* Schedule rrdset_next when we have completed at least one collection.
* Mark chart creation clauses as unlikely.
* Add missing brace to fix FreeBSD plugin.
Diffstat (limited to 'registry')
| -rw-r--r-- | registry/registry.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/registry/registry.c b/registry/registry.c index d596113700..e6c2172b04 100644 --- a/registry/registry.c +++ b/registry/registry.c @@ -379,7 +379,6 @@ void registry_statistics(void) { rrddim_add(sts, "sessions", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE); } - else rrdset_next(sts); rrddim_set(sts, "sessions", registry.usages_count); rrdset_done(sts); @@ -408,7 +407,6 @@ void registry_statistics(void) { rrddim_add(stc, "persons_urls", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE); rrddim_add(stc, "machines_urls", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE); } - else rrdset_next(stc); rrddim_set(stc, "persons", registry.persons_count); rrddim_set(stc, "machines", registry.machines_count); @@ -441,7 +439,6 @@ void registry_statistics(void) { rrddim_add(stm, "persons_urls", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE); rrddim_add(stm, "machines_urls", NULL, 1, 1024, RRD_ALGORITHM_ABSOLUTE); } - else rrdset_next(stm); rrddim_set(stm, "persons", registry.persons_memory + dictionary_stats_for_registry(registry.persons)); rrddim_set(stm, "machines", registry.machines_memory + dictionary_stats_for_registry(registry.machines)); |