diff options
| author | Austin S. Hemmelgarn <austin@netdata.cloud> | 2019-12-13 07:37:30 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-12-13 07:37:30 -0500 |
| commit | 757ce94f16260ef0054a31770939f20894967519 (patch) | |
| tree | 0bcb15ad2791cfeeaf0d1f75f0560224d31b2f81 /packaging | |
| parent | 2412ad1f45d4ecb18acc9b0a4650cb772add761b (diff) | |
Remove `-f` option from `groupdel` in uninstaller. (#7507)
The `-f` option forces removal of a group even if it is the primary
group for a user. We should not be using this option for three ons:
* It's not universally supported. Gentoo, for example, does not ide a
version of `groupdel` with this option.
* We shouldn't need it. Short of unusual user configurations, the
`netdata` user should be the only one who has a primary group of
`netdata`, and we remove the `netdata` user before trying to remove
`netdata` group.
* In the unlikely event that the above point is not the case on a given
system, removing the `netdata` group will actually break things.
Fixes: #6348
Diffstat (limited to 'packaging')
| -rwxr-xr-x | packaging/installer/netdata-uninstaller.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/packaging/installer/netdata-uninstaller.sh b/packaging/installer/netdata-uninstaller.sh index 7949b4fd1c..424367b595 100755 --- a/packaging/installer/netdata-uninstaller.sh +++ b/packaging/installer/netdata-uninstaller.sh @@ -159,7 +159,7 @@ portable_del_group() { # Linux if command -v groupdel 1>/dev/null 2>&1; then if grep -q "${groupname}" /etc/group; then - run groupdel -f "${groupname}" && return 0 + run groupdel "${groupname}" && return 0 else echo >&2 "Group ${groupname} already removed in a previous step." run_ok |