diff options
| author | vkalintiris <vasilis@netdata.cloud> | 2024-05-31 15:47:53 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-31 08:47:53 -0400 |
| commit | b7ec9126c9a553983daebb249bb21818fd6e7430 (patch) | |
| tree | 9014527f28df550fe74fa2f42cea20e581f42c89 /packaging | |
| parent | 0a2459f208f545076287e5710838265539537cb4 (diff) | |
Use semver releases with sentry. (#17746)
Semver does not have the concept of a tweak
field. To address this, we just drop the major
field which has not changed in ages. We can
simply ignore/drop old sentry releases if/when
we perform any major releases.
Diffstat (limited to 'packaging')
| -rwxr-xr-x | packaging/build-package.sh | 4 | ||||
| -rw-r--r-- | packaging/cmake/Modules/NetdataSentry.cmake | 4 | ||||
| -rw-r--r-- | packaging/cmake/config.cmake.h.in | 1 |
3 files changed, 0 insertions, 9 deletions
diff --git a/packaging/build-package.sh b/packaging/build-package.sh index bdf4f4eda0..ea50f4438c 100755 --- a/packaging/build-package.sh +++ b/packaging/build-package.sh @@ -84,10 +84,6 @@ if [ "${ENABLE_SENTRY}" = "true" ]; then add_cmake_option NETDATA_SENTRY_ENVIRONMENT "${RELEASE_PIPELINE:-Unknown}" add_cmake_option NETDATA_SENTRY_DIST "${BUILD_DESTINATION:-Unknown}" add_cmake_option NETDATA_SENTRY_DSN "${SENTRY_DSN}" - - if [ -n "${VERSION}" ]; then - add_cmake_option NETDATA_SENTRY_RELEASE "${VERSION}" - fi else add_cmake_option ENABLE_SENTRY Off fi diff --git a/packaging/cmake/Modules/NetdataSentry.cmake b/packaging/cmake/Modules/NetdataSentry.cmake index 478c77498c..b20aeedd5f 100644 --- a/packaging/cmake/Modules/NetdataSentry.cmake +++ b/packaging/cmake/Modules/NetdataSentry.cmake @@ -20,10 +20,6 @@ function(netdata_bundle_sentry) set(SENTRY_BACKEND "breakpad") set(SENTRY_BUILD_SHARED_LIBS OFF) - if(NOT DEFINED NETDATA_SENTRY_RELEASE) - set(NETDATA_SENTRY_RELEASE "${CPACK_PACKAGE_VERSION}") - endif() - FetchContent_Declare( sentry GIT_REPOSITORY https://github.com/getsentry/sentry-native.git diff --git a/packaging/cmake/config.cmake.h.in b/packaging/cmake/config.cmake.h.in index 5494782a5a..57d032693b 100644 --- a/packaging/cmake/config.cmake.h.in +++ b/packaging/cmake/config.cmake.h.in @@ -136,7 +136,6 @@ #cmakedefine ENABLE_SENTRY #cmakedefine NETDATA_SENTRY_ENVIRONMENT "@NETDATA_SENTRY_ENVIRONMENT@" -#cmakedefine NETDATA_SENTRY_RELEASE "@NETDATA_SENTRY_RELEASE@" #cmakedefine NETDATA_SENTRY_DIST "@NETDATA_SENTRY_DIST@" #cmakedefine NETDATA_SENTRY_DSN "@NETDATA_SENTRY_DSN@" // enabled bundling |