netdata/packaging/installer: nits and fixes (#6121)

* netdata: fix attempt for labels

* Revert "netdata: fix attempt for labels"

This reverts commit b61525925f5a6d752eac97e4a1cd7af915567ad2.

* netdata: fix attempt for labels (2)

* netdata/packaging/installer: Improvements over netdata installer process around go.d plugin

1) Align retries and timeouts between curl and wget scenarios, should take same time with either tool
2) Add more information when reaching the two error cases, to instruct the user on how to handle the errors
3) Make the download failure a soft error, just warn about skipping install
4) Rename download to download_go, we only run it for go so make this crystal clear

* netdata/packaging/installer: when download has not succeeded, warn the user abort the go.d install and continue

* netdata/packaging: Enforce usage of predefined start/stop commands for netdata. Add some verbosity too for visibility

* netdata/packaging/installer: FreeBSD install - add a note for rc setup, then during first start up use onestart to avoid confusing warnings

* netdata/packaging: Add newer debian supported versions, also a info print nit

* netdata/packaging: Attend first feedback - use separate variable for the command needed by installer

* netdata/packaging: make POSIX compliant equalities. The double equal sign is not working on all shells (dash for example)

* netdata/packaging: fix missed md5sum update in README.md

* netdata/packaging: revert debian selection - got misguided

I obviously didnt test correctly and i misread the release notes, i didnt check the introduction
of systemd during jessie release, i only looked for mentions in stretch.

So revert this change and retest both on droplet and container installations

* netdata/packaging: MacOS - silence a few unimportant errors, make initial detection friendlier

1) Silence failure of commands that are expected to fail on mac
2) add alternatives to uname, to match mac syntax for friendlier output

* netdata/packaging: Update README.md

* netdata/packaging: Adjustments from PR feedback

1) inform about disable-go when bailing out on download failure
2) Make sure you fail the download if the file is empty
3) Make sure you bail out if checksum fails

* netdata/packaging/ci: revert download timeout logic for wget -- seems that there was an exceptional case on wget requiring this differentiation as per cakrits comments -- will revise later, as this is not critical to change

1 files changed, 1 insertions, 1 deletions

diff --git a/packaging/installer/netdata-updater.sh b/packaging/installer/netdata-updater.sh
index 21a769ba57..2d4abcf0bc 100755
--- a/packaging/installer/netdata-updater.sh
+++ b/packaging/installer/netdata-updater.sh
@@ -73,7 +73,7 @@ set_tarball_urls() {
 		return
 	fi
 
-	if [ "$1" == "stable" ]; then
+	if [ "$1" = "stable" ]; then
 		local latest
 		# Simple version
 		# latest="$(curl -sSL https://api.github.com/repos/netdata/netdata/releases/latest | grep tag_name | cut -d'"' -f4)"