Streaming interpolated values (#14431)

* first commit - untested

* fix wrong begin command

* added set v2 too

* debug to log stream buffer

* debug to log stream buffer

* faster streaming printing

* mark charts and dimensions as collected

* use stream points even if sender is not enabled

* comment out stream debug log

* parse null as nan

* custom begin v2

* custom set v2; replication now copies the anomalous flag too

* custom end v2

* enabled stream log test

* renamed to BEGIN2, SET2, END2

* dont mix up replay and v2 members in user object

* fix typo

* cleanup

* support to v2 to v1 proxying

* mark updated dimensions as such

* do not log unknown flags

* comment out stream debug log

* send also the chart id on BEGIN2, v2 to v2

* update the data collections counter

* v2 values are transferred in hex

* faster hex parsing

* a little more generic hex and dec printing and parsing

* fix hex parsing

* minor optimization in dbengine api

* turn debugging into info message

* generalized the timings tracking, so that it can be used in more places

* commented out debug info

* renamed conflicting variable with macro

* remove wrong edits

* integrated ML and added cleanup in case parsing is interrupted

* disable data collection locking during v2

* cleanup stale ML locks; send updated chart variables during v2; add info to find stale locks

* inject an END2 between repeated BEGIN2 from rrdset_done()

* test: remove lockless single-threaded logic from dictionary and aral and apply the right acquire/release memory order to reference counters

* more fine grained dictionary atomics

* remove unecessary return values

* pointer validation under NETDATA_DICTIONARY_VALIDATE_POINTERS

* Revert "pointer validation under NETDATA_DICTIONARY_VALIDATE_POINTERS"

This reverts commit 846cdf2713e2a7ee2ff797f38db11714228800e9.

* Revert "remove unecessary return values"

This reverts commit 8c87d30f4d86f0f5d6b4562cf74fe7447138bbff.

* Revert "more fine grained dictionary atomics"

This reverts commit 984aec4234a340d197d45239ff9a10fd479fcf3c.

* Revert "test: remove lockless single-threaded logic from dictionary and aral and apply the right acquire/release memory order to reference counters"

This reverts commit c460b3d0ad497d2641bd0ea1d63cec7c052e74e4.

* Apply again "pointer validation under NETDATA_DICTIONARY_VALIDATE_POINTERS" while keeping the improved atomic operations.

This reverts commit f158d009

* fix last commit

* fix last commit again

* optimizations in dbengine

* do not send anomaly bit on non-supporting agents (send it when the INTERPOLATED capability is available)

* break long empty-points-loops in rrdset_done()

* decide page alignment on new page allocation, not on every point collected

* create max size pages but no smaller than 1/3

* Fix compilation when --disable-ml is specified

* Return false

* fixes for NETDATA_LOG_REPLICATION_REQUESTS

* added compile option NETDATA_WITHOUT_WORKERS_LATENCY

* put timings in BEGIN2, SET2, END2

* isolate begin2 ml

* revert repositioning data collection lock

* fixed multi-threading of statistics

* do not lookup dimensions all the time if they come in the same order

* update used on iteration, not on every points; also do better error handling

---------

Co-authored-by: Stelios Fragkakis <52996999+stelfrag@users.noreply.github.com>

3 files changed, 7 insertions, 4 deletions

diff --git a/ml/ml-dummy.c b/ml/ml-dummy.c
index 178018898f..966602d2c8 100644
--- a/ml/ml-dummy.c
+++ b/ml/ml-dummy.c
@@ -57,8 +57,9 @@ char *ml_get_host_runtime_info(RRDHOST *RH) {
     return NULL;
 }
 
-void ml_chart_update_begin(RRDSET *RS) {
+bool ml_chart_update_begin(RRDSET *RS) {
     (void) RS;
+    return false;
 }
 
 void ml_chart_update_end(RRDSET *RS) {
diff --git a/ml/ml.cc b/ml/ml.cc
index 461c83baae..0b053f98a1 100644
--- a/ml/ml.cc
+++ b/ml/ml.cc
@@ -167,12 +167,14 @@ void ml_cancel_anomaly_detection_threads(RRDHOST *RH) {
     }
 }
 
-void ml_chart_update_begin(RRDSET *RS) {
+bool ml_chart_update_begin(RRDSET *RS) {
     Chart *C = reinterpret_cast<Chart *>(RS->ml_chart);
     if (!C)
-        return;
+        return false;
 
     C->updateBegin();
+
+    return true;
 }
 
 void ml_chart_update_end(RRDSET *RS) {
diff --git a/ml/ml.h b/ml/ml.h
index 8bed627f5a..320fc0b2f9 100644
--- a/ml/ml.h
+++ b/ml/ml.h
@@ -37,7 +37,7 @@ char *ml_get_host_info(RRDHOST *RH);
 char *ml_get_host_runtime_info(RRDHOST *RH);
 char *ml_get_host_models(RRDHOST *RH);
 
-void ml_chart_update_begin(RRDSET *RS);
+bool ml_chart_update_begin(RRDSET *RS);
 void ml_chart_update_end(RRDSET *RS);
 
 bool ml_is_anomalous(RRDDIM *RD, time_t curr_t, double value, bool exists);