diff options
| author | Stelios Fragkakis <52996999+stelfrag@users.noreply.github.com> | 2023-08-17 00:14:43 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-17 00:14:43 +0300 |
| commit | 18d71460d5deaec1a3ccaf637cdcb40c743d1bd7 (patch) | |
| tree | ea87aa6c7173807618a594342673e95c96db21a3 /libnetdata | |
| parent | 3c78c045bb0ea7225b35df4b6a83e671fc68aed1 (diff) | |
Release job message status to avoid memory leak (#15822)
Release reason if job not found
Diffstat (limited to 'libnetdata')
| -rw-r--r-- | libnetdata/dyn_conf/dyn_conf.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/libnetdata/dyn_conf/dyn_conf.c b/libnetdata/dyn_conf/dyn_conf.c index 3e098fb7fc..c9ad9e8607 100644 --- a/libnetdata/dyn_conf/dyn_conf.c +++ b/libnetdata/dyn_conf/dyn_conf.c @@ -820,9 +820,11 @@ void plugin_del_cb(const DICTIONARY_ITEM *item, void *value, void *data) void report_job_status(struct configurable_plugin *plugin, const char *module_name, const char *job_name, enum job_status status, int status_code, char *reason) { + struct job *job = NULL; const DICTIONARY_ITEM *item = dictionary_get_and_acquire_item(plugins_dict, plugin->name); if (item == NULL) { netdata_log_error("plugin %s not found", plugin->name); + freez(reason); return; } struct configurable_plugin *plug = dictionary_acquired_item_value(item); @@ -840,7 +842,7 @@ void report_job_status(struct configurable_plugin *plugin, const char *module_na netdata_log_error("job %s not found", job_name); goto EXIT_PLUGIN; } - struct job *job = dictionary_acquired_item_value(job_item); + job = dictionary_acquired_item_value(job_item); job->status = status; job->state = status_code; if (job->reason != NULL) { @@ -852,6 +854,8 @@ void report_job_status(struct configurable_plugin *plugin, const char *module_na dictionary_acquired_item_release(mod->jobs, job_item); EXIT_PLUGIN: + if (!job) + freez(reason); dictionary_acquired_item_release(plugins_dict, item); } |