summaryrefslogtreecommitdiffstats
path: root/exporting
diff options
context:
space:
mode:
authorvkalintiris <vasilis@netdata.cloud>2022-05-03 19:02:36 +0300
committerGitHub <noreply@github.com>2022-05-03 19:02:36 +0300
commitebdd819d6ead44c5bab80c69be4a7d419402fe3c (patch)
treecb17c37c6febf067928d44203322d28e141a2aba /exporting
parentea451662055227545550d8f09deecb1427b7c672 (diff)
Remove per chart configuration. (#12728)
After https://github.com/netdata/netdata/pull/12209 per-chart configuration was used for (a) enabling/disabling a chart, and (b) renaming dimensions. Regarding the first use case: We already have component-specific configuration options|flags to finely control how a chart should behave. Eg. "send charts matching" in streaming, "charts to skip from training" in ML, etc. If we really need the concept of a disabled chart, we can add a host-level simple pattern to match these charts. Regarding the second use case: It's not obvious why we'd need to provide support for remapping dimension names through a chart-specific configuration from the core agent. If the need arises, we could add such support at the right place, ie. a exporter/streaming config section. This will allow each flag to act indepentendly from each other and avoid managing flag-state manually at various places, eg: ``` if(unlikely(!rrdset_flag_check(st, RRDSET_FLAG_ENABLED))) { rrdset_flag_clear(st, RRDSET_FLAG_UPSTREAM_SEND); rrdset_flag_set(st, RRDSET_FLAG_UPSTREAM_IGNORE); } ... ```
Diffstat (limited to 'exporting')
-rw-r--r--exporting/tests/exporting_fixtures.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/exporting/tests/exporting_fixtures.c b/exporting/tests/exporting_fixtures.c
index b632761e7e..501fc405c9 100644
--- a/exporting/tests/exporting_fixtures.c
+++ b/exporting/tests/exporting_fixtures.c
@@ -58,7 +58,6 @@ int setup_rrdhost()
st->rrdhost = localhost;
strcpy(st->id, "chart_id");
st->name = strdupz("chart_name");
- st->flags |= RRDSET_FLAG_ENABLED;
st->rrd_memory_mode |= RRD_MEMORY_MODE_SAVE;
st->update_every = 1;