diff options
| author | vkalintiris <vasilis@netdata.cloud> | 2022-11-22 04:52:15 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-22 04:52:15 +0200 |
| commit | 2d5f3acf71f0c759056a3269987fee484566bc4c (patch) | |
| tree | 5246e1080ea721ba84e5f749f8d8e98d978d81c8 /collectors/proc.plugin/sys_devices_system_node.c | |
| parent | 147552807bc19af949fe3cb315c4743dadfa7f0b (diff) | |
Do not force internal collectors to call rrdset_next. (#13926)
* Remove calls to rrdset_next().
* Rm checks plugin
* Update documentantion
* Call rrdset_next from within rrdset_done
This wraps up the removal of rrdset_next from internal collectors, which
removes a lot of unecessary code and the need for if/else clauses in
every place.
The pluginsd parser is the only component that calls rrdset_next*()
functions because it's not strictly speaking a collector but more of a
collector manager/proxy.
With the current changes it's possible to simplify the API we expose
from RRD significantly, but this will be follow-up work in the future.
* Remove stale reference to checks.plugin
* Fix RRD unit test
rrdset_next is not meant to be called from these tests.
* Fix db engine unit test.
* Schedule rrdset_next when we have completed at least one collection.
* Mark chart creation clauses as unlikely.
* Add missing brace to fix FreeBSD plugin.
Diffstat (limited to 'collectors/proc.plugin/sys_devices_system_node.c')
| -rw-r--r-- | collectors/proc.plugin/sys_devices_system_node.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/collectors/proc.plugin/sys_devices_system_node.c b/collectors/proc.plugin/sys_devices_system_node.c index 72362a987f..90aafd56ad 100644 --- a/collectors/proc.plugin/sys_devices_system_node.c +++ b/collectors/proc.plugin/sys_devices_system_node.c @@ -127,7 +127,6 @@ int do_proc_sys_devices_system_node(int update_every, usec_t dt) { rrddim_add(m->numastat_st, "other_node", "other", 1, 1, RRD_ALGORITHM_INCREMENTAL); } - else rrdset_next(m->numastat_st); size_t lines = procfile_lines(m->numastat_ff), l; for(l = 0; l < lines; l++) { |