more linting of bash modules (#4183)

1 files changed, 15 insertions, 14 deletions

diff --git a/charts.d/cpufreq.chart.sh b/charts.d/cpufreq.chart.sh
index 8613a000ea..bad06d1c79 100644
--- a/charts.d/cpufreq.chart.sh
+++ b/charts.d/cpufreq.chart.sh
@@ -20,7 +20,7 @@ cpufreq_update_every=
 cpufreq_priority=10000
 
 cpufreq_find_all_files() {
-	find $1 -maxdepth $cpufreq_sys_depth -name scaling_cur_freq 2>/dev/null
+	find "$1" -maxdepth $cpufreq_sys_depth -name scaling_cur_freq 2>/dev/null
 }
 
 # _check is called once, to find out if this chart should be enabled or not
@@ -30,30 +30,30 @@ cpufreq_check() {
 	#  - 0 to enable the chart
 	#  - 1 to disable the chart
 
-	[ -z "$( cpufreq_find_all_files $cpufreq_sys_dir )" ] && return 1
+	[ -z "$( cpufreq_find_all_files "$cpufreq_sys_dir" )" ] && return 1
 	return 0
 }
 
 # _create is called once, to create the charts
 cpufreq_create() {
-	local dir= file= id= i=
+	local dir file id i
 
 	# we create a script with the source of the
 	# cpufreq_update() function
 	# - the highest speed we can achieve -
-	[ $cpufreq_source_update -eq 1 ] && echo >$TMP_DIR/cpufreq.sh "cpufreq_update() {"
+	[ $cpufreq_source_update -eq 1 ] && echo >"$TMP_DIR/cpufreq.sh" "cpufreq_update() {"
 
 	echo "CHART cpu.cpufreq '' 'CPU Clock' 'MHz' 'cpufreq' '' line $((cpufreq_priority + 1)) $cpufreq_update_every"
-	echo >>$TMP_DIR/cpufreq.sh "echo \"BEGIN cpu.cpufreq \$1\""
+	echo >>"$TMP_DIR/cpufreq.sh" "echo \"BEGIN cpu.cpufreq \$1\""
 
 	i=0
-	for file in $( cpufreq_find_all_files $cpufreq_sys_dir | sort -u )
+	for file in $( cpufreq_find_all_files "$cpufreq_sys_dir" | sort -u )
 	do
 		i=$(( i + 1 ))
-		dir=$( dirname $file )
+		dir=$( dirname "$file" )
 		cpu=
 
-		[ -f $dir/affected_cpus ] && cpu=$( cat $dir/affected_cpus )
+		[ -f "$dir/affected_cpus" ] && cpu=$( cat "$dir/affected_cpus" )
 		[ -z "$cpu" ] && cpu="$i.a"
 
 		id="$( fixid "cpu$cpu" )"
@@ -61,14 +61,15 @@ cpufreq_create() {
 		debug "file='$file', dir='$dir', cpu='$cpu', id='$id'"
 
 		echo "DIMENSION $id '$id' absolute 1 1000"
-		echo >>$TMP_DIR/cpufreq.sh "echo \"SET $id = \"\$(< $file )"
+		echo >>"$TMP_DIR/cpufreq.sh" "echo \"SET $id = \"\$(< $file )"
 	done
-	echo >>$TMP_DIR/cpufreq.sh "echo END"
+	echo >>"$TMP_DIR/cpufreq.sh" "echo END"
 
-	[ $cpufreq_source_update -eq 1 ] && echo >>$TMP_DIR/cpufreq.sh "}"
+	[ $cpufreq_source_update -eq 1 ] && echo >>"$TMP_DIR/cpufreq.sh" "}"
 
 	# ok, load the function cpufreq_update() we created
-	[ $cpufreq_source_update -eq 1 ] && . $TMP_DIR/cpufreq.sh
+        # shellcheck disable=SC1090
+	[ $cpufreq_source_update -eq 1 ] && . "$TMP_DIR/cpufreq.sh"
 
 	return 0
 }
@@ -81,8 +82,8 @@ cpufreq_update() {
 	# do all the work to collect / calculate the values
 	# for each dimension
 	# remember: KEEP IT SIMPLE AND SHORT
-
-	[ $cpufreq_source_update -eq 0 ] && . $TMP_DIR/cpufreq.sh $1
+        # shellcheck disable=SC1090
+	[ $cpufreq_source_update -eq 0 ] && . "$TMP_DIR/cpufreq.sh" "$1"
 
 	return 0
 }