diff options
| author | Chris Akritidis <43294513+cakrit@users.noreply.github.com> | 2019-04-02 16:56:31 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-04-02 16:56:31 +0200 |
| commit | e0f69fd8be92866b83299e04a1ef3752db5bc097 (patch) | |
| tree | fbbcb8f3f0129fcaec894586b8228a52a327f841 | |
| parent | 4f07096baadc9314dac9d184afe03148601136f3 (diff) | |
Fix smstools3 error handling (#5770)
* Fixed smstools3 error handling
* Correct variable declarations
* Correct smssend to sendsms
* Add two spaces before dashes in .md lists
* Add two spaces AFTER dashes in .md lists
* Change list to star
| -rwxr-xr-x | health/notifications/alarm-notify.sh.in | 9 | ||||
| -rw-r--r-- | health/notifications/smstools3/README.md | 7 |
2 files changed, 12 insertions, 4 deletions
diff --git a/health/notifications/alarm-notify.sh.in b/health/notifications/alarm-notify.sh.in index 763b1d224f..16e5f08ad7 100755 --- a/health/notifications/alarm-notify.sh.in +++ b/health/notifications/alarm-notify.sh.in @@ -1740,7 +1740,7 @@ send_syslog() { # SMS sender send_sms() { - local recipients="${1}" exitcode sent=0 + local recipients="${1}" errcode errmessage sent=0 # Human readable SMS local msg="${host} ${status_message}: ${chart} (${family}), ${alarm}" @@ -1751,12 +1751,13 @@ send_sms() { if [ "${SEND_SMS}" = "YES" ] && [ -n "${sendsms}" ] && [ -n "${recipients}" ] && [ -n "${msg}" ]; then # http://api.kavenegar.com/v1/{API-KEY}/sms/send.json for phone in ${recipients}; do - exitcode=$($sendsms $phone "$msg") - if [ ${exitcode} -eq 0 ]; then + errmessage=$($sendsms $phone "$msg" 2>&1) + errcode=$? + if [ ${errcode} -eq 0 ]; then info "sent smstools3 SMS for: ${host} ${chart}.${name} is ${status} to '${user}'" sent=$((sent + 1)) else - error "failed to send smstools3 SMS for: ${host} ${chart}.${name} is ${status} to '${user}' with error code ${exitcode}." + error "failed to send smstools3 SMS for: ${host} ${chart}.${name} is ${status} to '${user}' with error code ${errcode}: ${errmessage}." fi done diff --git a/health/notifications/smstools3/README.md b/health/notifications/smstools3/README.md index 71e13dc197..4a1469853e 100644 --- a/health/notifications/smstools3/README.md +++ b/health/notifications/smstools3/README.md @@ -4,6 +4,13 @@ The [SMS Server Tools 3](http://smstools3.kekekasvi.com/) is a SMS Gateway softw To have netdata send notifications via SMS Server Tools 3, you'll first need to [install](http://smstools3.kekekasvi.com/index.php?p=compiling) and [configure](http://smstools3.kekekasvi.com/index.php?p=configure) smsd. +Ensure that the user `netdata` can execute `sendsms`. Any user executing `sendsms` needs to: + +* Have write permissions to `/tmp` and `/var/spool/sms/outgoing` +* Be a member of group `smsd` + +To ensure that the steps above are successful, just `su netdata` and execute `sendsms phone message`. + You then just need to configure the recipient phone numbers in `health_alarm_notify.conf`: ```sh |