summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCosta Tsaousis <costa@netdata.cloud>2022-09-19 23:46:13 +0300
committerGitHub <noreply@github.com>2022-09-19 23:46:13 +0300
commitcb7af25c09d8775d1967cb0553268075cda868d4 (patch)
tree9e86bc359bb2b1ec72d3a1382236703dc633ad63
parent62246029160025a8d6503d9fbb617c7b029b9126 (diff)
RRD structures managed by dictionaries (#13646)
* rrdset - in progress * rrdset optimal constructor; rrdset conflict * rrdset final touches * re-organization of rrdset object members * prevent use-after-free * dictionary dfe supports also counting of iterations * rrddim managed by dictionary * rrd.h cleanup * DICTIONARY_ITEM now is referencing actual dictionary items in the code * removed rrdset linked list * Revert "removed rrdset linked list" This reverts commit 690d6a588b4b99619c2c5e10f84e8f868ae6def5. * removed rrdset linked list * added comments * Switch chart uuid to static allocation in rrdset Remove unused functions * rrdset_archive() and friends... * always create rrdfamily * enable ml_free_dimension * rrddim_foreach done with dfe * most custom rrddim loops replaced with rrddim_foreach * removed accesses to rrddim->dimensions * removed locks that are no longer needed * rrdsetvar is now managed by the dictionary * set rrdset is rrdsetvar, fixes https://github.com/netdata/netdata/pull/13646#issuecomment-1242574853 * conflict callback of rrdsetvar now properly checks if it has to reset the variable * dictionary registered callbacks accept as first parameter the DICTIONARY_ITEM * dictionary dfe now uses internal counter to report; avoided excess variables defined with dfe * dictionary walkthrough callbacks get dictionary acquired items * dictionary reference counters that can be dupped from zero * added advanced functions for get and del * rrdvar managed by dictionaries * thread safety for rrdsetvar * faster rrdvar initialization * rrdvar string lengths should match in all add, del, get functions * rrdvar internals hidden from the rest of the world * rrdvar is now acquired throughout netdata * hide the internal structures of rrdsetvar * rrdsetvar is now acquired through out netdata * rrddimvar managed by dictionary; rrddimvar linked list removed; rrddimvar structures hidden from the rest of netdata * better error handling * dont create variables if not initialized for health * dont create variables if not initialized for health again * rrdfamily is now managed by dictionaries; references of it are acquired dictionary items * type checking on acquired objects * rrdcalc renaming of functions * type checking for rrdfamily_acquired * rrdcalc managed by dictionaries * rrdcalc double free fix * host rrdvars is always needed * attempt to fix deadlock 1 * attempt to fix deadlock 2 * Remove unused variable * attempt to fix deadlock 3 * snprintfz * rrdcalc index in rrdset fix * Stop storing active charts and computing chart hashes * Remove store active chart function * Remove compute chart hash function * Remove sql_store_chart_hash function * Remove store_active_dimension function * dictionary delayed destruction * formatting and cleanup * zero dictionary base on rrdsetvar * added internal error to log delayed destructions of dictionaries * typo in rrddimvar * added debugging info to dictionary * debug info * fix for rrdcalc keys being empty * remove forgotten unlock * remove deadlock * Switch to metadata version 5 and drop chart_hash chart_hash_map chart_active dimension_active v_chart_hash * SQL cosmetic changes * do not busy wait while destroying a referenced dictionary * remove deadlock * code cleanup; re-organization; * fast cleanup and flushing of dictionaries * number formatting fixes * do not delete configured alerts when archiving a chart * rrddim obsolete linked list management outside dictionaries * removed duplicate contexts call * fix crash when rrdfamily is not initialized * dont keep rrddimvar referenced * properly cleanup rrdvar * removed some locks * Do not attempt to cleanup chart_hash / chart_hash_map * rrdcalctemplate managed by dictionary * register callbacks on the right dictionary * removed some more locks * rrdcalc secondary index replaced with linked-list; rrdcalc labels updates are now executed by health thread * when looking up for an alarm look using both chart id and chart name * host initialization a bit more modular * init rrdlabels on host update * preparation for dictionary views * improved comment * unused variables without internal checks * service threads isolation and worker info * more worker info in service thread * thread cancelability debugging with internal checks * strings data races addressed; fixes https://github.com/netdata/netdata/issues/13647 * dictionary modularization * Remove unused SQL statement definition * unit-tested thread safety of dictionaries; removed data race conditions on dictionaries and strings; dictionaries now can detect if the caller is holds a write lock and automatically all the calls become their unsafe versions; all direct calls to unsafe version is eliminated * remove worker_is_idle() from the exit of service functions, because we lose the lock time between loops * rewritten dictionary to have 2 separate locks, one for indexing and another for traversal * Update collectors/cgroups.plugin/sys_fs_cgroup.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * Update collectors/cgroups.plugin/sys_fs_cgroup.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * Update collectors/proc.plugin/proc_net_dev.c Co-authored-by: Vladimir Kobal <vlad@prokk.net> * fix memory leak in rrdset cache_dir * minor dictionary changes * dont use index locks in single threaded * obsolete dict option * rrddim options and flags separation; rrdset_done() optimization to keep array of reference pointers to rrddim; * fix jump on uninitialized value in dictionary; remove double free of cache_dir * addressed codacy findings * removed debugging code * use the private refcount on dictionaries * make dictionary item desctructors work on dictionary destruction; strictier control on dictionary API; proper cleanup sequence on rrddim; * more dictionary statistics * global statistics about dictionary operations, memory, items, callbacks * dictionary support for views - missing the public API * removed warning about unused parameter * chart and context name for cloud * chart and context name for cloud, again * dictionary statistics fixed; first implementation of dictionary views - not currently used * only the master can globally delete an item * context needs netdata prefix * fix context and chart it of spins * fix for host variables when health is not enabled * run garbage collector on item insert too * Fix info message; remove extra "using" * update dict unittest for new placement of garbage collector * we need RRDHOST->rrdvars for maintaining custom host variables * Health initialization needs the host->host_uuid * split STRING to its own files; no code changes other than that * initialize health unconditionally * unit tests do not pollute the global scope with their variables * Skip initialization when creating archived hosts on startup. When a child connects it will initialize properly Co-authored-by: Stelios Fragkakis <52996999+stelfrag@users.noreply.github.com> Co-authored-by: Vladimir Kobal <vlad@prokk.net>
-rw-r--r--CMakeLists.txt31
-rw-r--r--Makefile.am2
-rw-r--r--collectors/cgroups.plugin/sys_fs_cgroup.c23
-rw-r--r--collectors/cgroups.plugin/tests/test_doubles.c8
-rw-r--r--collectors/cups.plugin/cups_plugin.c13
-rw-r--r--collectors/diskspace.plugin/plugin_diskspace.c6
-rw-r--r--collectors/plugins.d/pluginsd_parser.c26
-rw-r--r--collectors/proc.plugin/ipc.c12
-rw-r--r--collectors/proc.plugin/proc_diskstats.c2
-rw-r--r--collectors/proc.plugin/proc_interrupts.c4
-rw-r--r--collectors/proc.plugin/proc_loadavg.c6
-rw-r--r--collectors/proc.plugin/proc_mdstat.c1
-rw-r--r--collectors/proc.plugin/proc_net_dev.c9
-rw-r--r--collectors/proc.plugin/proc_net_snmp.c4
-rw-r--r--collectors/proc.plugin/proc_net_sockstat.c12
-rw-r--r--collectors/proc.plugin/proc_net_stat_conntrack.c4
-rw-r--r--collectors/proc.plugin/proc_net_wireless.c1
-rw-r--r--collectors/proc.plugin/proc_self_mountinfo.c3
-rw-r--r--collectors/proc.plugin/proc_softirqs.c4
-rw-r--r--collectors/proc.plugin/proc_spl_kstat_zfs.c6
-rw-r--r--collectors/proc.plugin/proc_stat.c4
-rw-r--r--collectors/proc.plugin/sys_block_zram.c13
-rw-r--r--collectors/proc.plugin/sys_class_infiniband.c6
-rw-r--r--collectors/proc.plugin/sys_class_power_supply.c1
-rw-r--r--collectors/proc.plugin/sys_fs_btrfs.c1
-rw-r--r--collectors/statsd.plugin/statsd.c53
-rw-r--r--collectors/tc.plugin/plugin_tc.c75
-rw-r--r--configure.ac1
-rw-r--r--daemon/analytics.c60
-rw-r--r--daemon/global_statistics.c369
-rw-r--r--daemon/main.c4
-rw-r--r--daemon/service.c251
-rw-r--r--daemon/unit_test.c36
-rw-r--r--database/engine/journalfile.c2
-rwxr-xr-xdatabase/engine/rrdengineapi.c2
-rw-r--r--database/ram/rrddim_mem.c2
-rw-r--r--database/rrd.h449
-rw-r--r--database/rrdcalc.c869
-rw-r--r--database/rrdcalc.h115
-rw-r--r--database/rrdcalctemplate.c202
-rw-r--r--database/rrdcalctemplate.h35
-rw-r--r--database/rrdcontext.c188
-rw-r--r--database/rrdcontext.h2
-rw-r--r--database/rrddim.c589
-rw-r--r--database/rrddimvar.c278
-rw-r--r--database/rrddimvar.h44
-rw-r--r--database/rrdfamily.c87
-rw-r--r--database/rrdhost.c544
-rw-r--r--database/rrdlabels.c97
-rw-r--r--database/rrdset.c1085
-rw-r--r--database/rrdsetvar.c305
-rw-r--r--database/rrdsetvar.h36
-rw-r--r--database/rrdvar.c272
-rw-r--r--database/rrdvar.h74
-rw-r--r--database/sqlite/sqlite_aclk.c3
-rw-r--r--database/sqlite/sqlite_aclk_chart.c36
-rw-r--r--database/sqlite/sqlite_aclk_node.c5
-rw-r--r--database/sqlite/sqlite_db_migration.c18
-rw-r--r--database/sqlite/sqlite_functions.c381
-rw-r--r--database/sqlite/sqlite_functions.h13
-rw-r--r--database/sqlite/sqlite_health.c15
-rw-r--r--exporting/json/json.c4
-rw-r--r--exporting/process_data.c12
-rw-r--r--exporting/prometheus/prometheus.c28
-rw-r--r--exporting/prometheus/remote_write/remote_write.c8
-rw-r--r--exporting/tests/netdata_doubles.c8
-rw-r--r--health/health.c184
-rw-r--r--health/health.h4
-rw-r--r--health/health_config.c188
-rw-r--r--health/health_json.c31
-rw-r--r--health/health_log.c19
-rw-r--r--libnetdata/Makefile.am1
-rw-r--r--libnetdata/dictionary/README.md18
-rw-r--r--libnetdata/dictionary/dictionary.c3539
-rw-r--r--libnetdata/dictionary/dictionary.h283
-rw-r--r--libnetdata/libnetdata.h1
-rw-r--r--libnetdata/locks/README.md6
-rw-r--r--libnetdata/log/log.c11
-rw-r--r--libnetdata/required_dummies.h2
-rw-r--r--libnetdata/string/Makefile.am8
-rw-r--r--libnetdata/string/README.md20
-rw-r--r--libnetdata/string/string.c595
-rw-r--r--libnetdata/string/string.h30
-rw-r--r--libnetdata/threads/threads.c29
-rw-r--r--libnetdata/threads/threads.h7
-rw-r--r--ml/Dimension.h2
-rw-r--r--registry/registry.c8
-rw-r--r--registry/registry_db.c11
-rw-r--r--registry/registry_init.c18
-rw-r--r--registry/registry_internals.h2
-rw-r--r--registry/registry_machine.c10
-rw-r--r--streaming/rrdpush.c30
-rw-r--r--streaming/rrdpush.h2
-rw-r--r--streaming/sender.c32
-rw-r--r--tests/profile/benchmark-dictionary.c4
-rw-r--r--web/api/badges/web_buffer_svg.c14
-rw-r--r--web/api/exporters/shell/allmetrics_shell.c21
-rw-r--r--web/api/formatters/charts2json.c15
-rw-r--r--web/api/formatters/json_wrapper.c25
-rw-r--r--web/api/formatters/rrd2json.c11
-rw-r--r--web/api/formatters/rrdset2json.c17
-rw-r--r--web/api/queries/query.c40
-rw-r--r--web/api/queries/rrdr.c4
-rw-r--r--web/api/queries/rrdr.h1
-rw-r--r--web/api/queries/weights.c42
-rw-r--r--web/api/web_api_v1.c8
106 files changed, 6989 insertions, 5163 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index c2dfcc02ef..02fc8304e7 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -220,7 +220,11 @@ pkg_check_modules(CURL libcurl)
# -----------------------------------------------------------------------------
# Detect libcups
-pkg_check_modules(CURL libcups)
+pkg_check_modules(CUPS libcups)
+IF(NOT CUPS_LIBRARIES)
+ pkg_check_modules(CUPS cups)
+ENDIF()
+
# later we use:
# ${CUPS_LIBRARIES}
# ${CUPS_CFLAGS_OTHER}
@@ -446,6 +450,8 @@ set(LIBNETDATA_FILES
libnetdata/avl/avl.h
libnetdata/buffer/buffer.c
libnetdata/buffer/buffer.h
+ libnetdata/circular_buffer/circular_buffer.c
+ libnetdata/circular_buffer/circular_buffer.h
libnetdata/clocks/clocks.c
libnetdata/clocks/clocks.h
libnetdata/completion/completion.c
@@ -454,10 +460,15 @@ set(LIBNETDATA_FILES
libnetdata/dictionary/dictionary.h
libnetdata/eval/eval.c
libnetdata/eval/eval.h
+ libnetdata/health/health.c
+ libnetdata/health/health.h
libnetdata/inlined.h
+ libnetdata/json/json.c
+ libnetdata/json/json.h
+ libnetdata/json/jsmn.c
+ libnetdata/json/jsmn.h
libnetdata/libnetdata.c
libnetdata/libnetdata.h
- libnetdata/required_dummies.h
libnetdata/locks/locks.c
libnetdata/locks/locks.h
libnetdata/log/log.c
@@ -470,6 +481,9 @@ set(LIBNETDATA_FILES
libnetdata/popen/popen.h
libnetdata/procfile/procfile.c
libnetdata/procfile/procfile.h
+ libnetdata/required_dummies.h
+ libnetdata/socket/security.c
+ libnetdata/socket/security.h
libnetdata/simple_pattern/simple_pattern.c
libnetdata/simple_pattern/simple_pattern.h
libnetdata/socket/socket.c
@@ -478,23 +492,16 @@ set(LIBNETDATA_FILES
libnetdata/statistical/statistical.h
libnetdata/storage_number/storage_number.c
libnetdata/storage_number/storage_number.h
+ libnetdata/string/string.c
+ libnetdata/string/string.h
libnetdata/threads/threads.c
libnetdata/threads/threads.h
libnetdata/url/url.c
libnetdata