diff options
| author | Stelios Fragkakis <52996999+stelfrag@users.noreply.github.com> | 2024-02-14 10:49:02 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-14 10:49:02 +0200 |
| commit | b7086f0408e3a8aaef6cc15df05b4b9b334dd599 (patch) | |
| tree | 9ae93387a23b68b713e112b0398073bdf505ae7a | |
| parent | 6c0c20a2c7b1fcfc33a0173ce91c2ea3fe9f8c75 (diff) | |
Misc improvements (#17001)
Use spinlock init for proper initialization so that it will work properly when compiling with NETDATA_INTERNAL_CHECKS
Clear errno so that it will not report an error when logging analyze command
| -rw-r--r-- | src/daemon/analytics.c | 2 | ||||
| -rw-r--r-- | src/database/rrddim.c | 2 | ||||
| -rw-r--r-- | src/database/sqlite/sqlite_functions.c | 1 |
3 files changed, 3 insertions, 2 deletions
diff --git a/src/daemon/analytics.c b/src/daemon/analytics.c index de09a69600..015b8b2e86 100644 --- a/src/daemon/analytics.c +++ b/src/daemon/analytics.c @@ -470,7 +470,7 @@ void analytics_alarms(void) */ void analytics_misc(void) { - analytics_data.spinlock.locked = false; + spinlock_init(&analytics_data.spinlock); #ifdef ENABLE_ACLK analytics_set_data(&analytics_data.netdata_host_cloud_available, "true"); diff --git a/src/database/rrddim.c b/src/database/rrddim.c index 74f48fb182..2f1cf28cab 100644 --- a/src/database/rrddim.c +++ b/src/database/rrddim.c @@ -95,7 +95,7 @@ static void rrddim_insert_callback(const DICTIONARY_ITEM *item __maybe_unused, v rd->tiers[tier].seb = eng->seb; rd->tiers[tier].tier_grouping = host->db[tier].tier_grouping; rd->tiers[tier].smh = eng->api.metric_get_or_create(rd, host->db[tier].si); - rd->tiers[tier].spinlock.locked = false; + spinlock_init(&rd->tiers[tier].spinlock); storage_point_unset(rd->tiers[tier].virtual_point); initialized++; diff --git a/src/database/sqlite/sqlite_functions.c b/src/database/sqlite/sqlite_functions.c index fab3847c27..2b01ce79c6 100644 --- a/src/database/sqlite/sqlite_functions.c +++ b/src/database/sqlite/sqlite_functions.c @@ -450,6 +450,7 @@ int sql_init_database(db_check_action_type_t rebuild, int memory) } if (rebuild & DB_CHECK_ANALYZE) { + errno = 0; netdata_log_info("Running ANALYZE on %s", sqlite_database); rc = sqlite3_exec_monitored(db_meta, "ANALYZE", 0, 0, &err_msg); if (rc != SQLITE_OK) { |