summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStelios Fragkakis <52996999+stelfrag@users.noreply.github.com>2024-02-20 20:48:13 +0200
committerGitHub <noreply@github.com>2024-02-20 20:48:13 +0200
commite1eca0562faa4a7818607656cc72aec4d2c35612 (patch)
treee34127009e057644aa6c0bdd5907efb857376bf0
parent58464f5d93cb3909d39595c9e21c3b6d1aa7d6b3 (diff)
Improved query target cleanup (#17038)
Clear smh to avoid possible double metric release
-rw-r--r--src/database/contexts/query_target.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/database/contexts/query_target.c b/src/database/contexts/query_target.c
index d2aa0af6f9..129445dc63 100644
--- a/src/database/contexts/query_target.c
+++ b/src/database/contexts/query_target.c
@@ -346,8 +346,10 @@ static bool query_metric_add(QUERY_TARGET_LOCALS *qtl, QUERY_NODE *qn, QUERY_CON
// cleanup anything we allocated to the retention we will not use
for(size_t tier = 0; tier < storage_tiers ;tier++) {
- if (tier_retention[tier].smh)
+ if (tier_retention[tier].smh) {
tier_retention[tier].eng->api.metric_release(tier_retention[tier].smh);
+ tier_retention[tier].smh = NULL;
+ }
}
return false;