diff options
author | Tasos Katsoulas <12612986+tkatsoulas@users.noreply.github.com> | 2024-02-10 20:43:44 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-02-10 20:43:44 +0200 |
commit | 29c1b548b61340cca74e7e1d7c3ce2f3e02d77d9 (patch) | |
tree | a93c6ba8c029d5e8b887a50445ee3110822c347e | |
parent | 3f59438c2044b8b950f7b5b74c4102f76fc90148 (diff) |
Update input skip patterns (#16984)
* Fix minor typo:
- job name will be file-check in any workflow
- file-check job has a step which is check-file
* Print any modified files
* Change glob patterns for all source files (*.c, *.h etc). With the previous approach they only matched the root folder
---------
Signed-off-by: Tasos Katsoulas <tasos@netdata.cloud>
Co-authored-by: Ilya Mashchenko <ilya@netdata.cloud>
-rw-r--r-- | .github/workflows/build.yml | 24 | ||||
-rw-r--r-- | .github/workflows/checks.yml | 24 | ||||
-rw-r--r-- | .github/workflows/docker.yml | 28 | ||||
-rw-r--r-- | .github/workflows/packaging.yml | 28 |
4 files changed, 64 insertions, 40 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 39e086861d..6446d1400e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -38,13 +38,13 @@ jobs: with: since_last_remote_commit: ${{ github.event_name != 'pull_request' }} files: | - **.c - **.cc - **.h - **.hh - **.in - **.patch - **.cmake + **/*.c + **/*.cc + **/*.h + **/*.hh + **/*.in + **/*.patch + **/*.cmake CMakeLists.txt netdata-installer.sh .github/data/distros.yml @@ -64,8 +64,14 @@ jobs: web/server/h2o/libh2o/ files_ignore: | netdata.spec.in - **.md - negation_patterns_first: true + **/*.md + - name: List all modified files in pattern + env: + ALL_MODIFIED_FILES: ${{ steps.check-files.outputs.all_modified_files }} + run: | + for file in ${ALL_MODIFIED_FILES}; do + echo "$file was modified" + done - name: Check Run id: check-run run: | diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 74c0c2e187..27d40ca89d 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -29,13 +29,13 @@ jobs: with: since_last_remote_commit: ${{ github.event_name != 'pull_request' }} files: | - **.c - **.cc - **.h - **.hh - **.in - **.patch - **.cmake + **/*.c + **/*.cc + **/*.h + **/*.hh + **/*.in + **/*.patch + **/*.cmake CMakeLists.txt .gitignore .github/data/distros.yml @@ -52,8 +52,14 @@ jobs: web/server/h2o/libh2o/ files_ignore: | netdata.spec.in - **.md - negation_patterns_first: true + **/*.md + - name: List all modified files in pattern + env: + ALL_MODIFIED_FILES: ${{ steps.check-files.outputs.all_modified_files }} + run: | + for file in ${ALL_MODIFIED_FILES}; do + echo "$file was modified" + done - name: Check Run id: check-run run: | diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index a683c16001..1beed58404 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -30,18 +30,18 @@ jobs: fetch-depth: 0 submodules: recursive - name: Check files - id: file-check + id: check-files uses: tj-actions/changed-files@v42 with: since_last_remote_commit: ${{ github.event_name != 'pull_request' }} files: | - **.c - **.cc - **.h - **.hh - **.in - **.patch - **.cmake + **/*.c + **/*.cc + **/*.h + **/*.hh + **/*.in + **/*.patch + **/*.cmake .dockerignore CMakeLists.txt netdata-installer.sh @@ -58,12 +58,18 @@ jobs: web/server/h2o/libh2o/ files_ignore: | netdata.spec.in - **.md - negation_patterns_first: true + **/*.md + - name: List all modified files in pattern + env: + ALL_MODIFIED_FILES: ${{ steps.check-files.outputs.all_modified_files }} + run: | + for file in ${ALL_MODIFIED_FILES}; do + echo "$file was modified" + done - name: Check Run id: check-run run: | - if [ "${{ steps.file-check.outputs.any_modified }}" == "true" ] || [ "${{ github.event_name }}" == "workflow_dispatch" ]; then + if [ "${{ steps.check-files.outputs.any_modified }}" == "true" ] || [ "${{ github.event_name }}" == "workflow_dispatch" ]; then echo 'run=true' >> "${GITHUB_OUTPUT}" else echo 'run=false' >> "${GITHUB_OUTPUT}" diff --git a/.github/workflows/packaging.yml b/.github/workflows/packaging.yml index fe5f48b65b..1b7e7f9e93 100644 --- a/.github/workflows/packaging.yml +++ b/.github/workflows/packaging.yml @@ -40,18 +40,18 @@ jobs: fetch-depth: 0 submodules: recursive - name: Check files - id: file-check + id: check-files uses: tj-actions/changed-files@v42 with: since_last_remote_commit: ${{ github.event_name != 'pull_request' }} files: | - **.c - **.cc - **.h - **.hh - **.in - **.patch - **.cmake + **/*.c + **/*.cc + **/*.h + **/*.hh + **/*.in + **/*.patch + **/*.cmake netdata.spec.in contrib/debian/ CMakeLists.txt @@ -67,12 +67,18 @@ jobs: src/fluent-bit/ web/server/h2o/libh2o/ files_ignore: | - **.md - negation_patterns_first: true + **/*.md + - name: List all modified files in pattern + env: + ALL_MODIFIED_FILES: ${{ steps.check-files.outputs.all_modified_files }} + run: | + for file in ${ALL_MODIFIED_FILES}; do + echo "$file was modified" + done - name: Check Run id: check-run run: | - if [ "${{ steps.file-check.outputs.any_modified }}" == "true" ] || [ "${{ github.event_name }}" == "workflow_dispatch" ]; then + if [ "${{ steps.check-files.outputs.any_modified }}" == "true" ] || [ "${{ github.event_name }}" == "workflow_dispatch" ]; then echo 'run=true' >> "${GITHUB_OUTPUT}" else echo 'run=false' >> "${GITHUB_OUTPUT}" |