summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStelios Fragkakis <52996999+stelfrag@users.noreply.github.com>2022-07-18 16:26:10 +0300
committerStelios Fragkakis <52996999+stelfrag@users.noreply.github.com>2022-07-18 16:27:10 +0300
commite7653b28a489776c6022e3fabaa26ea9e65beac7 (patch)
tree447e283c947f48acf88e897604869fc6704c4a0c
parent497b6814b3ec78de073476211a0de94b5f9c1627 (diff)
Check if we reached the version we want first (address CODACY report re: Array index 'i' is used before limits check)
-rw-r--r--database/sqlite/sqlite_db_migration.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/database/sqlite/sqlite_db_migration.c b/database/sqlite/sqlite_db_migration.c
index 77ba77d0b4..dca96ac3e1 100644
--- a/database/sqlite/sqlite_db_migration.c
+++ b/database/sqlite/sqlite_db_migration.c
@@ -116,7 +116,7 @@ static int migrate_database(sqlite3 *database, int target_version, char *db_name
}
info("Database version is %d, current version is %d. Running migration for %s ...", user_version, target_version, db_name);
- for (int i = user_version; migration_list[i].func && i < target_version; i++) {
+ for (int i = user_version; i < target_version && migration_list[i].func; i++) {
rc = (migration_list[i].func)(database, migration_list[i].name);
if (unlikely(rc)) {
error_report("Database %s migration from version %d to version %d failed", db_name, i, i + 1);