summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorthiagoftsm <thiagoftsm@gmail.com>2020-01-28 15:27:12 +0000
committerGitHub <noreply@github.com>2020-01-28 15:27:12 +0000
commit93631017d868d8d432124e18c96bbe6dcba4bce0 (patch)
tree91c1b5aae514224d192c0fabe6a086c46c54a596
parentfa92c1e3b4990d76a87bb6d85297c954b667f397 (diff)
Missing extern (#7877)
* missing_extern: Fix missing Fix few externs that were missing in global variables * missing_extern: Variables This commit declares the variables inside .c files
-rw-r--r--daemon/common.c2
-rw-r--r--daemon/common.h2
-rw-r--r--health/health.c1
-rw-r--r--health/health.h2
-rw-r--r--libnetdata/health/health.c2
-rw-r--r--libnetdata/health/health.h2
-rw-r--r--web/api/web_api_v1.c2
-rw-r--r--web/api/web_api_v1.h2
8 files changed, 10 insertions, 5 deletions
diff --git a/daemon/common.c b/daemon/common.c
index e28f6cf000..67497a4e93 100644
--- a/daemon/common.c
+++ b/daemon/common.c
@@ -13,4 +13,4 @@ char *netdata_configured_varlib_dir = VARLIB_DIR;
char *netdata_configured_home_dir = CACHE_DIR;
char *netdata_configured_host_prefix = NULL;
char *netdata_configured_timezone = NULL;
-
+int netdata_ready;
diff --git a/daemon/common.h b/daemon/common.h
index 6ac3cb3c87..59dbc41a8d 100644
--- a/daemon/common.h
+++ b/daemon/common.h
@@ -84,6 +84,6 @@ extern char *netdata_configured_timezone;
extern int netdata_zero_metrics_enabled;
extern int netdata_anonymous_statistics_enabled;
-int netdata_ready;
+extern int netdata_ready;
#endif /* NETDATA_COMMON_H */
diff --git a/health/health.c b/health/health.c
index 1124cf9107..4a84ef7fca 100644
--- a/health/health.c
+++ b/health/health.c
@@ -9,6 +9,7 @@ struct health_cmdapi_thread_status {
};
unsigned int default_health_enabled = 1;
+char *silencers_filename;
// ----------------------------------------------------------------------------
// health initialization
diff --git a/health/health.h b/health/health.h
index 9da90d70c9..d77318fd78 100644
--- a/health/health.h
+++ b/health/health.h
@@ -52,7 +52,7 @@ extern unsigned int default_health_enabled;
#define HEALTH_SILENCERS_MAX_FILE_LEN 10000
-char *silencers_filename;
+extern char *silencers_filename;
extern void health_init(void);
extern void *health_main(void *ptr);
diff --git a/libnetdata/health/health.c b/libnetdata/health/health.c
index e03538db3f..98d26d295f 100644
--- a/libnetdata/health/health.c
+++ b/libnetdata/health/health.c
@@ -1,5 +1,7 @@
#include "health.h"
+SILENCERS *silencers;
+
/**
* Create Silencer
*
diff --git a/libnetdata/health/health.h b/libnetdata/health/health.h
index a3dc0775fc..f7580edab2 100644
--- a/libnetdata/health/health.h
+++ b/libnetdata/health/health.h
@@ -44,7 +44,7 @@ typedef struct silencers {
SILENCER *silencers;
} SILENCERS;
-SILENCERS *silencers;
+extern SILENCERS *silencers;
extern SILENCER *create_silencer(void);
extern int health_silencers_json_read_callback(JSON_ENTRY *e);
diff --git a/web/api/web_api_v1.c b/web/api/web_api_v1.c
index aafcbc70be..4ac50524ad 100644
--- a/web/api/web_api_v1.c
+++ b/web/api/web_api_v1.c
@@ -2,6 +2,8 @@
#include "web_api_v1.h"
+char *api_secret;
+
static struct {
const char *name;
uint32_t hash;
diff --git a/web/api/web_api_v1.h b/web/api/web_api_v1.h
index 4fe3c8f6be..edeea98bed 100644
--- a/web/api/web_api_v1.h
+++ b/web/api/web_api_v1.h
@@ -29,6 +29,6 @@ extern void host_labels2json(RRDHOST *host, BUFFER *wb, size_t indentation);
extern void web_client_api_v1_init(void);
extern void web_client_api_v1_management_init(void);
-char *api_secret;
+extern char *api_secret;
#endif //NETDATA_WEB_API_V1_H