Split docker build script into build and publish - attempt small cleanups along the way (#5591)

* Refactor Travis CI docker image packaging process (preparatory step)

1) Split build and publish on two scripts
2) Update travis code to simply call both scripts wherever only build was called

Note: This is just an initial step to verify the implementation split.
There will be follow up commits to rework the implementation details

* Cleanup build process, first round

* Publish docker images: Slight refactor on input preparation and printed outputs

* Just like magic numbers are evil, manually settings the same path across the code is also dangerous - declare a WORKDIR and replace

* Use the single archs array for the loops, reference the desired ARCHs in one place

* Use MANIFEST_LIST for clarity

* Declare one docker command to use everywhere, to avoid confusion or misses

* From the way its used, seems like a temporary storage facility, make sure its cleaned up after we are done

* Add a bit more verbosity, plus a typo

* Attempt to run both scripts on the same step

* Do not call publish script within build stage, publish never ran there (to confirm with @paulfantom the details, couldnt track the workflow to justify)

* Cleanup comments as per feedback

* packaging/docker/publishing: indentation

* netdata/packaging/docker: Do not use gitignore to know whether you run on the top level directory of the repo

1) Remove check for .gitignore as its unstable
2) Use show top level and cdup to make sure you are under netdata and at the top level directory

This does not provide any functional change, it is only a more stable way of verifying we are running from TLD

* netdata/packaging/docker: Leave a comment for the next iteration

* netdata/packaging/docker: missed renamed of variable, sowwy

* netdata/packaging/docker: Use mktemp for temporary directory creation. Cleaner, safer

* netdata/packaging/travis: Make sure you get rid of the json file after completion

Just being cautious here, dont let any leftovers behind regardless the fact that this is an ephemeral host the process is running on

* netdata/packaging: make sure we dont break if the file is already removed

1 files changed, 1 insertions, 0 deletions

diff --git a/.travis/nightlies.sh b/.travis/nightlies.sh
index 74fc232779..740e569126 100755
--- a/.travis/nightlies.sh
+++ b/.travis/nightlies.sh
@@ -37,6 +37,7 @@ fi
 
 echo "--- BUILD & PUBLISH DOCKER IMAGES ---"
 packaging/docker/build.sh || BAD_THING_HAPPENED=1
+packaging/docker/publish.sh || BAD_THING_HAPPENED=1
 
 echo "--- BUILD ARTIFACTS ---"
 .travis/create_artifacts.sh || BAD_THING_HAPPENED=1