Switch nightlies to GitHub releases. (#14020)

* Switch nightlies to GitHub releases.

Instead of using GCS.

* Fix CI handling.

* Fix handling of download URLs for nightly builds.

* Fix handling of redirects for consolidated artifact checks.

* Avoid redirect issues with the test environment.

* Add more info to logs for updater checks.

* Ignore redirect issues for updater checks.

* Fix base URL handling in updater.

* Dump post-update info in CI before checking if the update worked.

* Special-case a version of `latest` in updater.

This is to allow CI to work correctly.

* Update nightly release badge in README.md.

* Fix updater check variable name.

* Add a comment documenting the magic number in parse_version.

2 files changed, 27 insertions, 8 deletions

diff --git a/.github/scripts/run-updater-check.sh b/.github/scripts/run-updater-check.sh
index 31ab71de80..aa6474bbf1 100755
--- a/.github/scripts/run-updater-check.sh
+++ b/.github/scripts/run-updater-check.sh
@@ -4,11 +4,20 @@ echo ">>> Installing CI support packages..."
 /netdata/.github/scripts/ci-support-pkgs.sh
 echo ">>> Installing Netdata..."
 /netdata/packaging/installer/kickstart.sh --dont-wait --build-only --disable-telemetry || exit 1
-echo "::group::Environment File Contents"
+echo "::group::>>> Pre-Update Environment File Contents"
 cat /etc/netdata/.environment
 echo "::endgroup::"
+echo "::group::>>> Pre-Update Netdata Build Info"
+netdata -W buildinfo
+echo "::endgroup::"
 echo ">>> Updating Netdata..."
-export NETDATA_NIGHTLIES_BASEURL="http://localhost:8080/artifacts/" # Pull the tarball from the local web server.
+export NETDATA_BASE_URL="http://localhost:8080/artifacts/" # Pull the tarball from the local web server.
 /netdata/packaging/installer/netdata-updater.sh --not-running-from-cron --no-updater-self-update || exit 1
+echo "::group::>>> Post-Update Environment File Contents"
+cat /etc/netdata/.environment
+echo "::endgroup::"
+echo "::group::>>> Post-Update Netdata Build Info"
+netdata -W buildinfo
+echo "::endgroup::"
 echo ">>> Checking if update was successful..."
 /netdata/.github/scripts/check-updater.sh || exit 1
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index e96c83fd98..92b03e7c39 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -417,10 +417,10 @@ jobs:
       - name: Prepare artifact directory
         id: prepare
         run: |
-          mkdir -p artifacts || exit 1
-          echo "9999.0.0-0" > artifacts/latest-version.txt || exit 1
-          cp dist-tarball/* artifacts || exit 1
-          cd artifacts || exit 1
+          mkdir -p artifacts/download/latest || exit 1
+          echo "9999.0.0-0" > artifacts/download/latest/latest-version.txt || exit 1
+          cp dist-tarball/* artifacts/download/latest || exit 1
+          cd artifacts/download/latest || exit 1
           ln -s ${{ needs.build-dist.outputs.distfile }} netdata-latest.tar.gz || exit 1
           sha256sum -b ./* > "sha256sums.txt" || exit 1
           cat sha256sums.txt
@@ -553,10 +553,15 @@ jobs:
         with:
           name: final-artifacts
           path: artifacts
+      - name: Prepare artifacts directory
+        id: prepare
+        run: |
+          mkdir -p download/latest
+          mv artifacts/* download/latest
       - name: Verify that artifacts work with installer
         id: verify
         env:
-          NETDATA_TARBALL_BASEURL: http://localhost:8080/artifacts
+          NETDATA_TARBALL_BASEURL: http://localhost:8080/
         run: packaging/installer/kickstart.sh --build-only --dont-start-it --disable-telemetry --dont-wait
       - name: Failure Notification
         uses: rtCamp/action-slack-notify@v2
@@ -602,10 +607,15 @@ jobs:
         with:
           name: final-artifacts
           path: artifacts
+      - name: Prepare artifacts directory
+        id: prepare
+        run: |
+          mkdir -p download/latest
+          mv artifacts/* download/latest
       - name: Verify that artifacts work with installer
         id: verify
         env:
-          NETDATA_TARBALL_BASEURL: http://localhost:8080/artifacts
+          NETDATA_TARBALL_BASEURL: http://localhost:8080/
         run: packaging/installer/kickstart.sh --static-only --dont-start-it --disable-telemetry
       - name: Failure Notification
         uses: rtCamp/action-slack-notify@v2