From a37a2c4d38acb642a9e7660cd0c924dc9dff801f Mon Sep 17 00:00:00 2001 From: Kevin McCarthy Date: Sun, 7 Jan 2018 12:12:42 -0800 Subject: Fix imap status count range check. The strtoul() call for parsing the STATUS count wasn't checking the range properly, because it was assigning to an unsigned int. Change to assign to a unsigned long, and also add the conversion check from mutt_atoui(). Thanks to Charles (@chdiza) for quickly noticing the problem! --- imap/command.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'imap') diff --git a/imap/command.c b/imap/command.c index c607fcad..46f07bb0 100644 --- a/imap/command.c +++ b/imap/command.c @@ -933,6 +933,7 @@ static void cmd_parse_status (IMAP_DATA* idata, char* s) char* value; BUFFY* inc; IMAP_MBOX mx; + unsigned long ulcount; unsigned int count; IMAP_STATUS *status; unsigned int olduv, oldun; @@ -977,12 +978,14 @@ static void cmd_parse_status (IMAP_DATA* idata, char* s) value = imap_next_word (s); errno = 0; - count = strtoul (value, &value, 10); - if (errno == ERANGE && count == ULONG_MAX) + ulcount = strtoul (value, &value, 10); + if ((errno == ERANGE && ulcount == ULONG_MAX) || + ((unsigned int) ulcount != ulcount)) { dprint (1, (debugfile, "Error parsing STATUS number\n")); return; } + count = (unsigned int) ulcount; if (!ascii_strncmp ("MESSAGES", s, 8)) { -- cgit v1.2.3