| Age | Commit message (Collapse) | Author |
|---|
|
Add spaces after if, else, while, for, switch.
Unify the brace placement style. The vast majority of the code uses
Allman style so convert the relatively few K&R braces over.
|
|
These are mostly automated changes corresponding to the emacs
settings:
(c-set-style "linux")
(setq c-basic-offset 2)
(c-set-offset 'case-label '+)
Most of the code follows the convention:
(add-to-list 'c-cleanup-list 'space-before-funcall)
but this is not enforced by this indentation cleanup.
Also, I personally dislike tabs, so I have:
(setq-default indent-tabs-mode nil)
in my own configuration. However I have no desire to change every line
just for that effect. So this cleanup does nothing about the mix issue.
Some of the secondary files (e.g. regex.c) have been skipped.
I've also skipped crypt-gpgme.c, because I need to think about that
file. Werner Koch and the GnuPG team contributed most it, and it
follows the Gnu indentation settings. It should probably be made
uniform with Mutt, but I don't want to discourage future GnuPG
contribution to the file.
I manually reverted a few unsightly cleanups, and added a few tweeks
when I saw things that could be improved.
|
|
The result of
find . -name "*.[ch]" -exec emacs -batch {} \
--eval="(progn (delete-trailing-whitespace) (and (buffer-modified-p) (save-buffer)))" \;
|
|
If mutt_sasl_client_new returns an error, the callers would ignore the
allocated saslconn resource from sasl_client_new. Be sure to release
these with sasl_dispose as documented in sasl.h. Likewise, let callers
(POP/IMAP) dispose the resource on their error paths. SMTP was already
taken care of. Found with LeakSanitizer in IMAP.
|
|
This will be used in the next commit to add a timeout when polling for
new mail.
|
|
SASL doesn't free the sasl_secret_t, so this was leaking. Instead,
keep our own pointer to it, and safe_realloc() each time.
sasl_secret_t doesn't need the data field null terminated, so memcpy
the password over.
|
|
After renaming all internal macros from M_* to MUTT_*, the
sys_socket.h workaround is no longer necessary.
|
|
Changeset 23334e967dd7 created a workaround for a namespace conflict
with Solaris and derivatives. After some discussion, the team decided
it would be best to move away from using the "M_" prefix for macros.
This patch was automatically generated by running:
perl -wpi -e 's/\bM_(\w+)\b/MUTT_$1/g' `find . -name '*.[ch]' -print`
with the exception that sys_socket.h was exempted. (That file will
be backed out subsequent to this commit.)
Thanks to Andras Salamon for supplying the perl script used to make
this change.
|
|
(closes #3833)
Solaris includes "sys/stream.h" inside their "sys/socket.h". This
include file adds many non-reserved macros to Mutt's namespace, two of
which conflict with existing Mutt macros.
The simplest fix would be to rename those macros in Mutt, however this
will cause difficulty with out-of-tree patches. This fix creates a
wrapper include file that preserves those existing macros and prevents
the Solaris values from entering Mutt's namespace.
|
|
Vincent Lefèvre pointed out the common shortcut, e.g 1996-9, is
actually not allowed for copyright years. Convert all the copyright
years (for mutt files) to use 4 digits.
|
|
This patch only updates existing copyright notices in the source
files, using commit dates since the last copyright update in commits
e3af935cdb1a and f8fd60d8d3f2.
Add a notice to the COPYRIGHT file to refer to our mercurial
repository for the full commit history.
Add myself to the COPYRIGHT file and smime_keys.pl file.
|
|
These were caused by assigning callback functions to the
sasl_callback_t.proc member. The callback type doesn't list any
parameters, because parameters vary by callback. The fix was simply
assigning a cast.
Cyrus-sasl2 has a sasl_callback_ft typedef that their sample code uses
for this purpose, but it is in a different header, saslplug.h, and
isn't in their 1.5 tree. Since this is probably not portable to other
implementations, I just added an equivalent cast.
|
|
|
|
|
|
|
|
Replaces [0a3de4d9a009]. See #3289.
|
|
|
|
Also zero out the account structure before filling it with available
data. Client certificates + SASL EXTERNAL were only working by luck.
|
|
|
|
The key must not be encrypted. Closes #2911.
|
|
non-fatal. Both are for tunnel support.
|
|
|
|
To use, set $smtp_url to the address of your smtp relay, in the form:
smtp[s]://[user[:password]@]host[:port]/
where port defaults to 25 for smtp and 465 for smtps.
You can also set $smtp_authenticators to control which methods mutt
will attempt to use during authentication. See $imap_authenticators
for details.
|
|
Also enable SASL plaintext: $foo_authenticators is a more general solution.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
($imap_user controls which user's mail gets accessed). Currently
this can't be specified interactively, since I can't think of a way
to do it that wouldn't annoy users where login == user (the default
value of $imap_login).
|
|
where standard open/close/read/write functions are implemented with macros.
Thanks to Aaron Crane and others for their input about the problem.
|
|
Remove it from mutt.h
|
|
|
|
we have some to send (#129961, upstream #1845)
|
|
authenticate itself. To use, set ssl_client_cert to the path to your
certificate file (containing both the certificate and the private
key). It works with the SASL EXTERNAL authentication mechanism, so
you'll need to have SASL enabled as well.
|
|
|
|
issues.
|
|
tries to connect to an imap server over ipv6 it stores the address
in a sockaddr which may not be large enough to hold the ipv6 address.
|
|
to Mads for the initial patch.
|
|
the SASL library, so they can't be allocated on the stack. This is
the case with both versions of the SASL library, and I frankly don't
understand why it hasn't caused problems before. Since it segfaults
reliably on OS X for me now, I thought a patch would be in order.
|
|
SASL library; all changes are ifdef'd so as not to break SASLv1
support. This includes a patch to configure.in to allow the choice
between v1 and v2, but someone with a better understanding of
autoconf should double-check it.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
and strdup routines. While we are on it, plug some memory leaks and
make some code understandable.
|
