| Age | Commit message (Collapse) | Author |
|---|
|
At least on Debian Linux, after invoking getopt() with argc==0, optind
seems to remain at the default value of 1.
mutt_dotlock was checking for optind==argc to report a missing
parameter, and would end up invoking the function with the first
environment variable instead.
mutt, pgpewrap, and mutt_pgpring were assuming argv[0] was non-null,
so just add a check and hardcode the value in that case to avoid a
possible segv.
mutt_pgpring allows no arguments. Its parameters to
pgpring_find_candidates() would pass the environment list and a
negative nhints in that case. The code seem to handle the case, but
set optind=argc to be clear about it.
|
|
This reverts commit 8970a4793c302c0bb8619a5dde56c8ca8de20532.
I didn't like making this nonsensical change, just to silence the
compiler. The last commit should turn off the warning for systems
with memccpy().
|
|
Thanks to Ian Collier for making this suggestion!
It's more efficient and disables unhelpful compiler warnings about
strncpy(), since strfcpy is terminating the string itself.
If memccpy() is unavailable, use strncpy() but keep the old behavior
of strncpy() length C instead of C-1, as I believe it tickles less
compiler warnings.
Add parenthesis around macro parameter uses, to be safe. Thanks to
Vincent Lefèvre for pointing that out.
|
|
|
|
The compiler is being a bit strange, only picking out and warning
about the 'strfcpy (d, pathptr, l);' line at the bottom of the
function, even though the source and dest are the same size.
It seems a shame to leave just this last one, since all the other
warnings (at least on Debian) have been vanquished.
So, to calm the compiler down, "russian doll" the buffer size down the
call stack "dotlock_dispatch() -> dotlock_prepare() ->
dotlock_deference_symlink()".
|
|
There was a period of time where C99 was standardized but some systems
still didn't include a correctly working version of those two
functions. But I think we are long past that point now.
Remove the checks and replacement code.
|
|
This reverts commit 317b7f6b53d8a4272acf8ef1b56f3406e9bc2691.
|
|
|
|
Switch to generating the version string during make process rather than
at configure time. This makes it easier to keep the detailed version
string accurate when doing development which doesn't require that the
configure script be rerun.
|
|
Add spaces after if, else, while, for, switch.
Unify the brace placement style. The vast majority of the code uses
Allman style so convert the relatively few K&R braces over.
|
|
These are mostly automated changes corresponding to the emacs
settings:
(c-set-style "linux")
(setq c-basic-offset 2)
(c-set-offset 'case-label '+)
Most of the code follows the convention:
(add-to-list 'c-cleanup-list 'space-before-funcall)
but this is not enforced by this indentation cleanup.
Also, I personally dislike tabs, so I have:
(setq-default indent-tabs-mode nil)
in my own configuration. However I have no desire to change every line
just for that effect. So this cleanup does nothing about the mix issue.
Some of the secondary files (e.g. regex.c) have been skipped.
I've also skipped crypt-gpgme.c, because I need to think about that
file. Werner Koch and the GnuPG team contributed most it, and it
follows the Gnu indentation settings. It should probably be made
uniform with Mutt, but I don't want to discourage future GnuPG
contribution to the file.
I manually reverted a few unsightly cleanups, and added a few tweeks
when I saw things that could be improved.
|
|
The result of
find . -name "*.[ch]" -exec emacs -batch {} \
--eval="(progn (delete-trailing-whitespace) (and (buffer-modified-p) (save-buffer)))" \;
|
|
If MUTT_VERSION contains a %, this will result in problems.
|
|
First of all, the MUTT_VERSION symbol is now concatenated (when
possible) at compile time.
Then, the logic to find the config file has been changed a bit to remove
unnecessary calls to access(), so now each possible locations for the
config file is only tested once, and it stops as soon as a valid one has
been found. So instead of:
access("/home/dkc/.muttrc-1.7.1", F_OK) = -1 ENOENT (No such file or directory)
access("/home/dkc/.muttrc", F_OK) = 0
access("/home/dkc/.muttrc", F_OK) = 0
access("/home/dkc/.muttrc", F_OK) = 0
[... Tests for Muttrc ... ]
access("/home/dkc/.muttrc", F_OK) = 0
We now have:
access("/home/dkc/.muttrc-1.7+13 (f658e517960e)", F_OK) = -1 ENOENT (No such file or directory)
access("/home/dkc/.muttrc", F_OK) = 0
It also cleans up the case where -F is passed on the command line but
points to a non-existent file by moving the error path closer to the
actual fail condition.
Finally, it adds partial support for the XDG Base Directory
Specification. mutt will now try to locate its config at:
$XDG_CONFIG_HOME/mutt/muttrc-MUTT_VERSION
$XDG_CONFIG_HOME/mutt/muttrc.
If XDG_CONFIG_HOME is not set, it will use '~/.config' as a default.
|
|
Restores [f1b4d1d17200] functionality with a slight change to keep
'make dist' working (see backout in [6b38124a5b81]).
Automake is too much voodoo for me at this time, so I let it keep
VERSION. mutt.h defined MUTT_VERSION as VERSION and the code used that,
so I removed MUTT_VERSION from mutt.h and put it into config.h via
configure.ac. A couple of tweaks were needed elsewhere. This restores
the fancy-versioning feature within mutt and keeps 'make dist' happy.
|
|
I went through the logs of each file with a copyright header and
updated the years for the authors in the headers for any non-comment
changes they introduced. What a pain!
|
|
|
|
|
|
|
|
|
|
|
|
Remove it from mutt.h
|
|
|
|
and strdup routines. While we are on it, plug some memory leaks and
make some code understandable.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
into mutt.
|
|
|
|
|
|
when merging changes.
|
|
|
|
place. If there are still segmentation faults due to missing
NONULLs over, they are gone now.
|
|
Perlman <perlman@linguist.dartmouth.edu>.
|
|
gcc shut up about this.
|
|
|
|
|
|
|
