Age | Commit message (Collapse) | Author |
|
The sample contrib program can use gpg to decrypt a token. This may
pop up a curses agent prompt, requiring a hard redraw.
It may be that we should be calling a hard redraw after any fork/exec.
I don't know if this will cause more problems, so for now I'll just
patch this one place. But that is something to consider.
|
|
The ssl and gnutls client-cert setup code was calling
mutt_account_getuser(). This caused two problems. First, it's not
necessarily the case that there will be a username. Second,
populating the user would cause smtp_open() to check for AUTH
capabilities and call smtp_auth - even if the user is already
authenticated by the cert. The server won't advertize AUTH if they
already authenticated, causing a connection abort.
Remove prompt for mutt_account_getuser() in the ssl and gnutls client
certificate connection code. The SASL code has callbacks, so I don't
understand why it would need this. Let's take it out and see if
anyone screams 8-P. If necessary, we can add a mutt_account_getuser()
call to the very beginning of imap_auth_sasl().
Revamp the openssl ssl_passwd_cb() prompt. From the man pages, it
appears to be used for the cert decryption. There's no need to call
mutt_account_getuser() and use the generic mutt_account_getpass() just
to read a password in. Instead create a callback function version to
customize the prompt for a client cert with just the host.
Change the SMTP authentication test to check if the AUTH capabilities
are set, instead of if the user field is set before calling
smtp_auth().
|
|
This still relies on an external script to obtain the resource access
token. Since XOAUTH2 should be slowly going away, use the same
refresh_commands as with OAUTHBEARER.
Unlike OAUTHBEARER, XOAUTH2 must be explicitly added to the
$imap/smtp/pop_authenticators list.
To keep the shared functions simpler, convert them to use buffers.
RFC 7628 indicates that upon authentication failure the clients should
be sending an BASE 64 encoded '^a' ("AQ=="), to terminate the SASL
session, so change all the handlers to do that and read the following
response. The RFC doesn't comment about a line terminator being
required, but I assume it is, so add that too.
|
|
These are mostly automated changes corresponding to the emacs
settings:
(c-set-style "linux")
(setq c-basic-offset 2)
(c-set-offset 'case-label '+)
Most of the code follows the convention:
(add-to-list 'c-cleanup-list 'space-before-funcall)
but this is not enforced by this indentation cleanup.
Also, I personally dislike tabs, so I have:
(setq-default indent-tabs-mode nil)
in my own configuration. However I have no desire to change every line
just for that effect. So this cleanup does nothing about the mix issue.
Some of the secondary files (e.g. regex.c) have been skipped.
I've also skipped crypt-gpgme.c, because I need to think about that
file. Werner Koch and the GnuPG team contributed most it, and it
follows the Gnu indentation settings. It should probably be made
uniform with Mutt, but I don't want to discourage future GnuPG
contribution to the file.
I manually reverted a few unsightly cleanups, and added a few tweeks
when I saw things that could be improved.
|
|
The result of
find . -name "*.[ch]" -exec emacs -batch {} \
--eval="(progn (delete-trailing-whitespace) (and (buffer-modified-p) (save-buffer)))" \;
|
|
Updating Japanese translation, I found that some of the updated messages
were a little hard to understand without reading the code.
Add comments to some messages I nearly translated in a wrong way.
|
|
Move token refresh commands to their own config variables. Consolidate
code for refreshing tokens and generating the SASL OAUTHBEARER
argument in account.c. Add support for OAUTHBEARER to pop.
Fix pop_auth_oauth() mutt_from_base64() call from 1.10.1 release.
|
|
Changeset 23334e967dd7 created a workaround for a namespace conflict
with Solaris and derivatives. After some discussion, the team decided
it would be best to move away from using the "M_" prefix for macros.
This patch was automatically generated by running:
perl -wpi -e 's/\bM_(\w+)\b/MUTT_$1/g' `find . -name '*.[ch]' -print`
with the exception that sys_socket.h was exempted. (That file will
be backed out subsequent to this commit.)
Thanks to Andras Salamon for supplying the perl script used to make
this change.
|
|
Vincent Lefèvre pointed out the common shortcut, e.g 1996-9, is
actually not allowed for copyright years. Convert all the copyright
years (for mutt files) to use 4 digits.
|
|
Replaces [0a3de4d9a009]. See #3289.
|
|
|
|
|
|
|
|
To use, set $smtp_url to the address of your smtp relay, in the form:
smtp[s]://[user[:password]@]host[:port]/
where port defaults to 25 for smtp and 465 for smtps.
You can also set $smtp_authenticators to control which methods mutt
will attempt to use during authentication. See $imap_authenticators
for details.
|
|
|
|
|
|
|
|
|
|
folder-hook push garbage)
|
|
getuser.
|
|
|
|
|
|
($imap_user controls which user's mail gets accessed). Currently
this can't be specified interactively, since I can't think of a way
to do it that wouldn't annoy users where login == user (the default
value of $imap_login).
|
|
Remove it from mutt.h
|
|
authentication (I'm not sure when this started). I believe this
patch should solve that problem in a reliable way.
This patch also attempts to reuse connections even when
authentication fails, instead of just throwing away a perfectly good
socket.
|
|
asking for passwords. This is a proper fix for bug 1312. I think
it's uncontroversial.
|
|
locale-independent and case-insensitive string comparisons. Needed
for mutt to work in iso-8859-9 environments, where tolower('I') !=
'i'.
|
|
|
|
|
|
|
|
|
|
Komulainen, and most likely based on input from Vsevolod Voykov
(sp?).
|