summaryrefslogtreecommitdiffstats
path: root/attach.c
diff options
context:
space:
mode:
authorKevin McCarthy <kevin@8t8.us>2019-06-22 12:54:40 -0700
committerKevin McCarthy <kevin@8t8.us>2019-06-22 12:54:40 -0700
commit03f6a9cbc825a43f2de96dde2f4556cdf98c0b4d (patch)
treee20a04771a6f272942a472191c382f90bd1f5bd9 /attach.c
parenta3d38b9e53ff3416a723ecec8299692b9104207e (diff)
Remove unnecessary strcmp for mutt_view_attachment().
mutt_rfc1524_expand_filename() runs the result through mutt_adv_mktemp(), which will sanitize and relocate the filename under $tmpdir. The strcmp() is unneeded and distracting to the program logic; none of the other routines perform or need this check.
Diffstat (limited to 'attach.c')
-rw-r--r--attach.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/attach.c b/attach.c
index 04a5610b..552a1767 100644
--- a/attach.c
+++ b/attach.c
@@ -415,7 +415,7 @@ int mutt_view_attachment (FILE *fp, BODY *a, int flag, HEADER *hdr,
if (mutt_rfc1524_expand_filename (entry->nametemplate, fname,
tempfile))
{
- if (fp == NULL && mutt_strcmp(mutt_b2s (tempfile), a->filename))
+ if (fp == NULL)
{
/* send case: the file is already there */
if (safe_symlink (a->filename, mutt_b2s (tempfile)) == -1)