Disable normalization after expand_path().

The algorithm used was incorrect, for '..' expansion with symlinks
involved.  Furthermore, mutt_pretty_mailbox() takes care of this for
us.

To be conservative, just before the release, I'm leaving the function
but converting it to a noop.  I'll pull the function out after the
release.

Thanks to Oswald Buddenhagen for pointing out the bug!

1 files changed, 10 insertions, 0 deletions

diff --git a/muttlib.c b/muttlib.c
index ce009fdb..4ef77897 100644
--- a/muttlib.c
+++ b/muttlib.c
@@ -411,6 +411,16 @@ static void buffer_normalize_fullpath (BUFFER *dest, const char *src)
   if (!src)
     return;
 
+  /* Disabling this for the 2.0 release.
+   * See Gitlab #290 - '..' can not be simplified in this manner.
+   * Furthermore, it looks like mutt_pretty_mailbox() calls realpath()
+   * if there are any '..' strings in the path, and does its own '.'
+   * normalization much more succinctly than this.  I'll remove this
+   * code after the release.
+   */
+  mutt_buffer_strcpy (dest, src);
+  return;
+
   if (*src != '/')
   {
     mutt_buffer_strcpy (dest, src);