1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
|
#include "track/serato/tags.h"
#include <mp3guessenc.h>
#include "sources/soundsourceproxy.h"
#if defined(__COREAUDIO__)
#include "sources/soundsourcecoreaudio.h"
#endif
#if defined(__FFMPEG__)
#include "sources/soundsourceffmpeg.h"
#endif
#if defined(__MAD__)
#include "sources/soundsourcemp3.h"
#endif
#include "track/serato/beatsimporter.h"
#include "track/serato/cueinfoimporter.h"
#include "track/taglib/trackmetadata_file.h"
#include "util/color/predefinedcolorpalettes.h"
namespace {
QString getPrimaryDecoderNameForFilePath(const QString& filePath) {
const QString fileExtension =
mixxx::SoundSource::getFileExtensionFromUrl(QUrl::fromLocalFile(filePath));
const mixxx::SoundSourceProviderPointer pPrimaryProvider =
SoundSourceProxy::getPrimaryProviderForFileExtension(fileExtension);
QString decoderName;
if (pPrimaryProvider) {
return pPrimaryProvider->getDisplayName();
} else {
return QString(); // unknown
}
}
/// In Serato, loops and hotcues are kept separate, i. e. you can
/// have a loop and a hotcue with the same number. In Mixxx, loops
/// and hotcues share indices. Hence, we import them with an offset
/// of 8 (the maximum number of hotcues in Serato).
constexpr int kLoopIndexOffset = 8;
constexpr int kNumCuesInMarkersTag = 5;
mixxx::RgbColor getColorFromOtherPalette(
const ColorPalette& source,
const ColorPalette& dest,
mixxx::RgbColor color) {
DEBUG_ASSERT(source.size() == dest.size());
int sourceIndex = source.indexOf(color);
if (sourceIndex >= 0 && sourceIndex < dest.size()) {
return dest.at(sourceIndex);
}
return color;
}
std::optional<int> findIndexForCueInfo(const mixxx::CueInfo& cueInfo) {
VERIFY_OR_DEBUG_ASSERT(cueInfo.getHotCueNumber()) {
qWarning() << "SeratoTags::getCues: Cue without number found!";
return std::nullopt;
}
int index = *cueInfo.getHotCueNumber();
VERIFY_OR_DEBUG_ASSERT(index >= 0) {
qWarning() << "SeratoTags::getCues: Cue with number < 0 found!";
return std::nullopt;
}
switch (cueInfo.getType()) {
case mixxx::CueType::HotCue:
if (index >= kLoopIndexOffset) {
qWarning()
<< "SeratoTags::getCues: Non-loop Cue with number >="
<< kLoopIndexOffset << "found!";
return std::nullopt;
}
break;
case mixxx::CueType::Loop:
index += kLoopIndexOffset;
break;
default:
return std::nullopt;
}
return index;
}
} // namespace
namespace mixxx {
/// Serato stores Track colors differently from how they are displayed in
/// the library column. Instead of the color from the library view, the
/// value from the color picker is stored instead (which is different).
/// To make sure that the track looks the same in both Mixxx' and Serato's
/// libraries, we need to convert between the two values.
///
/// See this for details:
/// https://github.com/Holzhaus/serato-tags/blob/master/docs/colors.md#track-colors
RgbColor::optional_t SeratoTags::storedToDisplayedTrackColor(RgbColor color) {
if (color == 0xFFFFFF) {
return RgbColor::nullopt();
}
if (color == 0x999999) {
return RgbColor::optional(0x090909);
}
if (color == 0x000000) {
return RgbColor::optional(0x333333);
}
RgbColor::code_t colorCode = color;
colorCode = (colorCode < 0x666666) ? colorCode + 0x99999A : colorCode - 0x666666;
return RgbColor::optional(colorCode);
}
RgbColor SeratoTags::displayedToStoredTrackColor(RgbColor::optional_t color) {
if (!color) {
return RgbColor(0xFFFFFF);
}
RgbColor::code_t colorCode = *color;
if (colorCode == 0x090909) {
return RgbColor(0x999999);
}
if (colorCode == 0x333333) {
return RgbColor(0x000000);
}
// Special case: 0x999999 and 0x99999a are not representable as Serato
// track color We'll just modify them a little, so that the look the
// same in Serato.
if (colorCode == 0x999999) {
return RgbColor(0x999998);
}
if (colorCode == 0x99999a) {
return RgbColor(0x99999b);
}
colorCode = (colorCode < 0x99999A) ? colorCode + 0x666666 : colorCode - 0x99999A;
return RgbColor(colorCode);
}
RgbColor SeratoTags::storedToDisplayedSeratoDJProCueColor(RgbColor color) {
return getColorFromOtherPalette(
PredefinedColorPalettes::kSeratoTrackMetadataHotcueColorPalette,
PredefinedColorPalettes::kSeratoDJProHotcueColorPalette,
color);
}
RgbColor SeratoTags::displayedToStoredSeratoDJProCueColor(RgbColor color) {
return getColorFromOtherPalette(
PredefinedColorPalettes::kSeratoDJProHotcueColorPalette,
PredefinedColorPalettes::kSeratoTrackMetadataHotcueColorPalette,
color);
}
double SeratoTags::guessTimingOffsetMillis(
const QString& filePath,
const audio::SignalInfo& signalInfo) {
// The following code accounts for timing offsets required to
// correctly align timing information (e.g. cue points) exported from
// Serato. This is caused by different MP3 decoders treating MP3s encoded
// in a variety of different cases differently. The mp3guessenc library is
// used to determine which case the MP3 is classified in. See the following
// PR for more detailed information:
// https://github.com/mixxxdj/mixxx/pull/2119
double timingOffset = 0;
if (taglib::getFileTypeFromFileName(filePath) == taglib::FileType::MP3) {
const QString primaryDecoderName =
getPrimaryDecoderNameForFilePath(filePath);
// There should always be an MP3 decoder available
VERIFY_OR_DEBUG_ASSERT(!primaryDecoderName.isEmpty()) {
return 0;
}
bool timingOffsetGuessed = false;
#if defined(__COREAUDIO__)
if (primaryDecoderName == mixxx::SoundSourceProviderCoreAudio::kDisplayName) {
DEBUG_ASSERT(!timingOffsetGuessed);
DEBUG_ASSERT(timingOffset == 0);
Q_UNUSED(signalInfo)
int timingShiftCase = mp3guessenc_timing_shift_case(filePath.toStdString().c_str());
// TODO: Find missing timing offsets
switch (timingShiftCase) {
case EXIT_CODE_CASE_A:
timingOffset = -12;
timingOffsetGuessed = true;
break;
case EXIT_CODE_CASE_B:
timingOffset = -40;
timingOffsetGuessed = true;
break;
case EXIT_CODE_CASE_C:
case EXIT_CODE_CASE_D:
timingOffset = -60;
timingOffsetGuessed = true;
break;
}
}
#endif
#if defined(__MAD__) || defined(__FFMPEG__)
bool usingMadOrFFmpeg = false;
#if defined(__MAD__)
if (primaryDecoderName == mixxx::SoundSourceProviderMp3::kDisplayName) {
DEBUG_ASSERT(!usingMadOrFFmpeg);
usingMadOrFFmpeg = true;
}
#endif
#if defined(__FFMPEG__)
if (primaryDecoderName == mixxx::SoundSourceProviderFFmpeg::kDisplayName) {
DEBUG_ASSERT(!usingMadOrFFmpeg);
usingMadOrFFmpeg = true;
}
#endif
if (usingMadOrFFmpeg) {
DEBUG_ASSERT(!timingOffsetGuessed);
DEBUG_ASSERT(timingOffset == 0);
switch (signalInfo.getSampleRate()) {
case 48000:
timingOffset = -24;
timingOffsetGuessed = true;
break;
case 44100:
// This is an estimate and tracks will vary unpredictably within ~1 ms
timingOffset = -26;
timingOffsetGuessed = true;
break;
default:
qWarning()
<< "Unknown timing offset for Serato tags with sample rate"
<< signalInfo.getSampleRate();
}
}
#endif
if (timingOffsetGuessed) {
qDebug()
<< "Detected timing offset"
<< timingOffset
<< "using"
<< primaryDecoderName
<< "for MP3 file"
<< filePath;
} else {
qDebug()
<< "Unknown timing offset"
<< timingOffset
<< "using"
<< primaryDecoderName
<< "for MP3 file"
<< filePath;
}
}
return timingOffset;
}
BeatsImporterPointer SeratoTags::importBeats() const {
if (m_seratoBeatGrid.isEmpty() || !m_seratoBeatGrid.terminalMarker()) {
return std::make_shared<SeratoBeatsImporter>();
}
return std::make_shared<SeratoBeatsImporter>(
m_serat
|