From 4e1bebf0f5e06ecdd99c41771e7b4ee19c0cdcf3 Mon Sep 17 00:00:00 2001 From: Jan Holthuis Date: Tue, 17 Nov 2020 20:02:14 +0100 Subject: Pass non-trivial/large function args by reference Fixes a bunch of `-Wclazy-function-args-by-ref` warnings. See https://github.com/KDE/clazy/blob/master/docs/checks/README-function-args-by-ref.md for details. Most of these changes are automated, using the clazy fixit by setting the `CLAZY_EXPORT_FIXES` before compilation and then running: $ mkdir /tmp/patch $ find ../src -iname "*.yaml" -exec mv {} /tmp/patch \; $ clang-apply-replacements /tmp/patch --- src/library/dlganalysis.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/library/dlganalysis.cpp') diff --git a/src/library/dlganalysis.cpp b/src/library/dlganalysis.cpp index a3f9a1bf34..a75c41255f 100644 --- a/src/library/dlganalysis.cpp +++ b/src/library/dlganalysis.cpp @@ -116,7 +116,7 @@ void DlgAnalysis::loadSelectedTrack() { m_pAnalysisLibraryTableView->loadSelectedTrack(); } -void DlgAnalysis::loadSelectedTrackToGroup(QString group, bool play) { +void DlgAnalysis::loadSelectedTrackToGroup(const QString& group, bool play) { m_pAnalysisLibraryTableView->loadSelectedTrackToGroup(group, play); } -- cgit v1.2.3