From 37b6bd48211c75068464a7b30458e50ee3d15b88 Mon Sep 17 00:00:00 2001 From: Marcos CARDINOT Date: Sun, 1 Jun 2014 12:20:06 +0100 Subject: Improving string concatenation/construction into coverart class - using QStringBuilder instead using '.append' or '+' --- src/library/coverart.cpp | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) (limited to 'src/library/coverart.cpp') diff --git a/src/library/coverart.cpp b/src/library/coverart.cpp index c142450f9e..65a7e04894 100644 --- a/src/library/coverart.cpp +++ b/src/library/coverart.cpp @@ -1,3 +1,5 @@ +#include + #include "library/coverart.h" CoverArt::CoverArt() @@ -18,9 +20,7 @@ void CoverArt::setConfig(ConfigObject* pConfig) { } QString CoverArt::getStoragePath() const { - QString settingsPath = m_pConfig->getSettingsPath(); - QDir dir(settingsPath.append("/coverArt/")); - return dir.absolutePath().append("/"); + return m_pConfig->getSettingsPath() % "/coverArt/"; } bool CoverArt::deleteFile(const QString& location) { @@ -51,9 +51,7 @@ QString CoverArt::searchInTrackDirectory(QString directory) { QString coverLocation; QStringList imglist = dir.entryList(); if (imglist.size() > 0) { - coverLocation = directory; - coverLocation.append("/"); - coverLocation.append(imglist[0]); + coverLocation = directory % "/" % imglist[0]; } return coverLocation; @@ -65,12 +63,12 @@ QString CoverArt::getDefaultCoverName(QString artist, if (artist.isEmpty() && album.isEmpty()) { return filename; } else { - return artist + " - " + album; + return artist % " - " % album; } } QString CoverArt::getDefaultCoverLocation(QString coverArtName) { - return getStoragePath() + coverArtName + "." + m_cDefaultImageFormat; + return getStoragePath() % coverArtName % "." % m_cDefaultImageFormat; } QString CoverArt::getDefaultCoverLocation(TrackPointer pTrack) { -- cgit v1.2.3