From 4e1bebf0f5e06ecdd99c41771e7b4ee19c0cdcf3 Mon Sep 17 00:00:00 2001 From: Jan Holthuis Date: Tue, 17 Nov 2020 20:02:14 +0100 Subject: Pass non-trivial/large function args by reference Fixes a bunch of `-Wclazy-function-args-by-ref` warnings. See https://github.com/KDE/clazy/blob/master/docs/checks/README-function-args-by-ref.md for details. Most of these changes are automated, using the clazy fixit by setting the `CLAZY_EXPORT_FIXES` before compilation and then running: $ mkdir /tmp/patch $ find ../src -iname "*.yaml" -exec mv {} /tmp/patch \; $ clang-apply-replacements /tmp/patch --- src/encoder/encoderopussettings.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/encoder/encoderopussettings.h') diff --git a/src/encoder/encoderopussettings.h b/src/encoder/encoderopussettings.h index 0d6e46041b..0b03d90963 100644 --- a/src/encoder/encoderopussettings.h +++ b/src/encoder/encoderopussettings.h @@ -34,10 +34,10 @@ class EncoderOpusSettings: public EncoderRecordingSettings { QList getOptionGroups() const override; // Selects the option by its index. If it is a single-element option, // index 0 means disabled and 1 enabled. - void setGroupOption(QString groupCode, int optionIndex) override; + void setGroupOption(const QString& groupCode, int optionIndex) override; // Return the selected option of the group. If it is a single-element option, // 0 means disabled and 1 enabled. - int getSelectedOption(QString groupCode) const override; + int getSelectedOption(const QString& groupCode) const override; // Returns the format of this encoder settings. QString getFormat() const override { -- cgit v1.2.3