From 89c951158c58296e21c8720ea336b8ea0523fd1a Mon Sep 17 00:00:00 2001 From: "Sean M. Pappalardo" Date: Mon, 21 May 2018 08:28:22 -0700 Subject: Address code review notes. --- res/controllers/American-Audio-VMS4-scripts.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'res/controllers/American-Audio-VMS4-scripts.js') diff --git a/res/controllers/American-Audio-VMS4-scripts.js b/res/controllers/American-Audio-VMS4-scripts.js index 0a001a77dc..ab7cd72d0d 100644 --- a/res/controllers/American-Audio-VMS4-scripts.js +++ b/res/controllers/American-Audio-VMS4-scripts.js @@ -326,9 +326,7 @@ VMS4.effectSelect = function(channel, control, value, status, group) { VMS4.effectSelectPress = function(channel, control, value, status, group) { var deckNum = VMS4.GetDeckNum(group); if (value > 0x40) { - engine.setValue("[EffectRack1_EffectUnit"+deckNum+"_Effect1]","enabled", - !engine.getValue("[EffectRack1_EffectUnit"+deckNum+"_Effect1]","enabled") - ); + script.toggleControl("[EffectRack1_EffectUnit"+deckNum+"_Effect1]","enabled"); } } @@ -416,7 +414,7 @@ VMS4.strip_touch = function(channel, control, value, status, group) { VMS4.strip_scroll = function(channel, control, value, status, group) { var side = VMS4.StripToSide[control]; - if (VMS4.touchStripPos[side] != null) { + if (VMS4.touchStripPos[side] !== null) { // Higher on the strip gives a higher value, and up is negative on Library // scroll controls if (side === "Left") { -- cgit v1.2.3