From aca5ea417c3af006c89378fe241f8988841382c4 Mon Sep 17 00:00:00 2001 From: Uwe Klotz Date: Fri, 6 Nov 2020 10:58:52 +0100 Subject: CMake: Replace hard-coded install dirs with GNUInstallDirs https://bugzilla.rpmfusion.org/show_bug.cgi?id=5830 --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'CMakeLists.txt') diff --git a/CMakeLists.txt b/CMakeLists.txt index 9d50d5d351..55711b188e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1016,9 +1016,9 @@ elseif(UNIX) else() target_compile_definitions(mixxx-lib PRIVATE __UNIX__) target_compile_definitions( - mixxx-lib PUBLIC UNIX_SHARE_PATH="${CMAKE_INSTALL_PREFIX}/share/mixxx") + mixxx-lib PUBLIC UNIX_SHARE_PATH="${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_DATAROOTDIR}/mixxx") target_compile_definitions( - mixxx-lib PUBLIC UNIX_LIB_PATH="${CMAKE_INSTALL_PREFIX}/lib/mixxx") + mixxx-lib PUBLIC UNIX_LIB_PATH="${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}/mixxx") if(CMAKE_SYSTEM_NAME STREQUAL Linux) target_compile_definitions(mixxx-lib PUBLIC __LINUX__) elseif(CMAKE_SYSTEM_NAME MATCHES "^.*BSD$") -- cgit v1.2.3 From fd7a945fec94fc2235f5b45ed2c0e1c8b585a85e Mon Sep 17 00:00:00 2001 From: Uwe Klotz Date: Fri, 6 Nov 2020 16:13:24 +0100 Subject: Delete unused compile definition UNIX_LIB_PATH --- CMakeLists.txt | 2 -- 1 file changed, 2 deletions(-) (limited to 'CMakeLists.txt') diff --git a/CMakeLists.txt b/CMakeLists.txt index 55711b188e..855bb663ed 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1017,8 +1017,6 @@ elseif(UNIX) target_compile_definitions(mixxx-lib PRIVATE __UNIX__) target_compile_definitions( mixxx-lib PUBLIC UNIX_SHARE_PATH="${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_DATAROOTDIR}/mixxx") - target_compile_definitions( - mixxx-lib PUBLIC UNIX_LIB_PATH="${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}/mixxx") if(CMAKE_SYSTEM_NAME STREQUAL Linux) target_compile_definitions(mixxx-lib PUBLIC __LINUX__) elseif(CMAKE_SYSTEM_NAME MATCHES "^.*BSD$") -- cgit v1.2.3 From 1122ae87ef9a085ed705a6a8761c6c7ad0f5dce3 Mon Sep 17 00:00:00 2001 From: Uwe Klotz Date: Fri, 6 Nov 2020 16:21:43 +0100 Subject: CMake: Reuse MIXXX_INSTALL_DATADIR for UNIX_SHARE_PATH --- CMakeLists.txt | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) (limited to 'CMakeLists.txt') diff --git a/CMakeLists.txt b/CMakeLists.txt index 855bb663ed..51a1aaf1f5 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -978,6 +978,21 @@ target_compile_definitions(mixxx-lib PUBLIC $<$>:NDEBUG> ) +# +# Installation directories +# +set(MIXXX_INSTALL_BINDIR ".") +set(MIXXX_INSTALL_DATADIR ".") +set(MIXXX_INSTALL_DOCDIR "./doc") +set(MIXXX_INSTALL_LICENSEDIR "./doc") +if (UNIX) + include(GNUInstallDirs) + set(MIXXX_INSTALL_BINDIR "${CMAKE_INSTALL_BINDIR}") + set(MIXXX_INSTALL_DATADIR "${CMAKE_INSTALL_DATADIR}/mixxx") + set(MIXXX_INSTALL_DOCDIR "${CMAKE_INSTALL_DOCDIR}/mixxx") + set(MIXXX_INSTALL_LICENSEDIR "${CMAKE_INSTALL_DATADIR}/licenses/mixxx") +endif() + if(WIN32) target_compile_definitions(mixxx-lib PRIVATE __WINDOWS__) @@ -1016,7 +1031,7 @@ elseif(UNIX) else() target_compile_definitions(mixxx-lib PRIVATE __UNIX__) target_compile_definitions( - mixxx-lib PUBLIC UNIX_SHARE_PATH="${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_DATAROOTDIR}/mixxx") + mixxx-lib PUBLIC UNIX_SHARE_PATH="${MIXXX_INSTALL_DATADIR}") if(CMAKE_SYSTEM_NAME STREQUAL Linux) target_compile_definitions(mixxx-lib PUBLIC __LINUX__) elseif(CMAKE_SYSTEM_NAME MATCHES "^.*BSD$") @@ -1033,18 +1048,6 @@ target_link_libraries(mixxx PUBLIC mixxx-lib) # Installation and Packaging # include(InstallRequiredSystemLibraries) -set(MIXXX_INSTALL_BINDIR ".") -set(MIXXX_INSTALL_DATADIR ".") -set(MIXXX_INSTALL_DOCDIR "./doc") -set(MIXXX_INSTALL_LICENSEDIR "./doc") -if (UNIX) - include(GNUInstallDirs) - set(MIXXX_INSTALL_BINDIR "${CMAKE_INSTALL_BINDIR}") - set(MIXXX_INSTALL_DATADIR "${CMAKE_INSTALL_DATADIR}/mixxx") - set(MIXXX_INSTALL_DOCDIR "${CMAKE_INSTALL_DOCDIR}/mixxx") - set(MIXXX_INSTALL_LICENSEDIR "${CMAKE_INSTALL_DATADIR}/licenses/mixxx") -endif() - install( TARGETS mixxx -- cgit v1.2.3