From d0a8e026756df8fc505bad3c72335273d46be569 Mon Sep 17 00:00:00 2001 From: Uwe Klotz Date: Sat, 17 Apr 2021 12:51:55 +0200 Subject: CMake: Add comments why we need URL downloads of external projects (#3779) CMake: Add comments why we need URL downloads of external projects https://github.com/mixxxdj/mixxx/pull/3779 --- CMakeLists.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 20df0db02c..c368e69665 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1722,6 +1722,8 @@ if(ENGINEPRIME) set(DJINTEROP_INSTALL_DIR "${CMAKE_CURRENT_BINARY_DIR}/lib/libdjinterop-install") set(DJINTEROP_LIBRARY "lib/${CMAKE_STATIC_LIBRARY_PREFIX}djinterop${CMAKE_STATIC_LIBRARY_SUFFIX}") file(MAKE_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/download") + # External project sources must be downloaded as an archive into DOWNLOAD_DIR + # from an URL to keep offline builds like for Fedora/RPM Fusion working! ExternalProject_Add(libdjinterop URL "https://github.com/xsco/libdjinterop/archive/0.15.1.tar.gz" URL_HASH SHA256=87b3e6c726c208333d55b7e7e3af0a7230c9ad9edb3ca0ca81feffe17b3fc008 @@ -1829,6 +1831,8 @@ if(KEYFINDER) set(KeyFinder_INSTALL_DIR "${CMAKE_CURRENT_BINARY_DIR}/lib/keyfinder-install") set(KeyFinder_LIBRARY "${CMAKE_INSTALL_LIBDIR}/${CMAKE_STATIC_LIBRARY_PREFIX}keyfinder${CMAKE_STATIC_LIBRARY_SUFFIX}") file(MAKE_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/download") + # External project sources must be downloaded as an archive into DOWNLOAD_DIR + # from an URL to keep offline builds like for Fedora/RPM Fusion working! ExternalProject_Add(libkeyfinder URL "https://github.com/mixxxdj/libkeyfinder/archive/v2.2.4.zip" URL_HASH SHA256=cb3fea8c7213257281b6c7006b2430809f466ad8a1d485663324378d6fc0782c -- cgit v1.2.3