From 5338b2cfc5812ffc6105790cd0d664e40fc9b115 Mon Sep 17 00:00:00 2001 From: Uwe Klotz Date: Sun, 22 Nov 2020 21:16:26 +0100 Subject: GitHub CI: Don't abort clazy build on errors --- .github/workflows/clazy.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to '.github') diff --git a/.github/workflows/clazy.yml b/.github/workflows/clazy.yml index 8c5a08c1f3..59a5cb444e 100644 --- a/.github/workflows/clazy.yml +++ b/.github/workflows/clazy.yml @@ -50,9 +50,11 @@ jobs: - name: Create build directory run: mkdir cmake_build - name: Configure - # Disable optimizations as workaround for Clang 9 bug: https://bugs.llvm.org/show_bug.cgi?id=45034 + # -DOPTIMIZE=off: Disable optimizations as workaround for Clang 9 bug: https://bugs.llvm.org/show_bug.cgi?id=45034 + # -ferror-limit=0: Disable aborting on errors run: | cmake \ + -DCMAKE_CXX_FLAGS="-ferror-limit=0" \ -DCMAKE_BUILD_TYPE=Debug \ -DWARNINGS_FATAL=ON \ -DOPTIMIZE=off \ -- cgit v1.2.3 From af5ed092f1ab16ba4c9a0ff8b76766e3805f620c Mon Sep 17 00:00:00 2001 From: Uwe Klotz Date: Mon, 23 Nov 2020 01:21:22 +0100 Subject: Revert "GitHub CI: Don't abort clazy build on errors" This reverts commit 5338b2cfc5812ffc6105790cd0d664e40fc9b115. --- .github/workflows/clazy.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to '.github') diff --git a/.github/workflows/clazy.yml b/.github/workflows/clazy.yml index 59a5cb444e..8c5a08c1f3 100644 --- a/.github/workflows/clazy.yml +++ b/.github/workflows/clazy.yml @@ -50,11 +50,9 @@ jobs: - name: Create build directory run: mkdir cmake_build - name: Configure - # -DOPTIMIZE=off: Disable optimizations as workaround for Clang 9 bug: https://bugs.llvm.org/show_bug.cgi?id=45034 - # -ferror-limit=0: Disable aborting on errors + # Disable optimizations as workaround for Clang 9 bug: https://bugs.llvm.org/show_bug.cgi?id=45034 run: | cmake \ - -DCMAKE_CXX_FLAGS="-ferror-limit=0" \ -DCMAKE_BUILD_TYPE=Debug \ -DWARNINGS_FATAL=ON \ -DOPTIMIZE=off \ -- cgit v1.2.3 From 7211bd4b8e1531f9f35e8f32d8d6e549eae6189d Mon Sep 17 00:00:00 2001 From: Uwe Klotz Date: Mon, 23 Nov 2020 01:23:09 +0100 Subject: GitHub CI: Don't abort clazy build on errors (2nd attempt) --- .github/workflows/clazy.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to '.github') diff --git a/.github/workflows/clazy.yml b/.github/workflows/clazy.yml index 8c5a08c1f3..59ea855cd0 100644 --- a/.github/workflows/clazy.yml +++ b/.github/workflows/clazy.yml @@ -79,7 +79,8 @@ jobs: - name: Set up problem matcher uses: ammaraskar/gcc-problem-matcher@master - name: Build - run: cmake --build . -j $(nproc) + # Do not abort on errors and build/check the whole project + run: cmake --build . -j $(nproc) -- --keep-going working-directory: cmake_build env: CLAZY_CHECKS: level2,no-rule-of-two-soft,no-non-pod-global-static,no-qproperty-without-notify,no-wrong-qevent-cast,no-qstring-allocations,no-function-args-by-value,no-copyable-polymorphic,no-ctor-missing-parent-argument,no-missing-qobject-macro,no-rule-of-three,no-returning-void-expression,no-missing-typeinfo,no-base-class-event -- cgit v1.2.3