| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Fixes a bunch of `-Wclazy-function-args-by-ref` warnings. See
https://github.com/KDE/clazy/blob/master/docs/checks/README-function-args-by-ref.md
for details.
Most of these changes are automated, using the clazy fixit by setting
the `CLAZY_EXPORT_FIXES` before compilation and then running:
$ mkdir /tmp/patch
$ find ../src -iname "*.yaml" -exec mv {} /tmp/patch \;
$ clang-apply-replacements /tmp/patch
|
|
|
|
|
|
|
|
|
|
event in other widgets.
|
|
|
|
|
|
|
|
|
|
This code was duplicated in a number of classes, now they all call a
helper funciton that implements the logic. I attempted doing this with
inhertiance, but I couldn't work around QWidget being inherited multiple
times. This solution works just as well for eliminating code
duplication.
|
|
Instead of just loading the track that was dragged and dropped, clone
the play state, play position, pitch/rate, and key.
|
|
|
|
* let DlgCoverArtFullSize have a border
* set DlgCoverArtFullSize window title to "Album Artist - Album (Year)"
(or Album instead of Album Artist if there is no Album Artist)
* let DlgCoverArtFullSize be resized either by dragging the window
border or using a mouse scroll wheel
* update DlgCoverArtFullSize when cover art is changed
* update DlgCoverArtFullSize when track is reloaded
* show WCoverArtMenu on right click of DlgCoverArtFullSize
* show WCoverArtMenu on right click of WSpinny when the track does not
have cover art set
* update WSpinny tooltip
* don't hide DlgCoverArtFullSize when moving mouse off of WCoverArtLabel
|
|
|
|
usless or redundant info.
|
|
|
|
|
|
At long last! Also move trackinfoobject.h/cpp to src/track/track.h/cpp.
|
|
Using LLVM 3.8.0:
$ clang-tidy --fix --checks="*,-llvm-header-guard,-readability-implicit-bool-cast,-readability-else-after-return,-google-readability-todo" $(git ls src/widget | xargs) -- (flags to compile)
|
|
with track load failures
|
|
This will allow us to experiment with different implementations for
structured user preferences. It will also reduce repeated typing of
template arguments and better represent the purpose of the object.
|
|
|
|
* Adds CoverArtCache::guessCover(s) methods for calling
CoverArtUtils::guessCoverArt in a background thread.
* Removes processing of reset menu option from WCoverArtMenu and instead
sends a signal that the owner of the menu should handle.
|
|
* Add a request reference integer to CoverArtCache::requestCover.
Use (pRequestor, requestReference) for de-duping requests instead of
trackId.
|
|
* Provide a QObject* requestor pointer when calling requestCover. In
practice this can be any number you want it to but it is particularly
useful for the requestor class to pass a pointer to itself so it can
compare the signal it gets to itself.
* Provide the original CoverInfo request.
|
|
Listen to the signal in WCoverArt.
|
|
DlgTrackInfo.
* Remove copying of changed cover art into the folder (temporarily?).
* Mark all user-generated change events as USER_SELECTED.
* Remove reliance on CoverInfo::trackId in a couple places.
|
|
|
|
* Communicate selected track instead of cover art.
* Support connecting a WCoverArt to the track currently loaded to a deck.
|
|
Add <DefaultCover> configuration option to WCoverArt to let skin authors
pick a default cover.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
dlgfullsize)
|
|
|
|
|
|
- it ensures the correct initial height when the user changes the skin
|
|
|
|
This makes it easy now to send additional things around by just updating
the CoverInfo struct.
|
|
|
|
We want that changes to the cover in dlgtrackinfo behave similar to
changing other values of the track. This required me to rework how
WCoverArtMenu works. WCoverArtMenu is now only a common menu that DOES
NOT CHANGE the database instead the widget implementing the menu does
this now when it sees fit. Another important change to make this work is
that 'CoverArtCache::searchImage' can now be called from any class
without the need use 'requestCover'. This is necessary to reload the
cover from the ID3tags/folder without updating the DB. This is ok in
this case because we only search for 1 cover and we will only block the
UI thread for a fraction of a second. I also think this is ok in this
special case because changing covers won't happen very often and a user
will to this one track at a time anyway, while the normal cover display
requires us to provides covers for several tracks simultaneously.
|
|
|
