Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
QGLWidget documentation says:
The initialization of OpenGL rendering state, etc. should be done by overriding
the initializeGL() function, rather than in the constructor of your QGLWidget
subclass.
Calling QOpenGLFunctions_2_1::initializeOpenGLFunctions in the QGLWidget
constructors crashed on macOS:
https://bugs.launchpad.net/mixxx/+bug/1877487
I am surprised it did not crash on Linux and Windows.
The calls to makeCurrent in the QGLWidget constructors were futile; that
does nothing before Qt calls QGLWidget::initializeGL. This can be verified
by adding:
qDebug() << "Context current" << (QGLContext::currentContext() == context());
after the call to makeCurrent.
|
|
|
|
...to reduce compile time dependencies
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
... when zoomed at 100% with playback rate < 1.0x
|
|
|
|
|
|
|
|
* Use const shared pointers for waveforms.
* Move all std::vector sizing operations to the Waveform constructor. No
vector state is allowed to change after the constructor finishes.
* Clarify comments.
* Remove waveform mutex usage in WOverview variants.
* Use the track's waveform pointer to atomically swap the waveform
rather than mutating the waveform in place.
* Remove unused code.
|
|
* Fix compiler warnings in non-3rd-party code.
* Add some missing const-references.
* Eliminate cases of "if(" "( ... )" and "for(".
|
|
* Delete mathstuff.h and defs.h.
* Move typedefs into util/types.h.
* Move definitions into util/defs.h.
* Use std::min and std::max for math_min and math_max.
* Replace math_clamp with a template function to prevent repeated sub-expressions.
* Add a Result enum for SoundSource::open() and SoundSource::parseHeader().
* Misc. other header-related cleanups.
|
|
renderers.
|
|
* When no signal colors are provided, 3% of waveform rendering time was spent
converting HSL to RGB over and over. QColor::redF/greenF/blueF are the devil.
* Don't set the pen on every beat in WaveformRenderBeat -- all Qt performance
articles talk about minimizing calls to setPen.
* Fix some repetition (hoist some values out of loops, try to get better
inlining, etc.).
|
|
|
|
|