summaryrefslogtreecommitdiffstats
path: root/src/network
AgeCommit message (Collapse)Author
2021-03-20Qt 5.12: Delete obsolete QT_VERSION_CHECK workaroundsUwe Klotz
2021-01-10Merge branch '2.3' of git@github.com:mixxxdj/mixxx.git into mainUwe Klotz
# Conflicts: # src/preferences/dialog/dlgprefsound.cpp # src/soundio/soundmanagerconfig.h # src/track/cueinfo.cpp # src/track/cueinfo.h
2021-01-09Use r-value references only for constructionUwe Klotz
...and remove redundant std::move() invocations.
2021-01-09WebTask: Fix reading of status code from aborted repliesUwe Klotz
2021-01-08WebTask: Ignore missing Content-Type header for empty repliesUwe Klotz
2021-01-08Move network error handling from NetworkTask into WebTaskUwe Klotz
...and provide the response content if available.
2021-01-08Fix wrong signalUwe Klotz
2021-01-07Do not try to read from failed network repliesUwe Klotz
Fixes QIODevice::read (QNetworkReplyHttpImpl): device not open
2021-01-07WebTask: Fix more state transitions for edge casesUwe Klotz
2021-01-07WebTask: Add missing return statementUwe Klotz
2021-01-07WebTask: Send an aborted signal when task not startedUwe Klotz
2021-01-07Swap function return type and out parameterUwe Klotz
2021-01-07WebTask: Clarify handling of delayed network responsesUwe Klotz
2021-01-06WebTask: Trigger regular abort handling after client-side timeoutUwe Klotz
2021-01-05JsonWebTask: Read QNetworkReply content only onceUwe Klotz
QNetworkReply::readAll() must only be invoked once and consumes the response!
2021-01-05Network response data: Replace inheritance with compositionUwe Klotz
2021-01-05WebTask: Gracefully handle delayed network repliesUwe Klotz
2021-01-04JsonWebTask: Validate query URLsUwe Klotz
2021-01-04Split base class NetworkTask from WebTaskUwe Klotz
2021-01-01Merge remote-tracking branch 'upstream/2.3' into mainBe
2020-12-31Delete local variable to resolve auto-nitpickingUwe Klotz
2020-12-31WebTask: Simplify the consistency checkUwe Klotz
2020-12-31Introduce ScopedDeleteLater helperUwe Klotz
2020-12-31WebTask: Replace QPointer with SafeQPointerUwe Klotz
2020-12-31WebTask: Document and verify thread affinintyUwe Klotz
2020-12-31WebTask: Don't use managed weak pointers (QPointer) directlyUwe Klotz
2020-12-30WebTask: Account for side-effect between deleteLater() and QPointerUwe Klotz
2020-12-30WebTask: Fix swapped linesUwe Klotz
2020-12-14Merge branch '2.3' of git@github.com:mixxxdj/mixxx.git into mainUwe Klotz
2020-12-13Networking: Move shared code into WebTask base classUwe Klotz
2020-12-13WebTask: Fix outdated and wrong commentUwe Klotz
2020-12-11Merge remote-tracking branch 'upstream/2.3' into mainBe
2020-12-11Fix typo in commentsUwe Klotz
2020-12-11Reword commentsUwe Klotz
2020-12-11Improve logging for tracing network failuresUwe Klotz
2020-12-11Detect and prevent duplicate signals on network errorsUwe Klotz
2020-12-08Merge branch '2.3' of git@github.com:mixxxdj/mixxx.git into mainUwe Klotz
# Conflicts: # src/controllers/colormapperjsproxy.cpp # src/controllers/engine/controllerengine.cpp # src/controllers/hid/hidcontroller.cpp # src/database/mixxxdb.cpp # src/library/crate/cratetablemodel.cpp # src/library/dao/trackdao.cpp # src/library/hiddentablemodel.cpp # src/library/library.cpp # src/library/playlisttablemodel.cpp # src/library/trackset/baseplaylistfeature.cpp # src/library/trackset/crate/cratefeaturehelper.cpp # src/mixxxapplication.cpp # src/network/jsonwebtask.cpp # src/preferences/dialog/dlgpreferences.cpp # src/recording/recordingmanager.cpp # src/track/track.cpp # src/widget/wsearchlineedit.cpp
2020-12-07Slimdown moc_compilation.cppDaniel Poelzleithner
The moc_compilation file became unbearable large, easily taking 10 minutes to compile whenever a Q_OBJECT changes. AUTOMOC scans for <basename>_moc.cpp includes and does not add the file to the moc_compilation whenever it is included in the propper cpp file. After this patch, moc_compilation.cpp is empty and the mocs are compiled with the approptial cpp, increasing recompile speeds by a factor of 10 when just a header file changed.
2020-11-28Merge branch '2.3' of git@github.com:mixxxdj/mixxx.git into mainUwe Klotz
# Conflicts: # CMakeLists.txt # src/network/jsonwebtask.cpp # src/util/logging.cpp
2020-11-28JsonWebTask: Replace deprecated FollowRedirectsAttributeJan Holthuis
Fixes: src/network/jsonwebtask.cpp: In function ‘QNetworkRequest mixxx::network::{anonymous}::newRequest(const QUrl&)’: src/network/jsonwebtask.cpp:104:43: error: ‘QNetworkRequest::FollowRedirectsAttribute’ is deprecated: Use RedirectPolicyAttribute [-Werror=deprecated-declarations] 104 | request.setAttribute(QNetworkRequest::FollowRedirectsAttribute, true); | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from /usr/include/qt/QtNetwork/qnetworkaccessmanager.h:44, from /usr/include/qt/QtNetwork/QNetworkAccessManager:1, from src/network/webtask.h:4, from src/network/jsonwebtask.h:7, from src/network/jsonwebtask.cpp:1: /usr/include/qt/QtNetwork/qnetworkrequest.h:97:9: note: declared here 97 | FollowRedirectsAttribute Q_DECL_ENUMERATOR_DEPRECATED_X("Use RedirectPolicyAttribute"), | ^~~~~~~~~~~~~~~~~~~~~~~~
2020-11-22Merge remote-tracking branch 'upstream/2.3' into mainDaniel Schürmann
2020-11-19Pass non-trivial/large function args by referenceJan Holthuis
Fixes a bunch of `-Wclazy-function-args-by-ref` warnings. See https://github.com/KDE/clazy/blob/master/docs/checks/README-function-args-by-ref.md for details. Most of these changes are automated, using the clazy fixit by setting the `CLAZY_EXPORT_FIXES` before compilation and then running: $ mkdir /tmp/patch $ find ../src -iname "*.yaml" -exec mv {} /tmp/patch \; $ clang-apply-replacements /tmp/patch
2020-06-07Merge branch '2.3' of git@github.com:mixxxdj/mixxx.gitUwe Klotz
2020-06-06Detect thread affinity violationsUwe Klotz
2020-06-05Merge branch '2.3' of github.com:mixxxdj/mixxxJan Holthuis
2020-06-04Use QNetworkReply::errorOccured instead of overloaded error signalJan Holthuis
2020-05-19Remove all workarounds for Qt <5.9.0Uwe Klotz
2020-04-28Fix various typosluz.paz
Found via codespell v1.17.0.dev0 ``` codespell -q 3 -S *.ts,*.po,*.rtf,./.git,./src/library,./lib,./build/wix -L ba,chang,ect,everytime,german,hace,iff,jus,ith,lokal,nd,ons,pevent,pparent,preverse,seeked,sheat,sinc,splitted,substract,thru,tim,uint ```
2020-04-12Remove debug assertionUwe Klotz
2020-04-12Clarify error handlingUwe Klotz