summaryrefslogtreecommitdiffstats
path: root/src/mixer
AgeCommit message (Collapse)Author
2021-09-17Reset main window title when all decks stop playingNino Miškić-Pletenac
This fixes regression caused by 37c41e5daf19dcac0b148a5d02792f4c15c81078.
2021-09-07Call loadingTrack() before EngineBuffer::loadTrack() to avoid possible race ↵Daniel Schürmann
condition
2021-07-05Replace trackLoaded and trackUnloaded with a common Track changed signalDaniel Schürmann
2021-07-02Update playerinfo.cppDaniel Schürmann
2021-07-02improve commentDaniel Schürmann
Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>
2021-06-30Update m_currentlyPlayingDeck before emitting a changed signalDaniel Schürmann
2021-06-30Notify PlayerInfo class when a track is unloadedDaniel Schürmann
2021-04-29Replace recursive QMutexes with QRecursiveMutexJan Holthuis
Recursive QMutexes have been deprecated since the 5.15. Fixes warnings like these: src/vinylcontrol/vinylcontrolprocessor.cpp: In constructor ‘VinylControlProcessor::VinylControlProcessor(QObject*, UserSettingsPointer)’: src/vinylcontrol/vinylcontrolprocessor.cpp:28:32: error: ‘QMutex::QMutex(QMutex::RecursionMode)’ is deprecated: Use QRecursiveMutex instead of a recursive QMutex [-Werror=deprecated-declarations] 28 | m_bReloadConfig(false) { | ^ In file included from /usr/include/qt/QtCore/QMutex:1, from src/vinylcontrol/vinylcontrolprocessor.h:6, from src/vinylcontrol/vinylcontrolprocessor.cpp:1: /usr/include/qt/QtCore/qmutex.h:140:14: note: declared here 140 | explicit QMutex(RecursionMode mode); | ^~~~~~
2021-03-11Don't set an offset or bpm lock when creating a track with a bpm value only. ↵Daniel Schürmann
Remove now unused bool parameter.
2021-03-08check bpm lock when setting beat grid of bpmDaniel Schürmann
2021-02-20fix warnings raised when building w/o vinyl controlronso0
2020-12-31Fix current track display/broadcasting/recording when starting auto-DJDaniel Schürmann
2020-12-15Replace null pointer constants (e.g. NULL, 0) with nullptrJan Holthuis
2020-12-15Add missing namespace commentsJan Holthuis
2020-12-07Merge branch '2.3' of github.com:mixxxdj/mixxx into cleanup-headersJan Holthuis
2020-12-07Slimdown moc_compilation.cppDaniel Poelzleithner
The moc_compilation file became unbearable large, easily taking 10 minutes to compile whenever a Q_OBJECT changes. AUTOMOC scans for <basename>_moc.cpp includes and does not add the file to the moc_compilation whenever it is included in the propper cpp file. After this patch, moc_compilation.cpp is empty and the mocs are compiled with the approptial cpp, increasing recompile speeds by a factor of 10 when just a header file changed.
2020-12-02Merge branch '2.3' of github.com:mixxxdj/mixxx into cleanup-headersJan Holthuis
2020-11-19Pass non-trivial/large function args by referenceJan Holthuis
Fixes a bunch of `-Wclazy-function-args-by-ref` warnings. See https://github.com/KDE/clazy/blob/master/docs/checks/README-function-args-by-ref.md for details. Most of these changes are automated, using the clazy fixit by setting the `CLAZY_EXPORT_FIXES` before compilation and then running: $ mkdir /tmp/patch $ find ../src -iname "*.yaml" -exec mv {} /tmp/patch \; $ clang-apply-replacements /tmp/patch
2020-11-17PlayerManager: Use QStringLiteral for string concatenationUwe Klotz
2020-11-17PlayerManager: Use QStringBuilder for composing group stringsUwe Klotz
2020-11-17PreviewButtonDelegate: Replace string formatting with constantUwe Klotz
2020-11-15mixer/auxiliary: Fix emit syntaxJan Holthuis
2020-11-13library,mixer,util: Replace old-style Qt connect() callsJan Holthuis
2020-11-10Remove long copyright headersxerus2000
2020-11-10Use #pragma once everywherexerus2000
2020-10-27Replace implicit casts from double to bool with comparisonsJan Holthuis
This fixes a lot of -Wfloat-conversion warnings on certain compilers.
2020-10-27Use ControlObject::toBool() method to fix -Wfloat-conversion errorsJan Holthuis
This fixes a bunch of warnigs regarding implicit casts from double to bool.
2020-10-26Merge pull request #3200 from ronso0/cloneFromSaplerBe
add [group],CloneFromSampler control
2020-10-25Merge branch '2.2' of github.com:mixxxdj/mixxx into 2.3Jan Holthuis
2020-10-24export sampler bank: add xml suffix also when file name contains '.'ronso0
2020-10-22Basetrackplayer clone: use static_cast<int> instead of lroundronso0
2020-10-22add group,CloneFromSampler controlronso0
2020-10-09Merge branch '2.3' of github.com:mixxxdj/mixxx into float-warnings-pt-3Jan Holthuis
2020-09-29replace #include "track/track.h" by "track_decl.h" in all header filesDaniel Schürmann
2020-09-25Use const/auto to improve type declarationsJan Holthuis
2020-09-25mixer/playerinfo: Add missing typecast to intJan Holthuis
2020-09-25engine/enginexfader: Use CSAMPLE_GAIN for getXfadeGains()Jan Holthuis
2020-09-24Fix various float-to-int conversion warnings by using static_castJan Holthuis
2020-08-05Merge pull request #2988 from Holzhaus/explict-playerinfoDaniel Schürmann
mixer/playerinfo: Make implicit PlayerInfo creation explicit
2020-08-04Fix missing nullptr check.Owen Williams
Clarify that pickNonSyncSyncTarget get return nullptr
2020-08-04mixer/playerinfo: Make implicit PlayerInfo creation explicitJan Holthuis
Until now, the `PlayerInfo` singleton was instantiated implicitly when it was first accessed. This commit makes the instantiation explicit by adding a dedicated `PlayerInfo::create()` method. When running tests directly via `mixxx-test` (i.e. not a via `ctest`), all tests will be executed in the *same* process. Thus, the singleton will be instantiated by the first test that accessses the instance, but stay alive until `mixxx-test` is terminated. The `PlayerInfo` instance will repeatedly call `updateCurrentlyPlayingDeck()` through the `timerEvent()` mehtod during its lifetime. This will access some COs, e.g. `[Master],num_decks`. Depending on the currently running test, these COs may or may not be present. When `QCoreApplication::processEvents()` is called, there might be a `timerEvent()` in the queue and will cause CO access. If the CO is *not* present for that test, the test will throw a `DEBUG_ASSERT`. By making the singleton instantiation more explicit, we can add `PlayerInfo::create()` and `PlayerInfo::destroy()` calls only to the constructor/destructor of text fixtures that need it, and ensure that the timer doesn't cause failed debug assertions in unrelated tests. This fixes the remaining `DEBUG_ASSERT` issues and paves the way for merging PR #2911.
2020-07-01control: Remove ControlFlag::InitializeLater enum valueJan Holthuis
2020-06-23mixer/playermanager: Fix ControlFlag for [AutoDJ],enabled ControlProxyJan Holthuis
2020-06-21control: Refactor ControlProxy and require flag to allow empty keysJan Holthuis
2020-06-21control: Use assertions in ControlDoublePrivate if warn is trueJan Holthuis
2020-06-02Replace std:unique_ptr by parented_ptr to remove double ownership issueDaniel Schürmann
2020-06-02make null checks impliciteDaniel Schürmann
2020-06-01Use override keyword in mixer classesDaniel Schürmann
2020-06-01Silence unneccessary debug message during testDaniel Schürmann
2020-06-01replace NULL with nullptrDaniel Schürmann