Age | Commit message (Collapse) | Author | |
---|---|---|---|
2021-09-17 | Reset main window title when all decks stop playing | Nino Miškić-Pletenac | |
This fixes regression caused by 37c41e5daf19dcac0b148a5d02792f4c15c81078. | |||
2021-09-07 | Call loadingTrack() before EngineBuffer::loadTrack() to avoid possible race ↵ | Daniel Schürmann | |
condition | |||
2021-07-05 | Replace trackLoaded and trackUnloaded with a common Track changed signal | Daniel Schürmann | |
2021-07-02 | Update playerinfo.cpp | Daniel Schürmann | |
2021-07-02 | improve comment | Daniel Schürmann | |
Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com> | |||
2021-06-30 | Update m_currentlyPlayingDeck before emitting a changed signal | Daniel Schürmann | |
2021-06-30 | Notify PlayerInfo class when a track is unloaded | Daniel Schürmann | |
2021-04-29 | Replace recursive QMutexes with QRecursiveMutex | Jan Holthuis | |
Recursive QMutexes have been deprecated since the 5.15. Fixes warnings like these: src/vinylcontrol/vinylcontrolprocessor.cpp: In constructor ‘VinylControlProcessor::VinylControlProcessor(QObject*, UserSettingsPointer)’: src/vinylcontrol/vinylcontrolprocessor.cpp:28:32: error: ‘QMutex::QMutex(QMutex::RecursionMode)’ is deprecated: Use QRecursiveMutex instead of a recursive QMutex [-Werror=deprecated-declarations] 28 | m_bReloadConfig(false) { | ^ In file included from /usr/include/qt/QtCore/QMutex:1, from src/vinylcontrol/vinylcontrolprocessor.h:6, from src/vinylcontrol/vinylcontrolprocessor.cpp:1: /usr/include/qt/QtCore/qmutex.h:140:14: note: declared here 140 | explicit QMutex(RecursionMode mode); | ^~~~~~ | |||
2021-03-11 | Don't set an offset or bpm lock when creating a track with a bpm value only. ↵ | Daniel Schürmann | |
Remove now unused bool parameter. | |||
2021-03-08 | check bpm lock when setting beat grid of bpm | Daniel Schürmann | |
2021-02-20 | fix warnings raised when building w/o vinyl control | ronso0 | |
2020-12-31 | Fix current track display/broadcasting/recording when starting auto-DJ | Daniel Schürmann | |
2020-12-15 | Replace null pointer constants (e.g. NULL, 0) with nullptr | Jan Holthuis | |
2020-12-15 | Add missing namespace comments | Jan Holthuis | |
2020-12-07 | Merge branch '2.3' of github.com:mixxxdj/mixxx into cleanup-headers | Jan Holthuis | |
2020-12-07 | Slimdown moc_compilation.cpp | Daniel Poelzleithner | |
The moc_compilation file became unbearable large, easily taking 10 minutes to compile whenever a Q_OBJECT changes. AUTOMOC scans for <basename>_moc.cpp includes and does not add the file to the moc_compilation whenever it is included in the propper cpp file. After this patch, moc_compilation.cpp is empty and the mocs are compiled with the approptial cpp, increasing recompile speeds by a factor of 10 when just a header file changed. | |||
2020-12-02 | Merge branch '2.3' of github.com:mixxxdj/mixxx into cleanup-headers | Jan Holthuis | |
2020-11-19 | Pass non-trivial/large function args by reference | Jan Holthuis | |
Fixes a bunch of `-Wclazy-function-args-by-ref` warnings. See https://github.com/KDE/clazy/blob/master/docs/checks/README-function-args-by-ref.md for details. Most of these changes are automated, using the clazy fixit by setting the `CLAZY_EXPORT_FIXES` before compilation and then running: $ mkdir /tmp/patch $ find ../src -iname "*.yaml" -exec mv {} /tmp/patch \; $ clang-apply-replacements /tmp/patch | |||
2020-11-17 | PlayerManager: Use QStringLiteral for string concatenation | Uwe Klotz | |
2020-11-17 | PlayerManager: Use QStringBuilder for composing group strings | Uwe Klotz | |
2020-11-17 | PreviewButtonDelegate: Replace string formatting with constant | Uwe Klotz | |
2020-11-15 | mixer/auxiliary: Fix emit syntax | Jan Holthuis | |
2020-11-13 | library,mixer,util: Replace old-style Qt connect() calls | Jan Holthuis | |
2020-11-10 | Remove long copyright headers | xerus2000 | |
2020-11-10 | Use #pragma once everywhere | xerus2000 | |
2020-10-27 | Replace implicit casts from double to bool with comparisons | Jan Holthuis | |
This fixes a lot of -Wfloat-conversion warnings on certain compilers. | |||
2020-10-27 | Use ControlObject::toBool() method to fix -Wfloat-conversion errors | Jan Holthuis | |
This fixes a bunch of warnigs regarding implicit casts from double to bool. | |||
2020-10-26 | Merge pull request #3200 from ronso0/cloneFromSapler | Be | |
add [group],CloneFromSampler control | |||
2020-10-25 | Merge branch '2.2' of github.com:mixxxdj/mixxx into 2.3 | Jan Holthuis | |
2020-10-24 | export sampler bank: add xml suffix also when file name contains '.' | ronso0 | |
2020-10-22 | Basetrackplayer clone: use static_cast<int> instead of lround | ronso0 | |
2020-10-22 | add group,CloneFromSampler control | ronso0 | |
2020-10-09 | Merge branch '2.3' of github.com:mixxxdj/mixxx into float-warnings-pt-3 | Jan Holthuis | |
2020-09-29 | replace #include "track/track.h" by "track_decl.h" in all header files | Daniel Schürmann | |
2020-09-25 | Use const/auto to improve type declarations | Jan Holthuis | |
2020-09-25 | mixer/playerinfo: Add missing typecast to int | Jan Holthuis | |
2020-09-25 | engine/enginexfader: Use CSAMPLE_GAIN for getXfadeGains() | Jan Holthuis | |
2020-09-24 | Fix various float-to-int conversion warnings by using static_cast | Jan Holthuis | |
2020-08-05 | Merge pull request #2988 from Holzhaus/explict-playerinfo | Daniel Schürmann | |
mixer/playerinfo: Make implicit PlayerInfo creation explicit | |||
2020-08-04 | Fix missing nullptr check. | Owen Williams | |
Clarify that pickNonSyncSyncTarget get return nullptr | |||
2020-08-04 | mixer/playerinfo: Make implicit PlayerInfo creation explicit | Jan Holthuis | |
Until now, the `PlayerInfo` singleton was instantiated implicitly when it was first accessed. This commit makes the instantiation explicit by adding a dedicated `PlayerInfo::create()` method. When running tests directly via `mixxx-test` (i.e. not a via `ctest`), all tests will be executed in the *same* process. Thus, the singleton will be instantiated by the first test that accessses the instance, but stay alive until `mixxx-test` is terminated. The `PlayerInfo` instance will repeatedly call `updateCurrentlyPlayingDeck()` through the `timerEvent()` mehtod during its lifetime. This will access some COs, e.g. `[Master],num_decks`. Depending on the currently running test, these COs may or may not be present. When `QCoreApplication::processEvents()` is called, there might be a `timerEvent()` in the queue and will cause CO access. If the CO is *not* present for that test, the test will throw a `DEBUG_ASSERT`. By making the singleton instantiation more explicit, we can add `PlayerInfo::create()` and `PlayerInfo::destroy()` calls only to the constructor/destructor of text fixtures that need it, and ensure that the timer doesn't cause failed debug assertions in unrelated tests. This fixes the remaining `DEBUG_ASSERT` issues and paves the way for merging PR #2911. | |||
2020-07-01 | control: Remove ControlFlag::InitializeLater enum value | Jan Holthuis | |
2020-06-23 | mixer/playermanager: Fix ControlFlag for [AutoDJ],enabled ControlProxy | Jan Holthuis | |
2020-06-21 | control: Refactor ControlProxy and require flag to allow empty keys | Jan Holthuis | |
2020-06-21 | control: Use assertions in ControlDoublePrivate if warn is true | Jan Holthuis | |
2020-06-02 | Replace std:unique_ptr by parented_ptr to remove double ownership issue | Daniel Schürmann | |
2020-06-02 | make null checks implicite | Daniel Schürmann | |
2020-06-01 | Use override keyword in mixer classes | Daniel Schürmann | |
2020-06-01 | Silence unneccessary debug message during test | Daniel Schürmann | |
2020-06-01 | replace NULL with nullptr | Daniel Schürmann | |