Age | Commit message (Collapse) | Author |
|
we have the values impicit by the outher scope statistics in SoundDevicePortAudio
|
|
Conflicts:
CHANGELOG.md
LICENSE
build/wix/LICENSE.rtf
src/defs_version.h
src/engine/controls/ratecontrol.cpp
|
|
|
|
Fix broken Mic mute button (used in Deere) and ...
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
and their registration with the effects system
|
|
This allows for routing all microphones to one effect unit, which
can save CPU cost by processing the same effects only one time.
|
|
and clarify variable names for crossfader bus handles
|
|
|
|
Metronome Effect + Effect Sync refectoring
|
|
|
|
Conflicts:
src/engine/enginemaster.cpp
src/engine/enginemaster.h
|
|
|
|
|
|
|
|
new names are more descriptive of what it does
|
|
|
|
|
|
|
|
"Talkover mix mode" is Mixxx-specific jargon. "Microphone monitor mode"
should be clear to people familiar with general music technology jargon.
Also, move the Measured Round Trip Latency spinbox next to the
microphone monitor mode combobox.
|
|
Delaying the outputs only adds latency. It does not change that the user
must compensate for the latency by playing earlier to play on beat.
|
|
These were only used for tests and created a big maintenance burden.
They also made it so the tests were not actually testing how Mixxx
behaves.
|
|
|
|
|
|
|
|
|
|
|
|
This may be useful when the main speakers are significantly farther from
the DJ than the booth speakers to align the sounds the two speaker
systems.
|
|
|
|
|
|
These should not be PlayerManager's or SoundManager's responsibilities.
|
|
so users do not have to use external programs like Audacity and BUTT
when using external mixers
|
|
I somehow forgot to add this in a previous commit.
|
|
|
|
so both the engine and effects system can access ChannelHandles. This
allows effects to store state for only two output handles. Before, each
channel was used as its own output for in-place effects processing. That
required the effects' state matricies to consume much more memory. Now,
they only need to store the state for each input channel going to the
master and headphone outputs, instead of every channel going to every
other channel.
|
|
to avoid unnecessary buffer copies
|
|
This was causing popping sounds on the master output when routing
microphones to headphones because
ChannelMixer::applyEffectsAndMixChannelsRamping was applying gain to the
channel buffer. To work around this, move the application of gain to
EngineEffectsManager::processPostFaderAndMixRamping, where the channel
input buffer is copied into one of EngineEffectsManager's temporary
processing buffers. Using EngineEffectManager's buffer avoids allocating
a temporary buffer for every EngineChannel.
Also, remove the unused ChannelMixer::mixChannels(Ramping) functions. If
their behavior is desired in the future, nullptr can be passed as the
EngineEffectsManager* argument to
ChannelMixer::applyEffectsInPlaceAndMixChannels(Ramping).
|
|
Do not modify input buffers for processing effects on headphones, but do
modify the buffers in place for the main processing. This also allows
for some optimization by avoiding unnecessary buffer copying.
|
|
EQ and QuickEffect racks are prefader to save CPU processing.
When they were post-fader, they had to be double-processed for
headphones.
|
|
This required two major changes to the effects system:
1. Making effects track their internal state for each input
going to each output, instead of sharing a state only for each
input.
2. Splitting the single combined effects input/output buffer
into a separate input and output buffer.
TODO: fix signal path tests
|
|
Spare users the math so they can just copy the round trip time
measured by jack_iodelay or a similar program.
|
|
Selectable between 3 modes:
* Mics routed to master
* Mics routed to master & booth
* Direct monitoring; mics not mixed in software
TODO: latency compensation for auxiliary inputs
|
|
Previously, in split cue mode, the master gain knob applied to the right
side headphone and the headphone gain knob applied to the left side
headphone. Now, the headphone gain knob controls both sides of the
headphones in split cue mode. This fixes
https://bugs.launchpad.net/mixxx/+bug/1458213
Also add an optimization to skip PFL mix processing when no headphone
output is configured.
|