summaryrefslogtreecommitdiffstats
path: root/src/control
AgeCommit message (Collapse)Author
2021-05-20midi: Make MidiOpCode a properly scoped enum classJan Holthuis
2021-04-28Merge remote-tracking branch 'upstream/2.3' into mainDaniel Schürmann
2021-04-27make '_set_default' an in/out CO, use direct connectionronso0
Co-authored-by: Daniel Schürmann <daschuer@mixxx.org>
2021-02-23Merge branch '2.3' of git@github.com:mixxxdj/mixxx.git into mainUwe Klotz
2021-02-23ControlDoublePrivate: clarify debug assertionBe
2021-02-22ControlDoublePrivate: fix overzealous debug assertionBe
fixes https://bugs.launchpad.net/mixxx/+bug/1912549
2020-12-18ControllerDebug: Clean up method names and add a way to disable testingJan Holthuis
2020-12-17Merge branch 'main' of github.com:mixxxdj/mixxx into ↵Jan Holthuis
controllerengine_refactoring
2020-12-15Merge branch '2.3' of github.com:mixxxdj/mixxx into mainJan Holthuis
2020-12-15Replace null pointer constants (e.g. NULL, 0) with nullptrJan Holthuis
2020-12-08Merge remote-tracking branch 'upstream/main' into controllerengine_refactoringBe
2020-12-07merge 2.3Be
2020-12-08Merge branch '2.3' of git@github.com:mixxxdj/mixxx.git into mainUwe Klotz
# Conflicts: # src/controllers/colormapperjsproxy.cpp # src/controllers/engine/controllerengine.cpp # src/controllers/hid/hidcontroller.cpp # src/database/mixxxdb.cpp # src/library/crate/cratetablemodel.cpp # src/library/dao/trackdao.cpp # src/library/hiddentablemodel.cpp # src/library/library.cpp # src/library/playlisttablemodel.cpp # src/library/trackset/baseplaylistfeature.cpp # src/library/trackset/crate/cratefeaturehelper.cpp # src/mixxxapplication.cpp # src/network/jsonwebtask.cpp # src/preferences/dialog/dlgpreferences.cpp # src/recording/recordingmanager.cpp # src/track/track.cpp # src/widget/wsearchlineedit.cpp
2020-12-07Merge branch '2.3' of github.com:mixxxdj/mixxx into cleanup-headersJan Holthuis
2020-12-07Slimdown moc_compilation.cppDaniel Poelzleithner
The moc_compilation file became unbearable large, easily taking 10 minutes to compile whenever a Q_OBJECT changes. AUTOMOC scans for <basename>_moc.cpp includes and does not add the file to the moc_compilation whenever it is included in the propper cpp file. After this patch, moc_compilation.cpp is empty and the mocs are compiled with the approptial cpp, increasing recompile speeds by a factor of 10 when just a header file changed.
2020-12-02Delete trailing/leading blank linesJan Holthuis
2020-12-02Merge branch '2.3' of github.com:mixxxdj/mixxx into cleanup-headersJan Holthuis
2020-11-29Merge remote-tracking branch 'upstream/main' into controllerengine_refactoringBe
2020-11-22Merge remote-tracking branch 'upstream/2.3' into mainDaniel Schürmann
2020-11-19Pass non-trivial/large function args by referenceJan Holthuis
Fixes a bunch of `-Wclazy-function-args-by-ref` warnings. See https://github.com/KDE/clazy/blob/master/docs/checks/README-function-args-by-ref.md for details. Most of these changes are automated, using the clazy fixit by setting the `CLAZY_EXPORT_FIXES` before compilation and then running: $ mkdir /tmp/patch $ find ../src -iname "*.yaml" -exec mv {} /tmp/patch \; $ clang-apply-replacements /tmp/patch
2020-11-14Merge branch '2.3' of git@github.com:mixxxdj/mixxx.git into mainUwe Klotz
2020-11-14controlobjectscript: Use QVector instead of QListJan Holthuis
QVector should be used if the contained type is larger than the current platform's pointer type. Fixes -Wclazy-inefficient-qlist-soft warning. See https://github.com/KDE/clazy/blob/master/docs/checks/README-inefficient-qlist-soft.md for details.
2020-11-13Merge remote-tracking branch 'upstream/2.3' into cleanup-headersxerus2000
2020-11-12Merge branch '2.3' of git@github.com:mixxxdj/mixxx.git into mainUwe Klotz
# Conflicts: # src/engine/controls/cuecontrol.cpp # src/library/library.cpp
2020-11-12Fix a bunch of clazy-range-loop warningsJan Holthuis
2020-11-10Remove long copyright headersxerus2000
2020-11-10Use #pragma once everywherexerus2000
2020-11-10Remove all @author commentsxerus2000
2020-10-29Merge remote-tracking branch 'upstream/main' into controllerengine_refactoringBe
2020-10-29Merge branch '2.3' of git@github.com:mixxxdj/mixxx.git into mainUwe Klotz
# Conflicts: # src/engine/enginebuffer.cpp # src/engine/sync/synccontrol.cpp
2020-10-28ControlObject: Inline the static toBool() methodJan Holthuis
2020-10-28ControlObject: Simplify and fix static toBool() methodJan Holthuis
The comparison was changed from `value != 0` to `value > 0`. This is unintuitive and misleading, but it needs to be consistent with the non-static toBool() implementation which does the same. A different outcome depending on whether you call the static or non-static version would be even more confusing.
2020-10-27Use more comparisons instead of implicit casts to doubleJan Holthuis
2020-10-27Use ControlObject::toBool() method to fix -Wfloat-conversion errorsJan Holthuis
This fixes a bunch of warnigs regarding implicit casts from double to bool.
2020-10-04Merge remote-tracking branch 'upstream/master' into controllerengine_refactoringBe
2020-10-01Merge branch '2.3' of git@github.com:mixxxdj/mixxx.gitUwe Klotz
2020-09-25control/controllinpotmeter: Make lossy typecast explicitJan Holthuis
2020-09-01assert for missing ControlObjects with --controllerDebug CLI optionBe
2020-09-01Merge remote-tracking branch 'upstream/master' into controllerengine_refactoringBe
2020-08-31Merge remote-tracking branch 'upstream/2.3'Daniel Schürmann
2020-08-30control: Add ControlFlag value to disable DEBUG_ASSERTs on invalid inputJan Holthuis
2020-08-16Merge branch '2.3' of git@github.com:mixxxdj/mixxx.gitUwe Klotz
2020-08-14control: Document ControlFlag enum valuesJan Holthuis
2020-08-14control: Rename ControlFlag to AllowInvalidKeyJan Holthuis
2020-08-14Replace ConfigKey::isNull()/isEmpty() checks with new isValid() methodJan Holthuis
2020-07-12reorganize controller scripting codeBe
* Move src/controllers/engine to src/controllers/scripting * Create src/controllers/scripting/legacy subfolder * Rename ControllerEngine to ControllerScriptHandler * Rename ControllerEngineJSProxy to ControllerScriptInterface
2020-07-08Merge branch '2.3' of git@github.com:mixxxdj/mixxx.gitUwe Klotz
2020-07-08Merge pull request #2918 from uklotzde/controlobjectJan Holthuis
ControlObject/ControlPrivateDouble: Various Fixes
2020-07-07Merge branch '2.3' of git@github.com:mixxxdj/mixxx.gitUwe Klotz
2020-07-06Split get/take of existing/leaked controls into separate functionsUwe Klotz