| Age | Commit message (Collapse) | Author |
|---|
|
|
|
This fixes a pop sound when enabling/disabling the effect in a D+W mode
chain.
|
|
This fixes Reverb adding +6 dB when used alone in a D+W chain without
Echo before it.
|
|
2b72491ee2a0bd761e0d68600b62ebbb3b89dc6c changed the Reverb effect so
that the dry signal was not passed through when the effect unit was in
D+W mode. A new dry/wet parameter was added to compensate for this in
fd25553f2905c07165980084914ed648fe6dfa81 so there would still be a way
to adjust the relative prominence of Reverb in a D+W chain. However, no
change to the mixing of Reverb was needed in the first place. Simply
keeping the dry signal with a Send parameter works in both D/W and D+W
modes.
|
|
Using the Send parameter when the effect unit is in D+W mode does not
work as desired because it reduces the volume of the whole effect unit.
|
|
so Echo and Reverb do not add the dry signal to their output in "Send"
mode
|
|
|
|
|
|
|
|
The previous implementation of the reverb effect was suffering from serious artifacts in terms of feedback / distortion that the original LADSPA plugin doesn't suffer from:
https://bugs.launchpad.net/mixxx/+bug/1647568
I updated the code base to use the latest version (0.9.24) from the original author (http://quitte.de/dsp/caps.html), and in doing this I disabled the unused code with preprocessor directives instead of deleting it, in order to make it easier to update in the future.
Next I tried to track down where the bug was. It turns out that the `SampleUtil::linearCrossfadeBuffers()` call was causing all the feedback problems, and it seems to be safe to remove this. In the future we should use ramping on the parameters.
This commit also adds the missing two controls for damping and blend, and remaps the meta knob from bandwidth to blend, which fixes the following bug:
https://bugs.launchpad.net/mixxx/+bug/1647775
Note that the meaning of "blend" has changed compared to the original source code, as we use it as a "send amount" instead of wet/dry. This has the advantage that the reverb tail is not suddenly cut off when the blend knob is turned down to zero.
In the PR (#1113) it was discussed that in the future we should probably implement wet/dry and send functions at the system level rather than forcing individual effects to implement it.
|
|
|
