Age | Commit message (Collapse) | Author |
|
(we are moving away from scons to cmake, but while we're not on 2.4, we might maintain this compatibility)
|
|
|
|
Imports that are not at the top of file are considered bad style in
Python. See this for details:
https://legacy.python.org/dev/peps/pep-0008/#imports
|
|
|
|
|
|
|
|
|
|
Python3 is picky about byte vs. str variables. From their docs:
...
communicate() returns a tuple (stdout_data, stderr_data). The data will
be strings if streams were opened in text mode; otherwise, bytes.
...
The value returned by _find_qtdirs() is 'bytes', it is later used
together with 'str'. Python3 rejects a mixture of 'byte' and 'str'.
Change the return value to return type 'str'.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
|
|
This reverts commit 3d49037c844e4a37493729388a07d3cc95c24e3d.
When piping ouput from scons during a build sys.stdout.encoding that is
used for decoding output from a subprocess seems to be undefined and
decoding fails:
https://stackoverflow.com/questions/492483/setting-the-correct-encoding-when-piping-stdout-in-python
|
|
|
|
|
|
|
|
|
|
|
|
Fixes:
ERROR:root:QT path does not exist or QT4 is not installed.
ERROR:root:Please specify your QT path by running 'scons qtdir=[path]'
/usr/include/qt5/QtCore/qglobal.h:1052:4: error: #error "You must build your code with position independent code if Qt was built with -reduce-relocations. " "Compile your code with -fPIC (-fPIE is not enough)."
calling /usr/lib/rpm/brp-suse.d/brp-35-rpath
ERROR: RPATH "/usr/include/qt5/lib" on usr/lib/mixxx/plugins/vamp/libmixxxminimal.so is not allowed
ERROR: RPATH "/usr/include/qt5/lib" on usr/lib/mixxx/plugins/soundsource/libsoundsourcewv.so is not allowed
ERROR: RPATH "/usr/include/qt5/lib" on usr/lib/mixxx/plugins/soundsource/libsoundsourcem4a.so is not allowed
ERROR: RPATH "/usr/include/qt5/lib" on usr/bin/mixxx is not allowed
|
|
upstream to the qt5.py maintainer).
|
|
|
|
|