diff options
Diffstat (limited to 'src/engine/sidechain')
-rw-r--r-- | src/engine/sidechain/enginesidechain.cpp | 6 | ||||
-rw-r--r-- | src/engine/sidechain/enginesidechain.h | 6 | ||||
-rw-r--r-- | src/engine/sidechain/shoutconnection.cpp | 4 | ||||
-rw-r--r-- | src/engine/sidechain/shoutconnection.h | 6 |
4 files changed, 11 insertions, 11 deletions
diff --git a/src/engine/sidechain/enginesidechain.cpp b/src/engine/sidechain/enginesidechain.cpp index 1805c880b6..412d0864e2 100644 --- a/src/engine/sidechain/enginesidechain.cpp +++ b/src/engine/sidechain/enginesidechain.cpp @@ -63,9 +63,9 @@ void EngineSideChain::addSideChainWorker(SideChainWorker* pWorker) { m_workers.append(pWorker); } -void EngineSideChain::receiveBuffer(AudioInput input, - const CSAMPLE* pBuffer, - unsigned int iFrames) { +void EngineSideChain::receiveBuffer(const AudioInput& input, + const CSAMPLE* pBuffer, + unsigned int iFrames) { VERIFY_OR_DEBUG_ASSERT(input.getType() == AudioInput::RECORD_BROADCAST) { qDebug() << "WARNING: AudioInput type is not RECORD_BROADCAST. Ignoring incoming buffer."; return; diff --git a/src/engine/sidechain/enginesidechain.h b/src/engine/sidechain/enginesidechain.h index 094d406509..15209e2fdc 100644 --- a/src/engine/sidechain/enginesidechain.h +++ b/src/engine/sidechain/enginesidechain.h @@ -25,9 +25,9 @@ class EngineSideChain : public QThread, public AudioDestination { // Thin wrapper around writeSamples that is used by SoundManager when receiving // from a sound card input instead of the engine - void receiveBuffer(AudioInput input, - const CSAMPLE* pBuffer, - unsigned int iFrames) override; + void receiveBuffer(const AudioInput& input, + const CSAMPLE* pBuffer, + unsigned int iFrames) override; // Thread-safe, blocking. void addSideChainWorker(SideChainWorker* pWorker); diff --git a/src/engine/sidechain/shoutconnection.cpp b/src/engine/sidechain/shoutconnection.cpp index 6c2b93c63a..5e2545c346 100644 --- a/src/engine/sidechain/shoutconnection.cpp +++ b/src/engine/sidechain/shoutconnection.cpp @@ -862,7 +862,7 @@ void ShoutConnection::updateMetaData() { } } -void ShoutConnection::errorDialog(QString text, QString detailedError) { +void ShoutConnection::errorDialog(const QString& text, const QString& detailedError) { qWarning() << "Streaming error: " << detailedError; ErrorDialogProperties* props = ErrorDialogHandler::instance()->newDialogProperties(); props->setType(DLG_WARNING); @@ -878,7 +878,7 @@ void ShoutConnection::errorDialog(QString text, QString detailedError) { setState(NETWORKSTREAMWORKER_STATE_ERROR); } -void ShoutConnection::infoDialog(QString text, QString detailedInfo) { +void ShoutConnection::infoDialog(const QString& text, const QString& detailedInfo) { ErrorDialogProperties* props = ErrorDialogHandler::instance()->newDialogProperties(); props->setType(DLG_INFO); props->setTitle(tr("Connection message")); diff --git a/src/engine/sidechain/shoutconnection.h b/src/engine/sidechain/shoutconnection.h index eb0a15a6eb..032774d85e 100644 --- a/src/engine/sidechain/shoutconnection.h +++ b/src/engine/sidechain/shoutconnection.h @@ -70,7 +70,7 @@ class ShoutConnection } void setStatus(int newState) { - return m_pProfile->setConnectionStatus(newState); + m_pProfile->setConnectionStatus(newState); } int getStatus() { return m_pProfile->connectionStatus(); @@ -96,8 +96,8 @@ class ShoutConnection void updateMetaData(); // Common error dialog creation code for run-time exceptions. Notify user // when connected or disconnected and so on - void errorDialog(QString text, QString detailedError); - void infoDialog(QString text, QString detailedError); + void errorDialog(const QString& text, const QString& detailedError); + void infoDialog(const QString& text, const QString& detailedError); void serverWrite(unsigned char *header, unsigned char *body, int headerLen, int bodyLen); |